Merge pull request #99107 from AmarBadal/ambadal_pr_datastore_fixes

fixed issues with json object for cred

Author: jborsecnik

articles/machine-learning/how-to-datastore.md

@@ -124,19 +124,20 @@ ml_client.create_or_update(store)
 
 ```python
 from azure.ai.ml.entities import AzureBlobDatastore
+from azure.ai.ml.entities._datastore.credentials import AccountKeyCredentials
 from azure.ai.ml import MLClient
 
 ml_client = MLClient.from_config()
 
 store = AzureBlobDatastore(
-    name="blob-protocol-example",
+    name="blob_protocol_example",
     description="Datastore pointing to a blob container using wasbs protocol.",
     account_name="mytestblobstore",
     container_name="data-container",
     protocol="wasbs",
-    credentials={
-        "account_key": "XXXxxxXXXxXXXXxxXXXXXxXXXXXxXxxXxXXXxXXXxXXxxxXXxxXXXxXxXXXxxXxxXXXXxxxxxXXxxxxxxXXXxXXX"
-    },
+    credentials=AccountKeyCredentials(
+        account_key="XXXxxxXXXxXXXXxxXXXXXxXXXXXxXxxXxXXXxXXXxXXxxxXXxxXXXxXxXXXxxXxxXXXXxxxxxXXxxxxxxXXXxXXX"
+    ),
 )
 
 ml_client.create_or_update(store)
@@ -146,18 +147,19 @@ ml_client.create_or_update(store)
 
 ```python
 from azure.ai.ml.entities import AzureBlobDatastore
+from azure.ai.ml.entities._datastore.credentials import SasTokenCredentials
 from azure.ai.ml import MLClient
 
 ml_client = MLClient.from_config()
 
 store = AzureBlobDatastore(
-    name="blob-sas-example",
+    name="blob_sas_example",
     description="Datastore pointing to a blob container using SAS token.",
     account_name="mytestblobstore",
     container_name="data-container",
-    credentials={
-        "sas_token": "?xx=XXXX-XX-XX&xx=xxxx&xxx=xxx&xx=xxxxxxxxxxx&xx=XXXX-XX-XXXXX:XX:XXX&xx=XXXX-XX-XXXXX:XX:XXX&xxx=xxxxx&xxx=XXxXXXxxxxxXXXXXXXxXxxxXXXXXxxXXXXXxXXXXxXXXxXXxXX"
-    },
+    credentials=SasTokenCredentials(
+        sas_token= "?xx=XXXX-XX-XX&xx=xxxx&xxx=xxx&xx=xxxxxxxxxxx&xx=XXXX-XX-XXXXX:XX:XXX&xx=XXXX-XX-XXXXX:XX:XXX&xxx=xxxxx&xxx=XXxXXXxxxxxXXXXXXXxXxxxXXXXXxxXXXXXxXXXXxXXXxXXxXX"
+    ),
 )
 
 ml_client.create_or_update(store)
@@ -230,20 +232,22 @@ ml_client.create_or_update(store)
 
 ```python
 from azure.ai.ml.entities import AzureDataLakeGen2Datastore
+from azure.ai.ml.entities._datastore.credentials import ServicePrincipalCredentials
+
 from azure.ai.ml import MLClient
 
 ml_client = MLClient.from_config()
 
 store = AzureDataLakeGen2Datastore(
-    name="adls-gen2-example",
+    name="adls_gen2_example",
     description="Datastore pointing to an Azure Data Lake Storage Gen2.",
     account_name="mytestdatalakegen2",
     filesystem="my-gen2-container",
-    credentials={
-        "tenant_id": "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
-        "client_id": "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
-        "client_secret": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
-    },
+     credentials=ServicePrincipalCredentials(
+        tenant_id= "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
+        client_id= "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
+        client_secret= "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
+    ),
 )
 
 ml_client.create_or_update(store)
@@ -298,18 +302,19 @@ az ml datastore create --file my_files_datastore.yml
 
 ```python
 from azure.ai.ml.entities import AzureFileDatastore
+from azure.ai.ml.entities._datastore.credentials import AccountKeyCredentials
 from azure.ai.ml import MLClient
 
 ml_client = MLClient.from_config()
 
 store = AzureFileDatastore(
-    name="file-example",
+    name="file_example",
     description="Datastore pointing to an Azure File Share.",
     account_name="mytestfilestore",
     file_share_name="my-share",
-    credentials={
-        "account_key": "XXXxxxXXXxXXXXxxXXXXXxXXXXXxXxxXxXXXxXXXxXXxxxXXxxXXXxXxXXXxxXxxXXXXxxxxxXXxxxxxxXXXxXXX"
-    },
+    credentials=AccountKeyCredentials(
+        account_key= "XXXxxxXXXxXXXXxxXXXXXxXXXXXxXxxXxXXXxXXXxXXxxxXXxxXXXxXxXXXxxXxxXXXXxxxxxXXxxxxxxXXXxXXX"
+    ),
 )
 
 ml_client.create_or_update(store)
@@ -319,18 +324,19 @@ ml_client.create_or_update(store)
 
 ```python
 from azure.ai.ml.entities import AzureFileDatastore
+from azure.ai.ml.entities._datastore.credentials import SasTokenCredentials
 from azure.ai.ml import MLClient
 
 ml_client = MLClient.from_config()
 
 store = AzureFileDatastore(
-    name="file-sas-example",
+    name="file_sas_example",
     description="Datastore pointing to an Azure File Share using SAS token.",
     account_name="mytestfilestore",
     file_share_name="my-share",
-    credentials={
-        "sas_token": "?xx=XXXX-XX-XX&xx=xxxx&xxx=xxx&xx=xxxxxxxxxxx&xx=XXXX-XX-XXXXX:XX:XXX&xx=XXXX-XX-XXXXX:XX:XXX&xxx=xxxxx&xxx=XXxXXXxxxxxXXXXXXXxXxxxXXXXXxxXXXXXxXXXXxXXXxXXxXX"
-    },
+    credentials=SasTokenCredentials(
+        sas_token="?xx=XXXX-XX-XX&xx=xxxx&xxx=xxx&xx=xxxxxxxxxxx&xx=XXXX-XX-XXXXX:XX:XXX&xx=XXXX-XX-XXXXX:XX:XXX&xxx=xxxxx&xxx=XXxXXXxxxxxXXXXXXXxXxxxXXXXXxxXXXXXxXXXXxXXXxXXxXX"
+    ),
 )
 
 ml_client.create_or_update(store)
@@ -400,19 +406,20 @@ ml_client.create_or_update(store)
 
 ```python
 from azure.ai.ml.entities import AzureDataLakeGen1Datastore
+from azure.ai.ml.entities._datastore.credentials import ServicePrincipalCredentials
 from azure.ai.ml import MLClient
 
 ml_client = MLClient.from_config()
 
 store = AzureDataLakeGen1Datastore(
-    name="adls-gen1-example",
+    name="adls_gen1_example",
     description="Datastore pointing to an Azure Data Lake Storage Gen1.",
     store_name="mytestdatalakegen1",
-    credentials={
-        "tenant_id": "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
-        "client_id": "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
-        "client_secret": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
-    },
+    credentials=ServicePrincipalCredentials(
+        tenant_id= "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
+        client_id= "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
+        client_secret= "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
+    ),
 )
 
 ml_client.create_or_update(store)