Skip to content

Commit 9eedc39

Browse files
author
nshankar
committed
Resolve comments
Signed-off-by: nshankar <[email protected]>
1 parent 02d28a4 commit 9eedc39

File tree

3 files changed

+28
-27
lines changed

3 files changed

+28
-27
lines changed

‎articles/aks/istio-meshconfig.md

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ This article walks through how to configure Istio-based service mesh add-on for
1616

1717
## Prerequisites
1818

19-
This guide assumes you followed the [documentation](./istio-deploy-addon.md) to enable the Istio add-on on an AKS cluster.
19+
This guide assumes you followed the [documentation][istio-deploy-addon] to enable the Istio add-on on an AKS cluster.
2020

2121
## Set up configuration on cluster
2222

@@ -85,42 +85,42 @@ Mesh configuration and the list of allowed/supported fields are revision specifi
8585

8686
| **Field** | **Supported** | **Notes** |
8787
|-----------|---------------|-----------|
88-
| proxyListenPort | false |
89-
| proxyInboundListenPort | false |
90-
| proxyHttpPort | false |
88+
| proxyListenPort | false | - |
89+
| proxyInboundListenPort | false | - |
90+
| proxyHttpPort | false | - |
9191
| connectTimeout | false | Configurable in [DestinationRule](https://istio.io/latest/docs/reference/config/networking/destination-rule/#ConnectionPoolSettings-TCPSettings) |
9292
| tcpKeepAlive | false | Configurable in [DestinationRule](https://istio.io/latest/docs/reference/config/networking/destination-rule/#ConnectionPoolSettings-TCPSettings) |
9393
| defaultConfig | true | Used to configure [ProxyConfig](https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#ProxyConfig) |
9494
| outboundTrafficPolicy | true | Also configurable in [Sidecar CR](https://istio.io/latest/docs/reference/config/networking/sidecar/#OutboundTrafficPolicy) |
95-
| extensionProviders | false |
96-
| defaultProviders | false |
97-
| accessLogFile | true |
98-
| accessLogFormat | true |
99-
| accessLogEncoding | true |
100-
| enableTracing | true |
101-
| enableEnvoyAccessLogService | true |
102-
| disableEnvoyListenerLog | true |
103-
| trustDomain | false |
104-
| trustDomainAliases | false |
95+
| extensionProviders | false | - |
96+
| defaultProviders | false | - |
97+
| accessLogFile | true | - |
98+
| accessLogFormat | true | - |
99+
| accessLogEncoding | true | - |
100+
| enableTracing | true | - |
101+
| enableEnvoyAccessLogService | true | - |
102+
| disableEnvoyListenerLog | true | - |
103+
| trustDomain | false | - |
104+
| trustDomainAliases | false | - |
105105
| caCertificates | false | Configurable in [DestinationRule](https://istio.io/latest/docs/reference/config/networking/destination-rule/#ClientTLSSettings) |
106106
| defaultServiceExportTo | false | Configurable in [ServiceEntry](https://istio.io/latest/docs/reference/config/networking/service-entry/#ServiceEntry) |
107107
| defaultVirtualServiceExportTo | false | Configurable in [VirtualService](https://istio.io/latest/docs/reference/config/networking/virtual-service/#VirtualService) |
108108
| defaultDestinationRuleExportTo | false | Configurable in [DestinationRule](https://istio.io/latest/docs/reference/config/networking/destination-rule/#DestinationRule) |
109109
| localityLbSetting | false | Configurable in [DestinationRule](https://istio.io/latest/docs/reference/config/networking/destination-rule/#LoadBalancerSettings) |
110-
| dnsRefreshRate | false |
110+
| dnsRefreshRate | false | - |
111111
| h2UpgradePolicy | false | Configurable in [DestinationRule](https://istio.io/latest/docs/reference/config/networking/destination-rule/#ConnectionPoolSettings-HTTPSettings) |
112-
| enablePrometheusMerge | true |
113-
| discoverySelectors | true |
114-
| pathNormalization | false |
112+
| enablePrometheusMerge | true | - |
113+
| discoverySelectors | true | - |
114+
| pathNormalization | false | - |
115115
| defaultHttpRetryPolicy | false | Configurable in [VirtualService](https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPRetry) |
116-
| serviceSettings | false |
117-
| meshMTLS | false |
118-
| tlsDefaults | false |
116+
| serviceSettings | false | - |
117+
| meshMTLS | false | - |
118+
| tlsDefaults | false | - |
119119

120120
### ProxyConfig (meshConfig.defaultConfig)
121121

122-
| **Field** | **Supported** | **Notes** |
123-
|-----------|---------------|-----------|
122+
| **Field** | **Supported** |
123+
|-----------|---------------|
124124
| tracingServiceName | true |
125125
| drainDuration | true |
126126
| statsUdpAddress | false |
@@ -158,4 +158,4 @@ Fields present in [open source MeshConfig reference documentation][istio-meshcon
158158
159159
[istio-meshconfig]: https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/
160160
[istio-sidecar-race-condition]: https://istio.io/latest/docs/ops/common-problems/injection/#pod-or-containers-start-with-network-issues-if-istio-proxy-is-not-ready
161-
161+
[istio-deploy-addon]: istio-deploy-addon.md

‎articles/aks/istio-plugin-ca.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The add-on requires Azure CLI version 2.57.0 or later installed. You can run `az
4747
> When rotating certificates, to control how quickly the secrets are synced down to the cluster you can use the `--rotation-poll-interval` parameter of the Azure Key Vault Secrets Provider add-on. For example:
4848
> `az aks addon update --resource-group $RESOURCE_GROUP --name $CLUSTER --addon azure-keyvault-secrets-provider --enable-secret-rotation --rotation-poll-interval 20s`
4949

50-
1. Authorize the system-assigned managed identity of the add-on to have access to the Azure Key Vault resource:
50+
1. Authorize the user-assigned managed identity of the add-on to have access to the Azure Key Vault resource:
5151

5252
```bash
5353
OBJECT_ID=$(az aks show --resource-group $RESOURCE_GROUP --name $CLUSTER --query 'addonProfiles.azureKeyvaultSecretsProvider.identity.objectId' -o tsv)
@@ -56,7 +56,7 @@ The add-on requires Azure CLI version 2.57.0 or later installed. You can run `az
5656
```
5757

5858
> [!NOTE]
59-
> If you created your Key Vault with Azure RBAC Authorization, follow the instructions [here](https://learn.microsoft.com/azure/key-vault/general/rbac-guide) to create permissions for the managed identity. Add a role assignment for `Key Vault Reader` for the cluster's system-assigned managed identity.
59+
> If you created your Key Vault with Azure RBAC Authorization, follow the instructions [here][akv-rbac-guide] to create permissions for the managed identity. Add a role assignment for `Key Vault Reader` for the cluster's system-assigned managed identity.
6060
6161
## Set up Istio-based service mesh addon with plug-in CA certificates
6262
@@ -253,6 +253,7 @@ You may need to periodically rotate the certificate authorities for security or
253253

254254
[akv-quickstart]: ../key-vault/general/quick-create-cli.md
255255
[akv-addon]: ./csi-secrets-store-driver.md
256+
[akv-rbac-guide]: ../key-vault/general/rbac-guide.md
256257
[install-azure-cli]: /cli/azure/install-azure-cli
257258
[az-feature-register]: /cli/azure/feature#az-feature-register
258259
[az-feature-show]: /cli/azure/feature#az-feature-show

‎articles/aks/istio-upgrade.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ author: shashankbarsin
1111

1212
This article addresses upgrade experiences for Istio-based service mesh add-on for Azure Kubernetes Service (AKS).
1313

14-
New Istio add-on releases are announced via [AKS release notes](https://github.com/Azure/AKS/releases).
14+
Announcements about the releases of new minor revisions or patches to the Istio-based service mesh add-on are published in the [AKS release notes][aks-release-notes].
1515

1616
## Minor revision upgrade
1717

0 commit comments

Comments
 (0)