Updates based on bugbash feedback

Author: natekimball-msft

articles/communication-services/quickstarts/email/includes/send-email-java.md

@@ -119,7 +119,7 @@ EmailClient emailClient = new EmailClientBuilder()
 
 ### Option 2: Authenticate using Azure Active Directory
 
-A `DefaultAzureCredential` object must be passed to the `EmailClientBuilder` via the `credential()` method. An endpoint must also be set via the `endpoint()` method.
+A [DefaultAzureCredential](https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/identity/azure-identity#defaultazurecredential) object must be passed to the `EmailClientBuilder` via the `credential()` method. An endpoint must also be set via the `endpoint()` method.
 
 The `AZURE_CLIENT_SECRET`, `AZURE_CLIENT_ID`, and `AZURE_TENANT_ID` environment variables are needed to create a `DefaultAzureCredential` object.
 
@@ -158,10 +158,43 @@ EmailMessage message = new EmailMessage()
     .setSubject("Welcome to Azure Communication Services Email")
     .setBodyPlainText("This email message is sent from Azure Communication Services Email using the Java SDK.");
 
-SyncPoller<EmailSendResult, EmailSendResult> poller = emailClient.beginSend(message, null);
-PollResponse<EmailSendResult> response = poller.waitForCompletion();
-
-System.out.println("Operation Id: " + response.getValue().getId());
+try
+{
+    SyncPoller<EmailSendResult, EmailSendResult> poller = emailClient.beginSend(message, null);
+
+    PollResponse<EmailSendResult> pollResponse = null;
+
+    Duration timeElapsed = Duration.ofSeconds(0);
+
+        while (pollResponse == null
+                || pollResponse.getStatus() == LongRunningOperationStatus.NOT_STARTED
+                || pollResponse.getStatus() == LongRunningOperationStatus.IN_PROGRESS)
+        {
+            pollResponse = poller.poll();
+            System.out.println("Email send poller status: " + pollResponse.getStatus());
+
+            Thread.sleep(POLLER_WAIT_TIME.toMillis());
+            timeElapsed = timeElapsed.plus(POLLER_WAIT_TIME);
+
+            if (timeElapsed.compareTo(POLLER_WAIT_TIME.multipliedBy(18)) >= 0)
+            {
+                throw new RuntimeException("Polling timed out.");
+            }
+        }
+
+        if (poller.getFinalResult().getStatus() == EmailSendStatus.SUCCEEDED)
+        {
+            System.out.printf("Successfully sent the email (operation id: %s)", poller.getFinalResult().getId());
+        }
+        else
+        {
+            throw new RuntimeException(poller.getFinalResult().getError().getMessage());
+        }
+}
+catch (Exception exception)
+{
+    System.out.println(exception.getMessage());
+}
 ```
 
 Make these replacements in the code:
@@ -227,15 +260,17 @@ EmailMessage message = new EmailMessage()
     .setSenderAddress("<[email protected]>")
     .setSubject("Welcome to Azure Communication Services Email")
     .setBodyPlainText("This email message is sent from Azure Communication Services Email using the Java SDK.")
-    .setToRecipients(toAddress1, toAddress2);
+    .setToRecipients(toAddress1, toAddress2)
+    .setCcRecipients(toAddress1, toAddress2)
+    .setBccRecipients(toAddress1, toAddress2)
 
 SyncPoller<EmailSendResult, EmailSendResult> poller = emailClient.beginSend(message, null);
 PollResponse<EmailSendResult> response = poller.waitForCompletion();
 
 System.out.println("Operation Id: " + response.getValue().getId());
 ```
 
-You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-java-quickstarts/tree/main/send-email)
+You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-java-quickstarts/tree/main/send-email-advanced)
 
 ### Send an email message with attachments
 
@@ -264,4 +299,4 @@ System.out.println("Operation Id: " + response.getValue().getId());
 
 For more information on acceptable MIME types for email attachments, see the [allowed MIME types](../../../concepts/email/email-attachment-allowed-mime-types.md) documentation.
 
-You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-java-quickstarts/tree/main/send-email)
+You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-java-quickstarts/tree/main/send-email-advanced)

articles/communication-services/quickstarts/email/includes/send-email-js.md

@@ -172,7 +172,30 @@ async function main() {
     };
 
     const poller = await emailClient.beginSend(message);
-    const response = await poller.pollUntilDone();
+
+    if (!poller.getOperationState().isStarted) {
+      throw "Poller was not started."
+    }
+
+    let timeElapsed = 0;
+    while(!poller.isDone()) {
+      poller.poll();
+      console.log("Email send polling in progress");
+
+      await new Promise(resolve => setTimeout(resolve, POLLER_WAIT_TIME * 1000));
+      timeElapsed += 10;
+
+      if(timeElapsed > 18 * POLLER_WAIT_TIME) {
+        throw "Polling timed out.";
+      }
+    }
+
+    if(poller.getResult().status === KnownEmailSendStatus.Succeeded) {
+      console.log(`Successfully sent the email (operation id: ${poller.getResult().id})`);
+    }
+    else {
+      throw poller.getResult().error;
+    }
   } catch (e) {
     console.log(e);
   }
@@ -273,7 +296,7 @@ const message = {
   attachments: [
     {
       name: path.basename(filePath),
-      contentType: "text/plain",
+      contentType: "<mime-type-for-your-file>",
       contentInBase64: readFileSync(filePath, "base64"),
     }
   ]

articles/communication-services/quickstarts/email/includes/send-email-net.md

@@ -124,12 +124,12 @@ EmailClient emailClient = new EmailClient(connectionString);
 
 ### Option 2: Authenticate using Azure Active Directory
 
-To authenticate using Azure Active Directory, install the `Azure.Identity` library package for .NET by using the `dotnet add package` command.
+To authenticate using [Azure Active Directory](https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/identity/Azure.Identity), install the `Azure.Identity` library package for .NET by using the `dotnet add package` command.
 
 ```console
 dotnet add package Azure.Identity
 ```
-Open **Program.cs** in a text editor and replace the body of the `Main` method with code to initialize an `EmailClient` using `DefaultAzureCredential`. The Azure Identity SDK reads values from three environment variables at runtime to authenticate the application. Learn how to [create an Azure Active Directory Registered Application and set the environment variables](../../identity/service-principal.md?pivots=platform-azcli).
+Open **Program.cs** in a text editor and replace the body of the `Main` method with code to initialize an `EmailClient` using [DefaultAzureCredential](https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/identity/Azure.Identity#defaultazurecredential). The Azure Identity SDK reads values from three environment variables at runtime to authenticate the application. Learn how to [create an Azure Active Directory Registered Application and set the environment variables](../../identity/service-principal.md?pivots=platform-azcli).
 
 ```csharp
 // This code demonstrates how to authenticate to your Communication Service resource using

articles/communication-services/quickstarts/email/includes/send-email-python.md

@@ -165,7 +165,7 @@ email_client = EmailClient.from_connection_string(<connection_string>)
 
 ### Option 2: Authenticate using Azure Active Directory
 
-You can also use Active Directory authentication using DefaultAzureCredential.
+You can also use Active Directory authentication using [DefaultAzureCredential](../../../concepts/authentication.md).
 
 ```python
 from azure.communication.email import EmailClient
@@ -242,7 +242,7 @@ POLLER_WAIT_TIME = 10
 try:
     email_client = EmailClient.from_connection_string(connection_string)
 
-    poller = client.begin_send(message);
+    poller = email_client.begin_send(message);
 
     time_elapsed = 0
     while not poller.done():
@@ -254,7 +254,7 @@ try:
         if time_elapsed > 18 * POLLER_WAIT_TIME:
             raise RuntimeError("Polling timed out.")
 
-    if poller.status() == "Succeeded":
+    if poller.result()["status"] == "Succeeded":
         print(f"Successfully sent the email (operation id: {poller.result()['id']})")
     else:
         raise RuntimeError(str(poller.result()["error"]))
@@ -279,7 +279,7 @@ You can download the sample app from [GitHub](https://github.com/Azure-Samples/c
 
 ### Send an email message to multiple recipients
 
-We can define multiple recipients by adding more EmailAddresses to the EmailRecipients object. These addresses can be added as `to`, `cc`, or `bcc` recipient lists accordingly.
+We can define multiple recipients by adding more email addresses to the `recipients` object. These addresses can be added as `to`, `cc`, or `bcc` recipient lists accordingly.
 
 ```python
 message = {
@@ -306,20 +306,18 @@ message = {
 }
 ```
 
-You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-java-quickstarts/tree/main/send-email)
+You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-python-quickstarts/tree/main/send-email-advanced)
 
 
 ### Send an email message with attachments
 
-We can add an attachment by defining an EmailAttachment object and adding it to our EmailMessage object. Read the attachment file and encode it using Base64. Decode the bytes as a string and pass it into the EmailAttachment object.
+We can add an attachment by defining an `attachment` and adding it to the `attachments` of our `message` object. Read the attachment file and encode it using Base64. Decode the bytes as a string and pass it into the `attachment` object.
 
 ```python
 import base64
 
-with open("<your-attachment-path>", "rb") as file:
-    file_bytes = file.read()
-
-file_bytes_b64 = base64.b64encode(file_bytes)
+with open("<path-to-your-attachment>", "rb") as file:
+    file_bytes_b64 = base64.b64encode(file.read())
 
 message = {
     "content": {
@@ -348,4 +346,4 @@ message = {
 
 For more information on acceptable MIME types for email attachments, see the [allowed MIME types](../../../concepts/email/email-attachment-allowed-mime-types.md) documentation.
 
-You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-java-quickstarts/tree/main/send-email)
+You can download the sample app demonstrating this action from [GitHub](https://github.com/Azure-Samples/communication-services-python-quickstarts/tree/main/send-email-advanced)