Skip to content

Commit a90c844

Browse files
committed
Fixed Review Comments
1 parent 161503c commit a90c844

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

articles/azure-app-configuration/enable-dynamic-configuration-java-spring-app.md

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -34,35 +34,35 @@ App Configuration exposes `AppConfigurationRefresh` which can be used to check i
3434

3535
1. Update HelloController to use `AppConfigurationRefresh`.
3636

37-
```java
38-
import com.azure.spring.cloud.config.AppConfigurationRefresh;
37+
```java
38+
import com.azure.spring.cloud.config.AppConfigurationRefresh;
3939

40-
...
41-
42-
import com.azure.spring.cloud.config.AppConfigurationRefresh;
43-
44-
@RestController
45-
public class HelloController {
46-
private final MessageProperties properties;
40+
...
4741

48-
@Autowired(required = false)
49-
private AppConfigurationRefresh refresh;
50-
51-
public HelloController(MessageProperties properties) {
52-
this.properties = properties;
53-
}
54-
55-
@GetMapping
56-
public String getMessage() throws InterruptedException, ExecutionException {
57-
if (refresh != null) {
58-
refresh.refreshConfigurations();
42+
import com.azure.spring.cloud.config.AppConfigurationRefresh;
43+
44+
@RestController
45+
public class HelloController {
46+
private final MessageProperties properties;
47+
48+
@Autowired(required = false)
49+
private AppConfigurationRefresh refresh;
50+
51+
public HelloController(MessageProperties properties) {
52+
this.properties = properties;
53+
}
54+
55+
@GetMapping
56+
public String getMessage() throws InterruptedException, ExecutionException {
57+
if (refresh != null) {
58+
refresh.refreshConfigurations();
59+
}
60+
return "Message: " + properties.getMessage();
5961
}
60-
return "Message: " + properties.getMessage();
6162
}
62-
}
63-
```
63+
```
6464

65-
`AppConfigurationRefresh`'s `refreshConfigurations()` returns a `Future` that is true if a refresh has been triggered, and false if not. False means either the cache expiration time hasn't expired, there was no change, or another thread is currently checking for a refresh.
65+
`AppConfigurationRefresh`'s `refreshConfigurations()` returns a `Future` that is true if a refresh has been triggered, and false if not. False means either the cache expiration time hasn't expired, there was no change, or another thread is currently checking for a refresh.
6666

6767
1. Update `bootstrap.properties` to enable refresh
6868

articles/azure-app-configuration/enable-dynamic-configuration-java-spring-push-refresh.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ In this tutorial, you learn how to:
6565
</dependency>
6666
```
6767

68-
1. Setup [Maven App Service Deployment](../app-service/quickstart-java.md?tabs=javase) so the application can be deployed to Azure App Service via Maven.
68+
1. Set up [Maven App Service Deployment](../app-service/quickstart-java.md?tabs=javase) so the application can be deployed to Azure App Service via Maven.
6969

7070
```console
7171
mvn com.microsoft.azure:azure-webapp-maven-plugin:1.12.0:config
@@ -144,7 +144,7 @@ Event Grid Web Hooks require validation on creation. You can validate by followi
144144
145145
1. Click on `Create` to create the event subscription. When `Create` is selected a registration request for the Web Hook will be sent to your application. This is received by the Azure App Configuration client library, verified, and returns a valid response.
146146
147-
1. Click on `Event Subscriptions` in the `Events` pane to validated that the subscription was created successfully.
147+
1. Click on `Event Subscriptions` in the `Events` pane to validate that the subscription was created successfully.
148148
149149
:::image type="content" source="./media/event-subscription-view-webhook.png" alt-text="Web Hook shows up in a table on the bottom of the page." :::
150150

articles/azure-app-configuration/howto-convert-to-the-new-spring-boot.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ az appconfig kv import -n your-stores-name -s file --format properties --label d
6161

6262
or use the Import/Export feature in the portal.
6363

64-
When you are completely moved to the new version, you can removed the old keys by running:
64+
When you are completely moved to the new version, you can remove the old keys by running:
6565

6666
```azurecli
6767
az appconfig kv delete -n ConversionTest --key /application_dev/*

0 commit comments

Comments
 (0)