Skip to content

Commit ac0fa36

Browse files
Merge pull request #288877 from Akhilesh-microsoft/ACA/authentication_github
The article seems well written to me, Verified the article, reviewed the content, and introduced minor tweaks. Updated the latest content and ms.date w.r.t freshness pass.
2 parents 1b2fc77 + 2a60a44 commit ac0fa36

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

articles/container-apps/authentication-github.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ services: container-apps
55
author: craigshoemaker
66
ms.service: azure-container-apps
77
ms.topic: how-to
8-
ms.date: 04/20/2022
8+
ms.date: 10/28/2024
99
ms.author: cshoe
1010
---
1111

@@ -17,11 +17,11 @@ To complete the procedure in this article, you need a GitHub account. To create
1717

1818
## <a name="github-register"> </a>Register your application with GitHub
1919

20-
1. Sign in to the [Azure portal] and go to your application. Copy your **URL**. You'll use it to configure your GitHub app.
20+
1. Sign in to the [Azure portal] and go to your application. Copy your **URL**. You use it to configure your GitHub app.
2121
1. Follow the instructions for [creating an OAuth app on GitHub](https://docs.github.com/developers/apps/building-oauth-apps/creating-an-oauth-app). In the **Authorization callback URL** section, enter the HTTPS URL of your app and append the path `/.auth/login/github/callback`. For example, `https://<hostname>.azurecontainerapps.io/.auth/login/github/callback`.
22-
1. On the application page, make note of the **Client ID**, which you'll need later.
22+
1. On the application page, make note of the **Client ID**, which you need later.
2323
1. Under **Client Secrets**, select **Generate a new client secret**.
24-
1. Make note of the client secret value, which you'll need later.
24+
1. Make note of the client secret value, which you need later.
2525

2626
> [!IMPORTANT]
2727
> The client secret is an important security credential. Do not share this secret with anyone or distribute it with your app.
@@ -32,15 +32,15 @@ To complete the procedure in this article, you need a GitHub account. To create
3232
1. Select **Authentication** in the menu on the left. Select **Add identity provider**.
3333
1. Select **GitHub** in the identity provider dropdown. Paste in the `Client ID` and `Client secret` values that you obtained previously.
3434

35-
The secret will be stored as a secret in your container app.
35+
The secret is stored as a secret in your container app.
3636

37-
1. If you're configuring the first identity provider for this application, you'll also be prompted with a **Container Apps authentication settings** section. Otherwise, you may move on to the next step.
37+
1. If you're configuring the first identity provider for this application, you also see a **Container Apps authentication settings** section. Otherwise, you can move on to the next step.
3838

3939
These options determine how your application responds to unauthenticated requests. The default selections redirect all requests to sign in with this new provider. You can change customize this behavior now or adjust these settings later from the main **Authentication** screen by choosing **Edit** next to **Authentication settings**. To learn more about these options, see [Authentication flow](./authentication.md#authentication-flow).
4040

4141
1. Select **Add**.
4242

43-
You're now ready to use GitHub for authentication in your app. The provider will be listed on the **Authentication** screen. From there, you can edit or delete this provider configuration.
43+
You're now ready to use GitHub for authentication in your app. The provider is listed on the **Authentication** screen. From there, you can edit or delete this provider configuration.
4444

4545
## Working with authenticated users
4646

0 commit comments

Comments
 (0)