Skip to content

Commit ae1ec99

Browse files
committed
Fixed review issues
1 parent ccffa89 commit ae1ec99

5 files changed

+17
-17
lines changed

articles/data-factory/concepts-pipeline-execution-triggers.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ Triggers are another way that you can execute a pipeline run. Triggers represent
159159

160160
- Event-based trigger: A trigger that responds to an event.
161161

162-
Pipelines and triggers have a many-to-many relationship (except for the tumbling window trigger).Multiple triggers can kick off a single pipeline, or a single trigger can kick off multiple pipelines. In the following trigger definition, the **pipelines** property refers to a list of pipelines that are triggered by the particular trigger. The property definition includes values for the pipeline parameters.
162+
Pipelines and triggers have a many-to-many relationship (except for the tumbling window trigger). Multiple triggers can kick off a single pipeline, or a single trigger can kick off multiple pipelines. In the following trigger definition, the **pipelines** property refers to a list of pipelines that are triggered by the particular trigger. The property definition includes values for the pipeline parameters.
163163
### Basic trigger definition
164164

165165
```json
@@ -393,10 +393,10 @@ The following table provides a comparison of the tumbling window trigger and sch
393393

394394
## Event-based trigger
395395

396-
An event-based trigger runs pipelines in response to an event. There are two flavors of event based triggers.
396+
An event-based trigger runs pipelines in response to an event. There are two flavors of event-based triggers.
397397

398398
* _Storage event trigger_ runs a pipeline against events happening in a Storage account, such as the arrival of a file, or the deletion of a file in Azure Blob Storage account.
399-
* _Custom event trigger_ processes and handles [custom topics](../event-grid/custom-topics.md) in Event Grid
399+
* _Custom event trigger_ processes and handles [custom articles](../event-grid/custom-topics.md) in Event Grid
400400

401401
For more information about event-based triggers, see [Storage Event Trigger](how-to-create-event-trigger.md) and [Custom Event Trigger](how-to-create-custom-event-trigger.md).
402402

articles/data-factory/control-flow-system-variables.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ These system variables can be referenced anywhere in the trigger JSON for trigge
8080
8181
| Variable Name | Description
8282
| --- | --- |
83-
| @triggerBody().event.eventType | Type of events that triggered the Custom Event Trigger run. Event type is customer defined field and take on any values of string type. |
83+
| @triggerBody().event.eventType | Type of events that triggered the Custom Event Trigger run. Event type is customer-defined field and take on any values of string type. |
8484
| @triggerBody().event.subject | Subject of the custom event that caused the trigger to fire. |
8585
| @triggerBody().event.data._keyName_ | Data field in custom event is a free from JSON blob, which customer can use to send messages and data. Please use data._keyName_ to reference each field. For example, @triggerBody().event.data.callback returns the value for the _callback_ field stored under _data_. |
8686
| @trigger().startTime | Time at which the trigger fired to invoke the pipeline run. |

articles/data-factory/how-to-create-custom-event-trigger.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,9 @@ As of today custom event trigger supports a __subset__ of [advanced filtering op
110110
* StringIn
111111
* StringNotIn
112112

113-
Click **+New** to add new filter conditions.
113+
Select **+New** to add new filter conditions.
114114

115-
Additionally, custom event triggers obey the [same limitations as event grid](../event-grid/event-filtering.md#limitations), including:
115+
Additionally, custom event triggers obey the [same limitations as Event Grid](../event-grid/event-filtering.md#limitations), including:
116116

117117
* 5 advanced filters and 25 filter values across all the filters per custom event trigger
118118
* 512 characters per string value
@@ -128,7 +128,7 @@ The following table provides an overview of the schema elements that are related
128128

129129
| JSON element | Description | Type | Allowed values | Required |
130130
|---|----------------------------|---|---|---|
131-
| `scope` | The Azure Resource Manager resource ID of the event grid topic. | String | Azure Resource Manager ID | Yes |
131+
| `scope` | The Azure Resource Manager resource ID of the Event Grid topic. | String | Azure Resource Manager ID | Yes |
132132
| `events` | The type of events that cause this trigger to fire. | Array of strings | | Yes, at least one value is expected. |
133133
| `subjectBeginsWith` | The `subject` field must begin with the provided pattern for the trigger to fire. For example, _factories_ only fire the trigger for event subjects that start with *factories*. | String | | No |
134134
| `subjectEndsWith` | The `subject` field must end with the provided pattern for the trigger to fire. | String | | No |
@@ -143,7 +143,7 @@ Azure Data Factory uses Azure role-based access control (RBAC) to prohibit unaut
143143

144144
To successfully create or update a custom event trigger, you need to sign in to Data Factory with an Azure account that has appropriate access. Otherwise, the operation will fail with an _Access Denied_ error.
145145

146-
Data Factory doesn't require special permission to your Event Grid. You also do *not* need to assign special Azure RBAC permission to the Data Factory service principal for the operation.
146+
Data Factory doesn't require special permission to your Event Grid. You also do *not* need to assign special Azure RBAC role permission to the Data Factory service principal for the operation.
147147

148148
Specifically, you need `Microsoft.EventGrid/EventSubscriptions/Write` permission on `/subscriptions/####/resourceGroups//####/providers/Microsoft.EventGrid/topics/someTopics`.
149149

articles/data-factory/how-to-create-schedule-trigger.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ This section shows you how to use Azure CLI to create, start, and monitor a sche
206206

207207
### Sample Code
208208

209-
1. In your working direactory, create a JSON file named **MyTrigger.json** with the trigger's properties. For this example use the following content:
209+
1. In your working directory, create a JSON file named **MyTrigger.json** with the trigger's properties. For this example use the following content:
210210

211211
> [!IMPORTANT]
212212
> Before you save the JSON file, set the value of the **startTime** element to the current UTC time. Set the value of the **endTime** element to one hour past the current UTC time.
@@ -252,31 +252,31 @@ This section shows you how to use Azure CLI to create, start, and monitor a sche
252252
- The trigger is associated with the **Adfv2QuickStartPipeline** pipeline. To associate multiple pipelines with a trigger, add more **pipelineReference** sections.
253253
- The pipeline in the Quickstart takes two **parameters** values: **inputPath** and **outputPath**. And you pass values for these parameters from the trigger.
254254

255-
1. Create a trigger by using the [az datafactory trigger create](/cli/azure/datafactory/trigger#az_datafactory_trigger_create) command:
255+
1. Create a trigger by using the [az data factory trigger create](/cli/azure/datafactory/trigger#az_datafactory_trigger_create) command:
256256

257257
```azurecli
258258
az datafactory trigger create --resource-group "ADFQuickStartRG" --factory-name "ADFTutorialFactory" --name "MyTrigger" --properties @MyTrigger.json
259259
```
260260

261-
1. Confirm that the status of the trigger is **Stopped** by using the [az datafactory trigger show](/cli/azure/datafactory/trigger#az_datafactory_trigger_show) command:
261+
1. Confirm that the status of the trigger is **Stopped** by using the [az data factory trigger show](/cli/azure/datafactory/trigger#az_datafactory_trigger_show) command:
262262

263263
```azurecli
264264
az datafactory trigger show --resource-group "ADFQuickStartRG" --factory-name "ADFTutorialFactory" --name "MyTrigger"
265265
```
266266

267-
1. Start the trigger by using the [az datafactory trigger start](/cli/azure/datafactory/trigger#az_datafactory_trigger_start) command:
267+
1. Start the trigger by using the [az data factory trigger start](/cli/azure/datafactory/trigger#az_datafactory_trigger_start) command:
268268

269269
```azurecli
270270
az datafactory trigger start --resource-group "ADFQuickStartRG" --factory-name "ADFTutorialFactory" --name "MyTrigger"
271271
```
272272

273-
1. Confirm that the status of the trigger is **Started** by using the [az datafactory trigger show](/cli/azure/datafactory/trigger#az_datafactory_trigger_show) command:
273+
1. Confirm that the status of the trigger is **Started** by using the [az data factory trigger show](/cli/azure/datafactory/trigger#az_datafactory_trigger_show) command:
274274

275275
```azurecli
276276
az datafactory trigger show --resource-group "ADFQuickStartRG" --factory-name "ADFTutorialFactory" --name "MyTrigger"
277277
```
278278

279-
1. Get the trigger runs in Azure CLI by using the [az datafactory trigger-run query-by-factory](/cli/azure/datafactory/trigger-run#az_datafactory_trigger_run_query_by_factory) command. To get information about the trigger runs, execute the following command periodically. Update the **last-updated-after** and **last-updated-before** values to match the values in your trigger definition:
279+
1. Get the trigger runs in Azure CLI by using the [az data factory trigger-run query-by-factory](/cli/azure/datafactory/trigger-run#az_datafactory_trigger_run_query_by_factory) command. To get information about the trigger runs, execute the following command periodically. Update the **last-updated-after** and **last-updated-before** values to match the values in your trigger definition:
280280

281281
```azurecli
282282
az datafactory trigger-run query-by-factory --resource-group "ADFQuickStartRG" --factory-name "ADFTutorialFactory" --filters operand="TriggerName" operator="Equals" values="MyTrigger" --last-updated-after "2017-12-08T00:00:00" --last-updated-before "2017-12-08T01:00:00"
@@ -472,7 +472,7 @@ The following table provides a high-level overview of the major schema elements
472472
|:--- |:--- |
473473
| **startTime** | A Date-Time value. For simple schedules, the value of the **startTime** property applies to the first occurrence. For complex schedules, the trigger starts no sooner than the specified **startTime** value. <br> For UTC time zone, format is `'yyyy-MM-ddTHH:mm:ssZ'`, for other time zone, format is `'yyyy-MM-ddTHH:mm:ss'`. |
474474
| **endTime** | The end date and time for the trigger. The trigger doesn't execute after the specified end date and time. The value for the property can't be in the past. This property is optional. <br> For UTC time zone, format is `'yyyy-MM-ddTHH:mm:ssZ'`, for other time zone, format is `'yyyy-MM-ddTHH:mm:ss'`. |
475-
| **timeZone** | The time zone the trigger is created in. This setting impact **startTime**, **endTime**, and **schedule**. See [list of supported time zone](#time-zone-option) |
475+
| **timeZone** | The time zone the trigger is created in. This setting affects **startTime**, **endTime**, and **schedule**. See [list of supported time zone](#time-zone-option) |
476476
| **recurrence** | A recurrence object that specifies the recurrence rules for the trigger. The recurrence object supports the **frequency**, **interval**, **endTime**, **count**, and **schedule** elements. When a recurrence object is defined, the **frequency** element is required. The other elements of the recurrence object are optional. |
477477
| **frequency** | The unit of frequency at which the trigger recurs. The supported values include "minute," "hour," "day," "week," and "month." |
478478
| **interval** | A positive integer that denotes the interval for the **frequency** value, which determines how often the trigger runs. For example, if the **interval** is 3 and the **frequency** is "week," the trigger recurs every 3 weeks. |

articles/data-factory/how-to-use-trigger-parameterization.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ This section shows you how to pass meta data information from trigger to pipelin
2929

3030
1. Go to the **Authoring Canvas** and edit a pipeline
3131

32-
1. Click on the blank canvas to bring up pipeline settings. Do not select any activity. You may need to pull up the setting panel from the bottom of the canvas, as it may have been collapsed
32+
1. Select on the blank canvas to bring up pipeline settings. Don’t select any activity. You may need to pull up the setting panel from the bottom of the canvas, as it may have been collapsed
3333

3434
1. Select **Parameters** section and select **+ New** to add parameters
3535

3636
:::image type="content" source="media/how-to-use-trigger-parameterization/01-create-parameter.png" alt-text="Screen shot of pipeline setting showing how to define parameters in pipeline.":::
3737

3838
1. Add triggers to pipeline, by clicking on **+ Trigger**.
3939

40-
1. Create or attach a trigger to the pipeline, and click **OK**
40+
1. Create or attach a trigger to the pipeline, and select **OK**
4141

4242
1. In the following page, fill in trigger meta data for each parameter. Use format defined in [System Variable](control-flow-system-variables.md) to retrieve trigger information. You don't need to fill in the information for all parameters, just the ones that will assume trigger metadata values. For instance, here we assign trigger run start time to *parameter_1*.
4343

0 commit comments

Comments
 (0)