Merge pull request #231080 from garchiro7/main

ACS Calling SDK fixes

Author: v-dirichards

articles/communication-services/concepts/developer-tools/network-diagnostic.md

@@ -21,7 +21,7 @@ The **Network Diagnostics Tool** enables Azure Communication Services developers
 
 As part of the diagnostics performed, the user is asked to enable permissions for the tool to access their devices. Next, the user is asked to record their voice, which is then played back using an echo bot to ensure that the microphone is working. The tool finally, performs a video test. The test uses the camera to detect video and measure the quality for sent and received frames. 
 
-If you are looking to build your own Network Diagnostic Tool or to perform deeper integration of this tool into your application, you can leverage [pre-call diagnostic APIs](../voice-video-calling/pre-call-diagnostics.md) for the calling SDK. 
+If you're looking to build your own Network Diagnostic Tool or to perform deeper integration of this tool into your application, you can leverage [pre-call diagnostic APIs](../voice-video-calling/pre-call-diagnostics.md) for the calling SDK. 
 
 ## Performed tests
 
@@ -36,11 +36,13 @@ If you are looking to build your own Network Diagnostic Tool or to perform deepe
 
 ## Privacy
 
-When a user runs a network diagnostic, the tool collects and store service and client telemetry data to verify your network conditions and ensure that they're compatible with Azure Communication Services. The telemetry collected doesn't contain personal identifiable information. The test utilizes both audio and video collected through your device for this verification. The audio and video used for the test aren't stored.
+When a user runs a network diagnostic, the tool collects and store service and client telemetry data to verify your network conditions and ensure that they're compatible with Azure Communication Services.
+
+The telemetry collected doesn't contain personal identifiable information. The test utilizes both audio and video collected through your device for this verification. The audio and video used for the test aren't stored.
 
 ## Support
 
-The test provides a **unique identifier** for your test which you can provide our support team who can provide further help. For more information see [help and support options](../../support.md)
+The test provides a **unique identifier** for your test, which you can provide our support team who can provide further help. For more information, see [help and support options](../../support.md)
 
 ## Next Steps
 

articles/communication-services/concepts/router/classification-concepts.md

@@ -18,7 +18,7 @@ ms.service: azure-communication-services
 
 When you submit a job to Job Router, you can either specify the queue, priority, and worker selectors manually or you can specify a classification policy to drive these values.
 
-If you choose to use a classification policy, you will receive a [JobClassified Event][job_classified_event] or a [JobClassificationFailed Event][job_classify_failed_event] with the result.  Once the job has been successfully classified, it will be automatically queued.  If the classification process fails, you'll need to intervene to fix it.
+If you choose to use a classification policy, you receive a [JobClassified Event][job_classified_event] or a [JobClassificationFailed Event][job_classify_failed_event] with the result.  Once the job has been successfully classified, it's automatically queued.  If the classification process fails, you need to intervene to fix it.
 
 The process of classifying a Job involves optionally setting the following properties:
 
@@ -30,41 +30,41 @@ The process of classifying a Job involves optionally setting the following prope
 
 The priority of a Job can be resolved during classification using one of many rule engines.
 
-See the [Rule concepts](router-rule-concepts.md) page for more information.
+For more information, see the [Rule concepts](router-rule-concepts.md) page.
 
 ## Worker selectors
 
-Each job carries a collection of worker selectors, that are evaluated against the worker labels.  These are conditions that need to be true of a worker to be a match.
-You can use the classification policy to attach these conditions to a job.  You can do this by specifying one or more selector attachments.
+Each job carries a collection of worker selectors that's evaluated against the worker labels. These conditions need to be true of a worker to be a match.
+You can use the classification policy to attach these conditions to a job; you can do it by specifying one or more selector attachments.
 
-For more information see the section [below](#using-label-selector-attachments).
+For more information, see, the section: [using label selector attachments](#using-label-selector-attachments).
 
 ## Queue selectors
 
 You can also specify a collection of label selector attachments to select the Queue based on its labels.
 
-For more information see the section [below](#using-label-selector-attachments).
+For more information, see, the section: [using label selector attachments](#using-label-selector-attachments).
 
 ## Using label selector attachments
 
 The following label selector attachments are available:
 
 **Static label selector -** Always attaches the given `LabelSelector` to the Job.
 
-**Conditional label selector -** Evaluates a condition defined by a [rule](router-rule-concepts.md).  If it resolves to `true`, then the specified collection of selectors will be attached to the Job.
+**Conditional label selector -** Evaluates a condition defined by a [rule](router-rule-concepts.md).  If it resolves to `true`, then the specified collection of selectors are attached to the Job.
 
 **Passthrough label selector -** Attaches a selector to the Job with the specified key and operator but gets the value from the Job label of the same key.
 
-**Rule label selector -** Sources a collection of selectors from one of many rule engines. Read the [RouterRule concepts](router-rule-concepts.md) page for more information.
+**Rule label selector -** Sources a collection of selectors from one of many rule engines. Read the [RouterRule concepts](router-rule-concepts.md) page, for more information.
 
 **Weighted allocation label selector -** Enables you to specify a percentage-based weighting and a collection of selectors to attach based on the weighting allocation. For example, you may want 30% of the Jobs to go to "Vendor 1" and 70% of Jobs to go to "Vendor 2".
 
 ## Reclassifying a job
 
 Once a Job has been classified, it can be reclassified in the following ways:
 
-1. You can update the Job labels, which will cause the Job Router to evaluate the new labels with the previous Classification Policy.
-2. You can update the Classification Policy ID of a Job, which will cause Job Router to process the existing Job against the new policy.
+1. You can update the Job labels, which cause the Job Router to evaluate the new labels with the previous Classification Policy.
+2. You can update the Classification Policy ID of a Job, which causes Job Router to process the existing Job against the new policy.
 3. An Exception Policy **trigger** can take the **action** of requesting a Job be reclassified.
 
 > [!NOTE]

articles/communication-services/concepts/ui-library/includes/mobile-ui-use-cases.md

@@ -101,7 +101,7 @@ The `ChatComposite` was designed to fit into different layouts and views in your
 
 ## Supported identities
 
-To initialize a composite and authenticate to the service, a user must have an Azure Communication Services identity. For more information, see [Authenticate to Azure Communication Services](../../authentication.md) and [Quickstart: Create and manage access tokens](../../../quickstarts/identity/access-tokens.md).
+To initialize a composite, and authenticate to the service, a user must have an Azure Communication Services identity. For more information, see [Authenticate to Azure Communication Services](../../authentication.md) and [Quickstart: Create and manage access tokens](../../../quickstarts/identity/access-tokens.md).
 
 ## Recommended architecture
 
@@ -129,7 +129,7 @@ Call and chat client libraries must have the context for the call they join. Lik
 
 When troubleshooting happens for voice or video calls, you may be asked to provide a **CallID**; this ID is used to identify Communication Services calls.
 
-This CallID can be retrieved via the action bar on the bottom of the call screen; you'll see an ellipsis button; once the user performs the tap action an option of ***"Share diagnostics info"***; the user will have the capability to share **the diagnostics info** that will be required to track  any issues by the support team.
+This CallID can be retrieved via the action bar on the bottom of the call screen; you see an ellipsis button; once the user performs the tap action an option of ***"Share diagnostics info"***; the user can share **the diagnostics info** that's required to track any issues by the support team.
 
 For programmatic access to **CallID**, see ["How to get debug information programmatically"](../../../how-tos/ui-library-sdk/troubleshooting.md).
 

articles/communication-services/concepts/ui-library/includes/web-ui-library.md

@@ -37,20 +37,20 @@ Developers can easily instantiate the Composite using an Azure Communication Ser
 
 | Composite    | Use Cases  | 
 | ------------ | ---------- |
-| [CallwithChatComposite](https://azure.github.io/communication-ui-library/?path=/docs/composites-call-with-chat-basicexample--basic-example) | Experience combining calling and chat features to allow users to start or join a call and chat thread. In the experience the user has the ability to both communicate using voice and video, as well as access to a rich chat thread where messages can be exchanged between participants. It includes support for Teams Interop. |
-| [CallComposite](https://azure.github.io/communication-ui-library/?path=/docs/composites-call-basicexample--basic-example) | Calling experience that allows users to start or join a call. Inside the experience users can configure their devices, participate in the call with video, and see other participants, including those participants with video turn on. For Teams Interop is includes lobby functionality for user to wait to be admitted. |
+| [CallwithChatComposite](https://azure.github.io/communication-ui-library/?path=/docs/composites-call-with-chat-basicexample--basic-example) | Experience combining calling and chat features to allow users to start or join a call and chat thread. In the experience, the user has the ability to both communicate using voice and video, and access to a rich chat thread where messages can be exchanged between participants. It includes support for Teams Interop. |
+| [CallComposite](https://azure.github.io/communication-ui-library/?path=/docs/composites-call-basicexample--basic-example) | Calling experience that allows users to start or join a call. Inside the experience users can configure their devices, participate in the call with video, and see other participants, including those participants with video turn-on. For Teams Interop, is included lobby functionality for user to wait to be admitted. |
 | [ChatComposite](https://azure.github.io/communication-ui-library/?path=/docs/composites-chat-basicexample--basic-example)    | Chat experience where user can send and receive messages. Thread events like typing, reads, participants entering and leaving are displayed to the user as part of the chat thread.                                                                                                                          |
 ## UI Component overview
 
-Pure UI Components that can be used by developers to compose communication experiences, from stitching video tiles into a grid to showcase remote participants, to organizing components to fit your applications specifications.
+Pure UI Components can be used for the developers, to compose communication experiences, from stitching video tiles into a grid to showcase remote participants, to organizing components to fit your applications specifications.
 UI Components support customization to give the components the right feel and look to match an applications branding and style.
 
 | Area    | Component    | Description       |
 | ------- | ------------ | ----------------- |
 | Calling | [Grid Layout](https://azure.github.io/communication-ui-library/?path=/story/ui-components-gridlayout--grid-layout)                | Grid component to organize Video Tiles into an NxN grid                                            |
 |         | [Video Tile](https://azure.github.io/communication-ui-library/?path=/story/ui-components-videotile--video-tile)                   | Component that displays video stream when available and a default static component when not        |
 |         | [Control Bar](https://azure.github.io/communication-ui-library/?path=/story/ui-components-controlbar--control-bar)                | Container to organize DefaultButtons to hook up to specific call actions like mute or share screen |
-|         | [VideoGallery](https://azure.github.io/communication-ui-library/?path=/story/ui-components-video-gallery--video-gallery)                                           | Turn-key video gallery component which dynamically changes as participants are added               |
+|         | [VideoGallery](https://azure.github.io/communication-ui-library/?path=/story/ui-components-video-gallery--video-gallery)                                           | Turn-key video gallery component, which dynamically changes as participants are added               |
 |         | [Dialpad](https://azure.github.io/communication-ui-library/?path=/docs/ui-components-dialpad--dialpad) | Component to support phone number input and DTMF tones. |
 | Chat    | [Message Thread](https://azure.github.io/communication-ui-library/?path=/story/ui-components-messagethread--message-thread)       | Container that renders chat messages, system messages, and custom messages                          |
 |         | [Send Box](https://azure.github.io/communication-ui-library/?path=/story/ui-components-sendbox--send-box)                         | Text input component with a discrete send button                                                   |
@@ -61,20 +61,20 @@ UI Components support customization to give the components the right feel and lo
 
 ## Installing Web UI Library
 
-Stateful clients are found as part of the `@azure/communication-react` package. 
+Stateful clients are found as part of the `@azure/communication-react` package.
 
 ```bash
 npm i --save @azure/communication-react
 ```
 
 ## What UI artifact is best for my project?
 
-Understanding these requirements will help you choose the right client library:
+Understanding these requirements help you choose the right client library:
 
 - **How much customization do you desire?** Azure Communication core client libraries don't have a UX and are designed so you can build whatever UX you want. UI Library components provide UI assets at the cost of reduced customization.
 - **What platforms are you targeting?** Different platforms have different capabilities.
 
-Details about feature availability in the [UI Library is available here](https://azure.github.io/communication-ui-library/?path=/story/use-cases--page), but key trade-offs are summarized below.
+Details about feature availability in the [UI Library is available here](https://azure.github.io/communication-ui-library/?path=/story/use-cases--page), but key trade-offs are summarized in the next table.
 
 | Client library / SDK  | Implementation Complexity | Customization Ability | Calling | Chat | [Teams Interop](../../teams-interop.md) |
 | --------------------- | ------------------------- | --------------------- | ------- | ---- | ----------------------------------------------------------------------------------------------------- |

articles/communication-services/concepts/ui-library/includes/web-ui-use-cases.md

@@ -53,7 +53,8 @@ Get more conceptual documentation, quickstarts, and examples in the [UI Library
 
 ## Supported identities
 
-To initialize a composite and authenticate to the service, a user must have an Azure Communication Services identity. For more information, see [Authenticate to Azure Communication Services](../../authentication.md) and [Quickstart: Create and manage access tokens](../../../quickstarts/identity/access-tokens.md).
+To initialize a composite, and authenticate to the service, a user must have an Azure Communication Services identity. For more information, see [Authenticate to Azure Communication Services](../../authentication.md) and [Quickstart: Create and manage access tokens](../../../quickstarts/identity/access-tokens.md).
+
 
 ## Teams interoperability
 
@@ -99,7 +100,7 @@ The following table compares composites and UI components for observability use
 
 ## Recommended architecture
 
-Initialize a composite and base components by using an Azure Communication Services access token. It's important to get access tokens from Communication Services through a trusted service that you manage. For more information, see [Quickstart: Create and manage access tokens](../../../quickstarts/identity/access-tokens.md) and the [trusted service tutorial](../../../tutorials/trusted-service-tutorial.md).
+Initialize a composite and base component by using an Azure Communication Services access token. It's important to get access tokens from Communication Services through a trusted service that you manage. For more information, see [Quickstart: Create and manage access tokens](../../../quickstarts/identity/access-tokens.md) and the [trusted service tutorial](../../../tutorials/trusted-service-tutorial.md).
 
 :::image type="content" source="../../media/mobile-ui/ui-library-architecture.png" border="false" alt-text="Diagram that shows the recommended UI Library architecture.":::
 
@@ -122,7 +123,7 @@ The following table summarizes initialization and resource management functions
 
 \* The current version of Chrome and the two preceding releases are supported.
 
-\*\* Safari version 13.1 and later versions are supported. Outgoing video for Safari macOS isn't yet supported, but it is supported for iOS. Outgoing screen sharing is supported only on desktop iOS.
+\*\* Safari version 13.1 and later versions are supported. Outgoing video for Safari macOS isn't yet supported, but it's supported for iOS. Outgoing screen sharing is supported only on desktop iOS.
 
 ## Accessibility