Skip to content

Commit b4ecbe4

Browse files
committed
Incorporate Glenn's comments
1 parent 1cb928a commit b4ecbe4

File tree

1 file changed

+6
-22
lines changed

1 file changed

+6
-22
lines changed

articles/azure-functions/functions-infrastructure-as-code.md

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: Learn how to build a Bicep file or an Azure Resource Manager templa
44

55
ms.assetid: d20743e3-aab6-442c-a836-9bcea09bfd32
66
ms.topic: conceptual
7-
ms.date: 08/22/2022
7+
ms.date: 08/30/2022
88
ms.custom: fasttrack-edit, devx-track-azurepowershell
99
---
1010

@@ -155,9 +155,6 @@ Application Insights is recommended for monitoring your function apps. The Appli
155155
resource applicationInsights 'Microsoft.Insights/components@2020-02-02' = {
156156
name: applicationInsightsName
157157
location: appInsightsLocation
158-
tags: {
159-
'hidden-link:${resourceId('Microsoft.Web/sites', applicationInsightsName)}': 'Resource'
160-
}
161158
kind: 'web'
162159
properties: {
163160
Application_Type: 'web'
@@ -175,9 +172,6 @@ resource applicationInsights 'Microsoft.Insights/components@2020-02-02' = {
175172
"apiVersion": "2020-02-02",
176173
"name": "[parameters('applicationInsightsName')]",
177174
"location": "[parameters('appInsightsLocation')]",
178-
"tags": {
179-
"[format('hidden-link:{0}', resourceId('Microsoft.Web/sites', parameters('applicationInsightsName')))]": "Resource"
180-
},
181175
"kind": "web",
182176
"properties": {
183177
"Application_Type": "web",
@@ -189,8 +183,6 @@ resource applicationInsights 'Microsoft.Insights/components@2020-02-02' = {
189183

190184
---
191185

192-
***jgao: do we need "tags" in the sample?
193-
194186
In addition, the instrumentation key needs to be provided to the function app using the `APPINSIGHTS_INSTRUMENTATIONKEY` application setting. This property is specified in the `appSettings` collection in the `siteConfig` object:
195187

196188
# [Bicep](#tab/bicep)
@@ -307,8 +299,6 @@ resource functionApp 'Microsoft.Web/sites@2022-03-01' = {
307299

308300
---
309301

310-
***jgao: I add some additional properties per the best practices.
311-
312302
> [!IMPORTANT]
313303
> If you're explicitly defining a hosting plan, an additional item would be needed in the dependsOn array: `"[resourceId('Microsoft.Web/serverfarms', parameters('hostingPlanName'))]"`
314304
@@ -454,8 +444,6 @@ resource hostingPlan 'Microsoft.Web/serverfarms@2022-03-01' = {
454444

455445
---
456446

457-
***jgao: properties/name is read-only value now.
458-
459447
#### Linux
460448

461449
To run your app on Linux, you must also set the property `"reserved": true` for the `serverfarms` resource:
@@ -620,7 +608,7 @@ resource functionApp 'Microsoft.Web/sites@2022-03-01' = {
620608
---
621609

622610
> [!IMPORTANT]
623-
> Do not need to set the [`WEBSITE_CONTENTSHARE`](functions-app-settings.md#website_contentshare) setting in a deployment slot. This setting is generated for you when the app is created in the deployment slot.
611+
> Don't set the [`WEBSITE_CONTENTSHARE`](functions-app-settings.md#website_contentshare) setting in a new deployment slot. This setting is generated for you when the app is created in the deployment slot.
624612
625613
#### Linux
626614

@@ -1035,9 +1023,9 @@ In the App Service plan, your function app runs on dedicated VMs on Basic, Stand
10351023

10361024
For a sample Bicep file/Azure Resource Manager template, see [Function app on Azure App Service plan].
10371025

1038-
### Create an App Service plan
1026+
### Create a Dedicated plan
10391027

1040-
An App Service plan is defined by a `serverfarm` resource. You can specify the SKU as follows:
1028+
In Functions, the Dedicated plan is just a regular App Service plan, which is defined by a `serverfarm` resource. You can specify the SKU as follows:
10411029

10421030
#### Windows
10431031

@@ -1491,9 +1479,7 @@ resource hostingPlan 'Microsoft.Web/serverfarms@2022-03-01' = {
14911479

14921480
---
14931481

1494-
***jgao: remove extendedLocation.type because it is readonly.
1495-
1496-
The plan resource should use the Kubernetes (K1) SKU, and its `kind` field should be "linux,kubernetes". Within `properties`, `reserved` should be "true", and `kubeEnvironmentProfile.id` should be set to the App Service Kubernetes environment resource ID. An example plan might look like:
1482+
The plan resource should use the Kubernetes (K1) SKU, and its `kind` field should be `linux,kubernetes`. Within `properties`, `reserved` should be `true`, and `kubeEnvironmentProfile.id` should be set to the App Service Kubernetes environment resource ID. An example plan might look like:
14971483

14981484
# [Bicep](#tab/bicep)
14991485

@@ -1547,9 +1533,7 @@ resource hostingPlan 'Microsoft.Web/serverfarms@2022-03-01' = {
15471533

15481534
---
15491535

1550-
***jgao: removed some of the properties. See azureArc.bicep.
1551-
1552-
The function app resource should have its `kind` field set to **functionapp,linux,kubernetes** or **functionapp,linux,kubernetes,container** depending on if you intend to deploy via code or container. An example function app might look like:
1536+
The function app resource should have its `kind` field set to **functionapp,linux,kubernetes** or **functionapp,linux,kubernetes,container** depending on if you intend to deploy via code or container. An example .NET 6.0 function app might look like:
15531537

15541538
# [Bicep](#tab/bicep)
15551539

0 commit comments

Comments
 (0)