Skip to content

Commit bb3b78f

Browse files
committed
Addressed review comments
1 parent 62b0350 commit bb3b78f

17 files changed

+26
-29
lines changed

articles/app-testing/playwright-workspaces/concept-determine-optimal-configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ In Playwright, you can run tests in parallel by using worker processes. By using
1919

2020
The following chart gives an example of running a test suite. By running the test suite with Playwright Workspaces instead of locally, you can significantly increase the parallelism and reduce the test completion time. Notice that, when running with the service, the completion time reaches a minimum limit, after which adding more workers only has a minimal effect. The chart also shows how using more computing resources on the client machine positively affects the test completion time for tests running with the service.
2121

22-
![Line chart that shows the relation between the number of parallel workers and the test suite completion time for different run environments.](./media/concept-determine-optimal-configuration/playwright-workspaces-parallelization-chart.png)
22+
:::image type="content" source="./media/concept-determine-optimal-configuration/playwright-workspaces-parallelization-chart.png" alt-text="Line chart that shows the relation between the number of parallel workers and the test suite completion time for different run environments." lightbox="./media/concept-determine-optimal-configuration/playwright-workspaces-parallelization-chart.png":::
2323

2424
## Worker processes
2525

articles/app-testing/playwright-workspaces/how-to-manage-access-tokens.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ To enable authentication using access tokens:
4949

5050
1. Check the box for **Playwright Service Access Token** to enable it.
5151

52-
!["Screenshot that shows turning on authentication using access tokens."](media/how-to-manage-authentication/enable-access-token.png)
52+
![Screenshot that shows turning on authentication using access tokens.](media/how-to-manage-authentication/enable-access-token.png)
5353

5454
> [!CAUTION]
5555
> Authentication using access tokens is less secure. [Learn how to manage access tokens](./how-to-manage-access-tokens.md)
@@ -82,7 +82,8 @@ To create a new workspace access token:
8282

8383
1. On the **Access Management** page, select **Generate token**.
8484

85-
![Screenshot that shows the access tokens settings page in the Azure portal, highlighting the 'Generate new token' button.](./media/how-to-manage-access-tokens/playwright-workspaces-generate-new-access-token.png)
85+
:::image type="content" source="./media/how-to-manage-access-tokens/playwright-workspaces-generate-new-access-token.png" alt-text="Screenshot that shows the access tokens settings page in the Azure portal, highlighting the 'Generate new token' button" lightbox="./media/how-to-manage-access-tokens/playwright-workspaces-generate-new-access-token.png":::
86+
8687

8788
1. Enter the access token details, and then select **Generate token**.
8889

articles/app-testing/playwright-workspaces/how-to-manage-authentication.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ To enable authentication using access tokens:
4646

4747
1. Check the box for **Playwright Service Access Token** to enable it.
4848

49-
!["Screenshot that shows turning on authentication using access tokens."](media/how-to-manage-authentication/enable-access-token.png)
49+
:::image type="content" source="./media/how-to-manage-authentication/enable-access-token.png" alt-text="Screenshot that shows turning on authentication using access tokens." lightbox="media/how-to-manage-authentication/enable-access-token.png":::
5050

5151
> [!CAUTION]
5252
> Authentication using access tokens is less secure. [Learn how to manage access tokens](./how-to-manage-access-tokens.md)
@@ -97,13 +97,13 @@ To enable authentication using access tokens:
9797
```
9898
::: zone-end
9999

100-
2. Create access token
100+
2. Create access token.
101101

102102
Follow the steps to [create an access token](./how-to-manage-access-tokens.md#generate-a-workspace-access-token). Copy the value of the access token generated.
103103

104104
::: zone pivot="playwright-test-runner"
105105

106-
3. Set up your environment
106+
3. Set up your environment.
107107

108108
To set up your environment, configure the `PLAYWRIGHT_SERVICE_ACCESS_TOKEN` environment variable with the value you obtained in the previous steps. Ensure this environment variable is available in your setup where you are running tests.
109109

@@ -127,7 +127,7 @@ To enable authentication using access tokens:
127127

128128
::: zone pivot="nunit-test-runner"
129129

130-
3. Set up your environment
130+
3. Set up your environment.
131131

132132
To set up your environment, configure the `PLAYWRIGHT_SERVICE_ACCESS_TOKEN` environment variable with the value you obtained in the previous steps. Ensure this environment variable is available in your setup where you are running tests.
133133

articles/app-testing/playwright-workspaces/how-to-manage-playwright-workspace.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ To connect with cloud browsers, you first need to create a Playwright workspace.
2929
1. Sign in to the [Azure portal](https://portal.azure.com/).
3030
1. Select the menu button in the upper-left corner of the portal, and then select **Create a resource** a resource.
3131

32-
![Screenshot that shows the Azure portal menu to create a new resource.](./media/how-to-manage-playwright-workspace/azure-portal-create-resource.png)
32+
:::image type="content" source="./media/how-to-manage-playwright-workspace/azure-portal-create-resource.png" alt-text="Screenshot that shows the Azure portal menu to create a new resource." lightbox="./media/how-to-manage-playwright-workspace/azure-portal-create-resource.png":::
3333

3434
1. Enter *Playwright Workspaces* in the search box.
3535
1. Select the **Playwright Workspaces** card, and then select **Create**.
3636

37-
![Screenshot that shows the Azure Marketplace search page with the Playwright Workspaces search result.](./media/how-to-manage-playwright-workspace/azure-portal-search-playwright-resource.png)
37+
:::image type="content" source="./media/how-to-manage-playwright-workspace/azure-portal-search-playwright-resource.png" alt-text="Screenshot that shows the Azure Marketplace search page with the Playwright Workspaces search result." lightbox="./media/how-to-manage-playwright-workspace/azure-portal-search-playwright-resource.png":::
3838

3939
1. Provide the following information to configure a new Playwright workspace:
4040

@@ -56,7 +56,7 @@ To connect with cloud browsers, you first need to create a Playwright workspace.
5656

5757
1. To view the new workspace, select **Go to resource**.
5858

59-
![Screenshot that shows the deployment completion information in the Azure portal](./media/how-to-manage-playwright-workspace/create-resource-deployment-complete.png)
59+
:::image type="content" source="./media/how-to-manage-playwright-workspace/create-resource-deployment-complete.png" alt-text="Screenshot that shows the deployment completion information in the Azure portal." lightbox="./media/how-to-manage-playwright-workspace/create-resource-deployment-complete.png":::
6060

6161
## Display a list of workspaces
6262

@@ -68,7 +68,8 @@ To get the list of Playwright workspaces that you have access to:
6868

6969
1. Select **Playwright Workspaces** from the **Services** section to view all your workspaces.
7070

71-
![Screenshot that shows the search box in the Azure portal, to search for Playwright Workspaces resources.](./media/how-to-manage-playwright-workspace/azure-portal-search-playwright-workspaces.png)
71+
:::image type="content" source="./media/how-to-manage-playwright-workspace/azure-portal-search-playwright-workspaces.png" alt-text="Screenshot that shows the search box in the Azure portal, to search for Playwright Workspaces resources." lightbox="./media/how-to-manage-playwright-workspace/azure-portal-search-playwright-workspaces.png":::
72+
7273

7374
1. Look through the list of workspaces found. You can filter based on subscription, resource groups, and locations.
7475

articles/app-testing/playwright-workspaces/how-to-optimize-regional-latency.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ You can configure the regional settings for your workspace in the Azure portal.
3434

3535
By default, the service uses remote browsers in the Azure region that's closest to the client machine to minimize latency.
3636

37-
![Screenshot of the Region Management settings page](./media/how-to-optimize-regional-latency/configure-workspace-region-management.png )
37+
![Screenshot of the Region Management settings page.](./media/how-to-optimize-regional-latency/configure-workspace-region-management.png )
3838

3939
## Related content
4040

articles/app-testing/playwright-workspaces/how-to-try-playwright-workspaces-free.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ To get started with running your Playwright tests on cloud browsers, you first n
7676

7777
1. To view the new workspace, select **Go to resource**.
7878

79-
![Screenshot that shows the deployment completion information in the Azure portal](./media/how-to-manage-playwright-workspace/create-resource-deployment-complete.png)
79+
![Screenshot that shows the deployment completion information in the Azure portal.](./media/how-to-manage-playwright-workspace/create-resource-deployment-complete.png)
8080

8181
## Upgrade your workspace
8282

Loading
Loading
Loading

0 commit comments

Comments
 (0)