Skip to content

Commit bf041d5

Browse files
committed
Fix reviewer comments
1 parent da2605d commit bf041d5

17 files changed

+249
-248
lines changed

articles/azure-web-pubsub/concept-service-internals.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ The event listener listens to the incoming client events. Each event listener co
259259
260260
Currently we support [**Event Hubs**](https://azure.microsoft.com/products/event-hubs/) as an event listener endpoint.
261261
262-
You need to register event listeners beforehand, so that when a client event is triggered, the service can push the event to the corresponding event listeners. See [this doc](./howto-develop-eventlistener.md#configure-an-event-listener) for how to configure an event listener with an event hub endpoint.
262+
You need to register event listeners beforehand, so that when a client event is triggered, the service can push the event to the corresponding event listeners. See [this doc](./howto-develop-event-listener.md#configure-an-event-listener) for how to configure an event listener with an event hub endpoint.
263263
264264
You can configure multiple event listeners. The order of the event listeners doesn't matter. If an event matches with multiple event listeners, it will be sent to all the listeners it matches. See the following diagram for an example. Let's say you configure four event listeners at the same time. Then a client event that matches with three of those listeners will be sent to three listeners, leaving the rest one untouched.
265265

articles/azure-web-pubsub/howto-develop-eventlistener.md renamed to articles/azure-web-pubsub/howto-develop-event-listener.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,33 +40,33 @@ Find your Azure Web PubSub service from **Azure portal**. Navigate to **Identity
4040
1. Find your Azure Event Hubs resource in **Azure portal**. You could choose to grant the role in the Event Hubs namespace level or entity level. The following steps choose the namespace level.
4141

4242
1. Navigate to **Access Control**. Select **Add role assignment**.
43-
:::image type="content" source="media/howto-develop-eventlistener/event-hub-access-control.png" alt-text="Screenshot of granting access to Event Hubs namespace":::
43+
:::image type="content" source="media/howto-develop-event-listener/event-hub-access-control.png" alt-text="Screenshot of granting access to Event Hubs namespace":::
4444

4545
1. Select **Azure Event Hubs Data Sender** role in the **Role** tab. Then select **Next**.
46-
:::image type="content" source="media/howto-develop-eventlistener/event-hub-data-sender-role.png" alt-text="Screenshot of selecting Azure EventHubs Data Sender role":::
46+
:::image type="content" source="media/howto-develop-event-listener/event-hub-data-sender-role.png" alt-text="Screenshot of selecting Azure EventHubs Data Sender role":::
4747

4848
1. In the **Members** tab, choose to assign access to **Managed identity**. Select **Select members** to select your Web PubSub service. Then you can **Review + assign** your role assignment.
49-
:::image type="content" source="media/howto-develop-eventlistener/event-hub-select-identity.png" alt-text="Screenshot of selecting your Web PubSub service identity":::
49+
:::image type="content" source="media/howto-develop-event-listener/event-hub-select-identity.png" alt-text="Screenshot of selecting your Web PubSub service identity":::
5050

5151
### Add an event listener rule to your service settings
5252

5353
1. Find your service from **Azure portal**. Navigate to **Settings**. Then select **Add** to configure your event listener. For an existing hub configuration, select **...** on right side will navigate to the same editing page.
54-
:::image type="content" source="media/howto-develop-eventlistener/web-pubsub-settings.png" alt-text="Screenshot of Web PubSub settings":::
54+
:::image type="content" source="media/howto-develop-event-listener/web-pubsub-settings.png" alt-text="Screenshot of Web PubSub settings":::
5555

5656
1. Then in the below editing page, you'd need to configure hub name, and select **Add** to add an event listener.
57-
:::image type="content" source="media/howto-develop-eventlistener/configure-hub-settings.png" alt-text="Screenshot of configuring hub settings":::
57+
:::image type="content" source="media/howto-develop-event-listener/configure-hub-settings.png" alt-text="Screenshot of configuring hub settings":::
5858

5959
1. On the **Configure Event Listener** page, first configure an event hub endpoint. You can select **Select Event Hub from your subscription** to select, or directly input the fully qualified namespace and the event hub name. Then select `user` and `system` events you'd like to listen to. Finally select **Confirm** when everything is done.
60-
:::image type="content" source="media/howto-develop-eventlistener/configure-event-hub-listener.png" alt-text="Screenshot of configuring Event Hubs Listener":::
60+
:::image type="content" source="media/howto-develop-event-listener/configure-event-hub-listener.png" alt-text="Screenshot of configuring Event Hubs Listener":::
6161

6262

6363
## Test your configuration with live demo
6464

6565
1. Open this [Event Hubs Consumer Client](https://awpseventlistenerdemo.blob.core.windows.net/eventhub-consumer/index.html) web app, input the Event Hubs connection string to connect to an event hub as a consumer. If you get the Event Hubs connection string from an Event Hubs namespace resource instead of an event hub instance, then you need to specify the event hub name. This event hub consumer client is connected with the mode that only reads new events; the events published before aren't seen here. You can change the consumer client connection mode to read all the available events in the production environment.
6666

6767
1. Use this [WebSocket Client](https://awpseventlistenerdemo.blob.core.windows.net/webpubsub-client/websocket-client.html) web app to generate client events. If you've configured to send system event `connected` to that event hub, you should be able to see a printed `connected` event in the Event Hubs consumer client after connecting to Web PubSub service successfully. You can also generate a user event with the app.
68-
:::image type="content" source="media/howto-develop-eventlistener/eventhub-consumer-connected-event.png" alt-text="Screenshot of a printed connected event in the Event Hubs consumer client app":::
69-
:::image type="content" source="media/howto-develop-eventlistener/web-pubsub-client-specify-event-name.png" alt-text="The area of the WebSocket client app to generate a user event":::
68+
:::image type="content" source="media/howto-develop-event-listener/eventhub-consumer-connected-event.png" alt-text="Screenshot of a printed connected event in the Event Hubs consumer client app":::
69+
:::image type="content" source="media/howto-develop-event-listener/web-pubsub-client-specify-event-name.png" alt-text="The area of the WebSocket client app to generate a user event":::
7070

7171
## Next steps
7272

articles/azure-web-pubsub/includes/include-next-step.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Follow the tutorials listed below to start building your own application.
2121
> [Tutorial: Build serverless chat with Azure Functions and Web PubSub](./../quickstart-serverless.md)
2222
2323
> [!div class="nextstepaction"]
24-
> [Tutorial: How to configure event listener](./../howto-develop-eventlistener.md)
24+
> [Tutorial: How to configure event listener](./../howto-develop-event-listener.md)
2525
2626
> [!div class="nextstepaction"]
2727
> [Play with Live Demos](https://aka.ms/awps/livedemos)

0 commit comments

Comments
 (0)