Merge pull request #225048 from roygara/otherFixes

Snapshot fixes

Author: Court72

articles/virtual-machines/disks-incremental-snapshots.md

@@ -40,6 +40,9 @@ yourDiskID=$(az disk show -n $diskName -g $resourceGroupName --query "id" --outp
 az snapshot create -g $resourceGroupName -n $snapshotName --source $yourDiskID --incremental true
 ```
 
+> [!IMPORTANT]
+> After taking a snapshot of an Ultra Disk, you must wait for the snapshot to complete before you can use it. See the [Check status of snapshots or disks](#check-status-of-snapshots-or-disks) section for details.
+
 You can identify incremental snapshots from the same disk with the `SourceResourceId` property of snapshots. `SourceResourceId` is the Azure Resource Manager resource ID of the parent disk.
 
 You can use `SourceResourceId` to create a list of all snapshots associated with a particular disk. Replace `yourResourceGroupNameHere` with your value and then you can use the following example to list your existing incremental snapshots:
@@ -83,6 +86,9 @@ $snapshotConfig=New-AzSnapshotConfig -SourceUri $yourDisk.Id -Location $yourDisk
 New-AzSnapshot -ResourceGroupName $resourceGroupName -SnapshotName $snapshotName -Snapshot $snapshotConfig 
 ```
 
+> [!IMPORTANT]
+> After taking a snapshot of an Ultra Disk, you must wait for the snapshot to complete before you can use it.  See the [Check status of snapshots or disks](#check-status-of-snapshots-or-disks) section for details.
+
 You can identify incremental snapshots from the same disk with the `SourceResourceId` and the `SourceUniqueId` properties of snapshots. `SourceResourceId` is the Azure Resource Manager resource ID of the parent disk. `SourceUniqueId` is the value inherited from the `UniqueId` property of the disk. If you delete a disk and then create a new disk with the same name, the value of the `UniqueId` property changes.
 
 You can use `SourceResourceId` and `SourceUniqueId` to create a list of all snapshots associated with a particular disk. Replace `yourResourceGroupNameHere` with your value and then you can use the following example to list your existing incremental snapshots:
@@ -107,9 +113,12 @@ $incrementalSnapshots
 # [Portal](#tab/azure-portal)
 [!INCLUDE [virtual-machines-disks-incremental-snapshots-portal](../../includes/virtual-machines-disks-incremental-snapshots-portal.md)]
 
+> [!IMPORTANT]
+> After taking a snapshot of an Ultra Disk, you must wait for the snapshot to complete before you can use it.  See the [Check status of snapshots or disks](#check-status-of-snapshots-or-disks) section for details.
+
 # [Resource Manager Template](#tab/azure-resource-manager)
 
-You can also use Azure Resource Manager templates to create an incremental snapshot. You'll need to make sure the apiVersion is set to **2019-03-01** and that the incremental property is also set to true. The following snippet is an example of how to create an incremental snapshot with Resource Manager templates:
+You can also use Azure Resource Manager templates to create an incremental snapshot. You'll need to make sure the apiVersion is set to **2022-03-22** and that the incremental property is also set to true. The following snippet is an example of how to create an incremental snapshot with Resource Manager templates:
 
 ```json
 {
@@ -130,7 +139,7 @@ You can also use Azure Resource Manager templates to create an incremental snaps
     "type": "Microsoft.Compute/snapshots",
     "name": "[concat( parameters('diskName'),'_snapshot1')]",
     "location": "[resourceGroup().location]",
-    "apiVersion": "2019-03-01",
+    "apiVersion": "2022-03-22",
     "properties": {
       "creationData": {
         "createOption": "Copy",
@@ -142,13 +151,16 @@ You can also use Azure Resource Manager templates to create an incremental snaps
   ]
 }
 ```
+> [!IMPORTANT]
+> After taking a snapshot of an Ultra Disk, you must wait for the snapshot to complete before you can use it.  See the [Check status of snapshots or disks](#check-status-of-snapshots-or-disks) section for details.
+
 ---
 
-## Check snapshot status
+## Check status of snapshots or disks
 
 Incremental snapshots of Ultra Disks (preview) can't be used to create new disks until the background process copying the data into the snapshot has completed. Similarly, Ultra Disks created from incremental snapshots can't be attached to a VM until the background process copying the data into the disk has completed.
 
-You can check the status of this copy process with the scripts in the following sections.
+You can use either the [CLI](#cli) or [PowerShell](#powershell) sections to check the status of the background copy from a disk to a snapshot and you can use the [Check disk creation status](#check-disk-creation-status) section to check the status of a background copy from a snapshot to a disk.
 
 ### CLI
 
@@ -168,7 +180,7 @@ diskId=$(az disk show -n $diskName -g $resourceGroupName --query [id] -o tsv)
 az snapshot list --query "[?creationData.sourceResourceId=='$diskId' && incremental]" -g $resourceGroupName --output table
 ```
 
-Now that you have a list of snapshots, you can check the `CompletionPercent` property of a snapshot to get its status. Replace `$sourceSnapshotName` with the name of your snapshot. The value of the property must be 100 before you can use the snapshot for restoring disk or generate a SAS URI for downloading the underlying data.
+Now that you have a list of snapshots, you can check the `CompletionPercent` property of an individual snapshot to get its status. Replace `$sourceSnapshotName` with the name of your snapshot. The value of the property must be 100 before you can use the snapshot for restoring disk or generate a SAS URI for downloading the underlying data.
 
 ```azurecli
 az snapshot show -n $sourceSnapshotName -g $resourceGroupName --query [completionPercent] -o tsv
@@ -204,6 +216,33 @@ foreach ($snapshot in $snapshots)
 $incrementalSnapshots
 ```
 
+Now that you have a list of snapshots, you can check the `CompletionPercent` property of an individual snapshot to get its status. Replace `yourResourceGroupNameHere` and `yourSnapshotName` then run the script. The value of the property must be 100 before you can use the snapshot for restoring disk or generate a SAS URI for downloading the underlying data.
+
+```azurepowershell
+$resourceGroupName = "yourResourceGroupNameHere"
+$snapshotName = "yourSnapshotName"
+
+$targetSnapshot=Get-AzSnapshot -ResourceGroupName $resourceGroupName -SnapshotName $snapshotName
+
+$targetSnapshot.CompletionPercent
+```
+
+### Check disk creation status
+
+When creating a disk from an Ultra Disk snapshot, you must wait for the background copy process to complete before you can attach it. Currently, you must use the Azure CLI to check the progress of the copy process.
+
+The following script gives you the status of an individual disk's copy process. The value of `completionPercent` must be 100 before the disk can be attached.
+
+```azurecli
+subscriptionId=yourSubscriptionID
+resourceGroupName=yourResourceGroupName
+diskName=yourDiskName
+
+az account set --subscription $subscriptionId
+
+az disk show -n $diskName -g $resourceGroupName --query [completionPercent] -o tsv
+```
+
 ## Check sector size
 
 Snapshots with a 4096 logical sector size can only be used to create Ultra Disks. They can't be used to create other disk types. Snapshots of disks with 4096 logical sector size are stored as VHDX, whereas snapshots of disks with 512 logical sector size are stored as VHD. Snapshots inherit the logical sector size from the parent disk.
@@ -213,7 +252,7 @@ To determine whether or your Ultra Disk snapshot is a VHDX or a VHD, get the `Lo
 The following command displays the logical sector size of a snapshot:
 
 ```azurecli
-az snapshot show -g resourcegroupname-n snapshotname--query [creationData.logicalSectorSize] -o tsv
+az snapshot show -g resourcegroupname -n snapshotname --query [creationData.logicalSectorSize] -o tsv
 ```
 
 ## Next steps

includes/virtual-machines-disks-incremental-snapshots-restrictions.md

@@ -5,7 +5,7 @@
  author: roygara
  ms.service: virtual-machines
  ms.topic: include
- ms.date: 01/23/2023
+ ms.date: 01/25/2023
  ms.author: rogarana
  ms.custom: include file
 ---
@@ -21,9 +21,11 @@
 
 ### Incremental snapshots of Ultra Disks (preview)
 
+Incremental snapshots of Ultra Disks have the following extra restrictions:
+
 - You must request and receive access to the preview from the following link: [https://aka.ms/UltraPremiumv2SnapshotPreview](https://aka.ms/UltraPremiumv2SnapshotPreview)
 - Currently only available in Sweden Central and US West 3.
-- Snapshots with a 4096 logical sector size can only be used to create Ultra Disks. They can't be used to create other disk types. To determine what sector size your snapshot has, see [check sector size](#check-sector-size).
-- When an incremental snapshot of an Ultra Disk is created, a background copy process for that disk is started. While a background copy is ongoing, you can have up to three total snapshots pending. The process must complete before any additional snapshots of that disk can be created.
-- Incremental snapshots of an Ultra disk can't be used immediately after they're created. The background copy must complete before you can create a disk from the snapshot. See [check snapshot status](#check-snapshot-status) for details.
-- Disks created from an incremental snapshot of an Ultra Disk can't be immediately attached to a VM once it's created. The background copy must complete before it can be attached. See [check snapshot status](#check-snapshot-status) for details.
+- Snapshots with a 512 logical sector size are stored as VHD, and can be used to create any disk type. Snapshots with a 4096 logical sector size are stored as VHDX and can only be used to create Ultra Disks, they can't be used to create other disk types. To determine which sector size your snapshot is, see [check sector size](#check-sector-size).
+- When an incremental snapshot of an Ultra Disk is created, a background copy process for that disk is started. While a background copy is ongoing, you can have up to three total snapshots pending. The process must complete before any more snapshots of that disk can be created.
+- Incremental snapshots of an Ultra disk can't be used immediately after they're created. The background copy must complete before you can create a disk from the snapshot. See [Check status of snapshots or disks](#check-status-of-snapshots-or-disks) for details.
+- Disks created from an incremental snapshot of an Ultra Disk can't be immediately attached to a VM once it's created. The background copy must complete before it can be attached. See [Check disk creation status](#check-disk-creation-status) for details.