Skip to content

Commit cc2071e

Browse files
cdparkecfan
andauthored
Apply suggestions from code review
Co-authored-by: Esther Fan <[email protected]>
1 parent be2ea6b commit cc2071e

File tree

3 files changed

+20
-18
lines changed

3 files changed

+20
-18
lines changed

articles/logic-apps/add-run-javascript.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: Add and Run JavaScript in Workflows
3-
description: Write and run JavaScript code snippets in workflows to perform custom integration tasks using Inline Code operations in Azure Logic Apps.
2+
title: Run JavaScript in Workflows
3+
description: Learn how to run JavaScript code snippets in workflows for custom integration tasks by using Inline Code operations in Azure Logic Apps.
44
services: logic-apps
55
ms.suite: integration
66
ms.reviewer: estfan, azla
@@ -42,7 +42,7 @@ The following diagram shows the highlights from an example workflow:
4242

4343
* The logic app resource with the workflow where you want to add your code snippet. The workflow must already start with a trigger.
4444

45-
This article's example uses the Office 365 Outlook trigger named **When a new email arrives**.
45+
This article's example uses the **Office 365 Outlook** trigger named **When a new email arrives**.
4646

4747
If you don't have a logic app resource and workflow, create them now by following the steps for the logic app that you want:
4848

@@ -107,7 +107,9 @@ The following diagram shows the highlights from an example workflow:
107107

108108
:::image type="content" source="media/add-run-javascript/save-email-body-variable-consumption.png" alt-text="Screenshot showing the Consumption workflow, Execute JavaScript Code action, and example code that creates variables.":::
109109

110-
1. With your cursor still in the **Code** box, select **Add dynamic content**. Find the **When a new email arrives** section, and select the **Body** property, which references the email message's body.
110+
1. With your cursor still in the **Code** box, select the lightning icon to open the dynamic content list.
111+
112+
1. In the list, under the **When a new email arrives** section, select the **Body** property, which references the trigger output with the email message body.
111113

112114
:::image type="content" source="media/add-run-javascript/select-output-consumption.png" alt-text="Screenshot showing the Consumption workflow, Execute JavaScript Code action, dynamic content list, and email message's Body property selected.":::
113115

@@ -355,13 +357,13 @@ Before you start, you need the JSON name for the trigger or action in the underl
355357

356358
`My.Action.Name`
357359

358-
1. On the workflow menu, select **Code view**. In the `actions` object, find the action's name.
360+
1. On the workflow menu, under **Tools**, select **Code** to view the workflow's JSON definition. In the `actions` object, find the action's name.
359361

360362
For example, `Send_approval_email` is the JSON name for the **Send approval email** action.
361363

362364
:::image type="content" source="media/add-run-javascript/find-action-name-json.png" alt-text="Screenshot showing the action name in JSON.":::
363365

364-
1. To return to designer view, on the workflow menu, select **Designer**.
366+
1. To return to designer view, on the workflow menu, under **Tools**, select **Designer**.
365367

366368
1. Now add the JSON name to the **Execute JavaScript Code** action.
367369

@@ -394,5 +396,5 @@ For more information about the **Execute JavaScript Code** action's structure an
394396

395397
## Related content
396398

397-
* [List of all Logic Apps connectors](/connectors/connector-reference/connector-reference-logicapps-connectors)
398-
* [Built-in connectors in Azure Logic Apps](../connectors/built-in.md)
399+
* [Managed connectors for Azure Logic Apps](/connectors/connector-reference/connector-reference-logicapps-connectors)
400+
* [Built-in connectors for Azure Logic Apps](../connectors/built-in.md)

articles/logic-apps/handle-throttling-problems-429-errors.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
title: Handle Throttling Problems or 429 Too Many Requests
3-
description: How to work around throttling problems or 'HTTP 429 Too many requests' errors in Azure Logic Apps.
3+
description: Learn how to handle workflow throttling problems or 'HTTP 429 Too many requests' errors in Azure Logic Apps.
44
services: logic-apps
55
ms.suite: integration
66
ms.reviewer: estfan, azla
@@ -72,11 +72,11 @@ To handle throttling at this level, you have the following options:
7272

7373
* A Standard workflow has no limit on the number of actions that can run during any interval.
7474

75-
* Disable array debatching or **SplitOn** behavior in triggers.
75+
* Disable array debatching or **Split On** setting in triggers.
7676

77-
If a trigger returns an array for the remaining workflow actions to process, the trigger's [SplitOn setting](logic-apps-workflow-actions-triggers.md#split-on-debatch) divides up the array items and starts a workflow instance for each array item. This behavior effectively triggers multiple concurrent runs up to the [SplitOn limit](logic-apps-limits-and-config.md#concurrency-looping-and-debatching-limits).
77+
If a trigger returns an array for the remaining workflow actions to process, the trigger's [**Split On** setting](logic-apps-workflow-actions-triggers.md#split-on-debatch) divides up the array items and starts a workflow instance for each array item. This behavior effectively triggers multiple concurrent runs up to the [**Split On** limit](logic-apps-limits-and-config.md#concurrency-looping-and-debatching-limits).
7878

79-
To control throttling, turn off the trigger's **SplitOn** behavior and have your workflow process the entire array with a single call, rather than handle a single item per call.
79+
To control throttling, turn off the trigger's **Split On** setting and have your workflow process the entire array with a single call, rather than handle a single item per call.
8080

8181
* Refactor actions into multiple, smaller workflows.
8282

@@ -104,7 +104,7 @@ Each connector has its own throttling limits, which you can find on [each connec
104104

105105
Some triggers and actions, such as HTTP, have a [retry policy](logic-apps-exception-handling.md#retry-policies) that you can customize based on the [retry policy limits](logic-apps-limits-and-config.md#retry-policy-limits) to implement exception handling. This policy specifies whether and how often a trigger or action retries a request when the original request fails or times out and results in a 408, 429, or 5xx response. So, when throttling starts and returns a 429 error, Logic Apps follows the retry policy where supported.
106106

107-
To learn whether a trigger or action supports retry policies, check the trigger or action's settings. To view a trigger or action's retry attempts, go to your logic app's run history, select the run that you want to review, and expand that trigger or action to view details about inputs, outputs, and any retries.
107+
To learn whether a trigger or action supports retry policies, check the trigger or action's settings. To view a trigger or action's retry attempts, go to your logic app workflow's run history, select the run that you want to review, and expand that trigger or action to view details about inputs, outputs, and any retries.
108108

109109
The following Consumption workflow example shows where you can find this information for an HTTP action:
110110

articles/logic-apps/logic-apps-http-endpoint.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
title: Create Callable or Nestable Workflows
3-
description: Create workflows that receive inbound requests over HTTPS endpoints in Azure Logic Apps.
3+
description: Learn how to create workflows that receive inbound requests through HTTPS endpoints in Azure Logic Apps.
44
services: logic-apps
55
ms.reviewer: estfan, azla
66
ms.topic: how-to
@@ -210,7 +210,7 @@ Based on whether you have a Standard or Consumption logic app workflow, follow t
210210

211211
By default, the **Request** trigger expects a `POST` request. However, you can specify a different method that the caller must use, but only a single method.
212212

213-
1. In the **Request** trigger, select the **Method** dropdown, then choose the method that the trigger should expect instead. Or, you can specify a custom method.
213+
1. In the **Request** trigger, from the **Method** list, select the method that the trigger should expect instead. Or, you can specify a custom method.
214214

215215
For example, select the **GET** method so that you can test your endpoint's URL later.
216216

@@ -234,11 +234,11 @@ When you want to accept parameter values through the endpoint's URL, you have th
234234

235235
### [Standard](#tab/standard)
236236

237-
1. In the **Request** trigger, select the **Method** dropdown, and then choose the **GET** method.
237+
1. In the **Request** trigger, from the **Method** list, select the **GET** method.
238238

239239
For more information, see [Select expected request method](#select-method).
240240

241-
1. Add the action named **Response** to your workflow by following the [general steps to add an action](add-trigger-action-workflow.md?tabs=standard#add-action).
241+
1. Add the **Response** action to your workflow by following the [general steps to add an action](add-trigger-action-workflow.md?tabs=standard#add-action).
242242

243243
1. To build the `triggerOutputs()` expression that retrieves the parameter value, follow these steps:
244244

@@ -370,7 +370,7 @@ When you want to accept parameter values through the endpoint's URL, you have th
370370

371371
1. In the **Body** property, enter `Postal Code: ` with a trailing space. Keep your cursor inside the edit box so that the dynamic content list remains open.
372372

373-
1. Select the lightning symbol to open the dynamic content list. From the **When a HTTP request is received** section, select the **postalCode** trigger output.
373+
1. Select the lightning icon to open the dynamic content list. From the **When a HTTP request is received** section, select the **postalCode** trigger output.
374374

375375
:::image type="content" source="./media/logic-apps-http-endpoint/response-trigger-output-standard.png" alt-text="Screenshot shows Standard workflow, Response action, and specified trigger output to include in response body." lightbox="./media/logic-apps-http-endpoint/response-trigger-output-standard.png":::
376376

0 commit comments

Comments
 (0)