Skip to content

Commit d52f10b

Browse files
authored
Merge pull request #187702 from mumian/0207-idempotent
Don't use newguid() for the role assignment name
2 parents 5761816 + 6bb90f2 commit d52f10b

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

articles/azure-resource-manager/bicep/scope-extension-resources.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
---
22
title: Scope on extension resource types (Bicep)
33
description: Describes how to use the scope property when deploying extension resource types with Bicep.
4-
author: mumian
5-
ms.author: jgao
64
ms.topic: conceptual
7-
ms.date: 11/16/2021
5+
ms.date: 02/07/2022
86
---
97

108
# Set scope for extension resources in Bicep
@@ -54,8 +52,8 @@ param principalId string
5452
@description('Built-in role to assign')
5553
param builtInRoleType string
5654
57-
@description('A new GUID used to identify the role assignment')
58-
param roleNameGuid string = newGuid()
55+
@description('The role assignment name')
56+
param roleNameGuid string
5957
6058
var role = {
6159
Owner: '/subscriptions/${subscription().subscriptionId}/providers/Microsoft.Authorization/roleDefinitions/8e3af657-a8ff-443c-a75c-2fe8c4bcb635'

articles/azure-resource-manager/templates/deploy-github-actions.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
title: Deploy Resource Manager templates by using GitHub Actions
33
description: Describes how to deploy Azure Resource Manager templates (ARM templates) by using GitHub Actions.
44
ms.topic: conceptual
5-
ms.date: 10/13/2020
5+
ms.date: 02/07/2022
66
ms.custom: github-actions-azure
77
---
88

@@ -16,8 +16,8 @@ Use the [Deploy Azure Resource Manager Template Action](https://github.com/marke
1616

1717
- An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/?WT.mc_id=A261C142F).
1818
- A GitHub account. If you don't have one, sign up for [free](https://github.com/join).
19-
- A GitHub repository to store your Resource Manager templates and your workflow files. To create one, see [Creating a new repository](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-new-repository).
2019

20+
- A GitHub repository to store your Resource Manager templates and your workflow files. To create one, see [Creating a new repository](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-new-repository).
2121

2222
## Workflow file overview
2323

@@ -32,7 +32,6 @@ The file has two sections:
3232

3333
## Generate deployment credentials
3434

35-
3635
You can create a [service principal](../../active-directory/develop/app-objects-and-service-principals.md#service-principal-object) with the [az ad sp create-for-rbac](/cli/azure/ad/sp#az_ad_sp_create_for_rbac) command in the [Azure CLI](/cli/azure/). Run this command with [Azure Cloud Shell](https://shell.azure.com/) in the Azure portal or by selecting the **Try it** button.
3736

3837
Create a resource group if you do not already have one.
@@ -62,8 +61,6 @@ In the example above, replace the placeholders with your subscription ID and res
6261
> [!IMPORTANT]
6362
> It is always a good practice to grant minimum access. The scope in the previous example is limited to the resource group.
6463
65-
66-
6764
## Configure the GitHub secrets
6865

6966
You need to create secrets for your Azure credentials, resource group, and subscriptions.
@@ -126,6 +123,7 @@ The workflow file must be stored in the **.github/workflows** folder at the root
126123
# output containerName variable from template
127124
- run: echo ${{ steps.deploy.outputs.containerName }}
128125
```
126+
129127
> [!NOTE]
130128
> You can specify a JSON format parameters file instead in the ARM Deploy action (example: `.azuredeploy.parameters.json`).
131129

@@ -147,6 +145,7 @@ Because the workflow is configured to be triggered by either the workflow file o
147145
1. Select **Run ARM deploy** from the menu to verify the deployment.
148146

149147
## Clean up resources
148+
150149
When your resource group and repository are no longer needed, clean up the resources you deployed by deleting the resource group and your GitHub repository.
151150

152151
## Next steps

0 commit comments

Comments
 (0)