Skip to content

Commit e0aa872

Browse files
committed
Minor edits.
1 parent 10807b4 commit e0aa872

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

articles/container-apps/get-started-existing-container-image.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ Now that you have an environment created, you can deploy your first container ap
4141

4242
::: zone pivot="container-apps-private-registry"
4343

44+
TODO1 Replace these H3s with a numbered list?
45+
4446
### Set environment variables
4547

4648
Replace the \<PLACEHOLDERS\> with your values. Your user principal name will typically be in the format of an email address (for example, `[email protected]`).
@@ -71,6 +73,8 @@ $RegistryUsername = "<REGISTRY_USERNAME>"
7173

7274
### Create key vault
7375

76+
TODO1 Explain why you should use a key vault to store your registry password. We could just link to one of the quickstarts below on creating a key vault and storing a secret in it, and only include the command for retrieving the secret here.
77+
7478
# [Bash](#tab/bash)
7579

7680
```bash
@@ -105,17 +109,20 @@ az role assignment create --role "Key Vault Secrets Officer" --assignee "$USER_P
105109
```azurepowershell-interactive
106110
$KeyVault=Get-AzKeyVault -VaultName $KeyVaultName
107111
New-AzRoleAssignment -SignInName "$UserPrincipalName" -RoleDefinitionName "Key Vault Secrets Officer" -Scope "$KeyVault.ResourceID"
108-
109112
```
110113

111114
---
112115

113-
### Store registry password
116+
### Store container registry password
114117

115118
Replace the \<PLACEHOLDERS\> with your values.
116119

120+
TODO1 We are deliberately not using an env var to store the registry password here.
121+
117122
# [Bash](#tab/bash)
118123

124+
TODO1 There does not seem to be an Azure CLI equivalent for "convert to secure string."
125+
119126
```bash
120127
az keyvault secret set --vault-name $KEY_VAULT_NAME --name $SECRET_NAME --value "<REGISTRY_PASSWORD>"
121128
```
@@ -129,7 +136,7 @@ Set-AzKeyVaultSecret -VaultName "$KeyVaultName" -Name "$SecretName" -SecretValue
129136

130137
---
131138

132-
### Retrieve registry password
139+
### Retrieve container registry password
133140

134141
# [Bash](#tab/bash)
135142

0 commit comments

Comments
 (0)