Skip to content

Commit e2fb05b

Browse files
authored
Merge pull request #110112 from zr-msft/ds-pr-grandchild
[Dev Spaces] add callout for grandchild space
2 parents 48d9c22 + c8d6e73 commit e2fb05b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

articles/dev-spaces/how-to/github-actions.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
---
22
title: "GitHub Actions & Azure Kubernetes Service (preview)"
33
services: azure-dev-spaces
4-
ms.date: 02/04/2020
4+
ms.date: 04/03/2020
55
ms.topic: conceptual
66
description: "Review and test changes from a pull request directly in Azure Kubernetes Service using GitHub Actions and Azure Dev Spaces"
77
keywords: "Docker, Kubernetes, Azure, AKS, Azure Kubernetes Service, containers, GitHub Actions, Helm, service mesh, service mesh routing, kubectl, k8s"
88
manager: gwallace
99
---
1010
# GitHub Actions & Azure Kubernetes Service (preview)
1111

12-
Azure Dev Spaces provides a workflow using GitHub Actions that allows you to test changes from a pull request directly in AKS before the pull request is merged into your repositorys main branch. Having a running application to review changes of a pull request can increase the confidence of both the developer as well as team members. This running application can also help team members such as, product managers and designers, become part of the review process during early stages of development.
12+
Azure Dev Spaces provides a workflow using GitHub Actions that allows you to test changes from a pull request directly in AKS before the pull request is merged into your repository's main branch. Having a running application to review changes of a pull request can increase the confidence of both the developer as well as team members. This running application can also help team members such as, product managers and designers, become part of the review process during early stages of development.
1313

1414
In this guide, you will learn how to:
1515

@@ -96,6 +96,11 @@ Navigate to your forked repository and click *Settings*. Click on *Secrets* in t
9696
9797
Optionally, if you want to update the master space after your PR is merged, add the *GATEWAY_HOST* secret, which takes the form *<MASTER_SPACE>.gateway.<HOST_SUFFIX>*, which in this example is *dev.gateway.fedcab0987.eus.azds.io*. Once you merge your changes into the master branch in your fork, another action will run to rebuild and run your entire application in the master dev space. In this example, the master space is *dev*. This action is configured in [.github/workflows/bikesharing.yml][github-action-bikesharing-yaml].
9898

99+
Additionally, if you would like the changes in your PR to run in a grandchild space, update the *MASTER_SPACE* and *HOST* secrets. For example, if your application is running in *dev* with a child space *dev/azureuser1*, to have the PR run in a child space of *dev/azureuser1*:
100+
101+
* Update *MASTER_SPACE* to the child space you want as the parent space, in this example *azureuser1*.
102+
* Update *HOST* to *<GRANDPARENT_SPACE>.<APP_NAME>.<HOST_SUFFIX>*, in this example *dev.bikesharingweb.fedcab0987.eus.azds.io*.
103+
99104
## Create a new branch for code changes
100105

101106
Navigate to `BikeSharingApp/` and create a new branch called *bike-images*.

0 commit comments

Comments
 (0)