Skip to content

Commit e77b45f

Browse files
authored
Cleaned up lots of build errors
1 parent 134f29d commit e77b45f

File tree

3 files changed

+31
-52
lines changed

3 files changed

+31
-52
lines changed

articles/communication-services/tutorials/includes/twilio-to-acs-video-android-tutorial.md

Lines changed: 16 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,21 @@ ms.subservice: calling
1111
ms.custom: mode-other
1212
---
1313

14-
# Prerequisites
14+
## Prerequisites
1515

1616
1. **Azure Account:** Make sure that your Azure account is active. New users can create a free account at [Microsoft Azure](https://azure.microsoft.com/free/).
17-
2. **Communication Services Resource:** Set up a [Communication Services Resource](../quickstarts/create-communication-resource.md?tabs=windows&pivots=platform-azp) via your Azure portal and note your connection string.
18-
3. **Azure CLI:** Follow the instructions at [Install Azure CLI on Windows](/cli/azure/install-azure-cli-windows?tabs=azure-cli)..
17+
2. **Communication Services Resource:** Set up a [Communication Services Resource](../../quickstarts/create-communication-resource.md?tabs=windows&pivots=platform-azp) via your Azure portal and note your connection string.
18+
3. **Azure CLI:** Follow the instructions to [Install Azure CLI on Windows](/cli/azure/install-azure-cli-windows?tabs=azure-cli)..
1919
4. **User Access Token:** Generate a user access token to instantiate the call client. You can create one using the Azure CLI as follows:
2020
```console
2121
az communication identity token issue --scope voip --connection-string "yourConnectionString"
2222
```
2323

24-
For more information, see [Use Azure CLI to Create and Manage Access Tokens](../quickstarts/identity/access-tokens.md?pivots=platform-azcli).
24+
For more information, see [Use Azure CLI to Create and Manage Access Tokens](../../quickstarts/identity/access-tokens.md?pivots=platform-azcli).
2525

2626
For Video Calling as a Teams user:
2727

28-
- You can also use Teams identity. To generate an access token for a Teams User, see [Manage teams identity](../quickstarts/manage-teams-identity.md?pivots=programming-language-javascript).
28+
- You can also use Teams identity. To generate an access token for a Teams User, see [Manage teams identity](../../quickstarts/manage-teams-identity.md?pivots=programming-language-javascript).
2929
- Obtain the Teams thread ID for call operations using the [Graph Explorer](https://developer.microsoft.com/graph/graph-explorer). For information about creating a thread ID, see [Create chat - Microsoft Graph v1.0 > Example2: Create a group chat](/graph/api/chat-post?preserve-view=true&tabs=javascript&view=graph-rest-1.0#example-2-create-a-group-chat).
3030

3131
## Installation
@@ -116,10 +116,9 @@ val callAgent: CallAgent = CallClient().createCallAgent(
116116

117117

118118
## Initiating an outgoing call
119-
This step requires a valid access token.
120119

121120
### Twilio
122-
Twilio Video Android SDK does not have a concept of Call. Twilio Video SDK uses the concept of Room.
121+
Twilio Video Android SDK doesn't have a concept of Call. Twilio Video SDK uses the concept of Room.
123122
In scenarios where client A wishes to establish communication with client B, client A can create a room; B needs to connect to it. Developers can emulate a call-like experience with Twilio by incorporating features such as push notifications.
124123
In this setup, client A notifies client B about the desire to initiate communication by joining a room.
125124
Twilio Video Android SDK doesn't support this particular concept directly.
@@ -144,7 +143,7 @@ room = Video.connect(context, connectOptions, roomListener);
144143

145144
### Azure Communication Services Calling
146145

147-
Initiating a call with the ASCCalling SDK involves:
146+
Initiating a call with the calling SDK involves:
148147

149148
1. Creating a StartCallOption object
150149
2. Creating an Array of Communication Identifiers
@@ -191,19 +190,19 @@ val call: Call = callAgent.join(getApplicationContext(), teamsMeetingLinkLocator
191190
## Accepting / Joining a call
192191

193192
### Twilio
194-
As mentioned previously, Twilio Video Android SDK does not have a concept of Call. Twilio uses the concept of a room. Different clients can establish communication by joining the same room.
193+
As mentioned previously, Twilio Video Android SDK doesn't have a concept of Call. Twilio uses the concept of a room. Different clients can establish communication by joining the same room.
195194

196195
### Azure Communication Services Calling
197196

198197
#### Receiving incoming call
199198
To accept calls, the application must first be configured to receive incoming calls.
200199

201200
#### Register for push notifications and handle incoming push notification
202-
An ACS client can opt-in to receive push notifications to receive incoming calls. This [guide](../../how-tos/calling-sdk/push-notifications?pivots=platform-android) describes how to set up push notifications for the Azure Communication Services Calling framework.
201+
An ACS client can opt-in to receive push notifications to receive incoming calls. This [guide](../../how-tos/calling-sdk/push-notifications.md?pivots=platform-android) describes how to set up push notifications for the Azure Communication Services Calling framework.
203202

204203
#### Setting up the CallAgentListener
205204

206-
The Azure Communication Services Calling SDK includes an `IncomingCallListener`. An `IncomingCallListener` is set on the CallAgent instance. This listener defines an `onIncomingCall(IncomingCall incomingCall)` method which is triggered upon the arrival of an incoming call.
205+
The Azure Communication Services Calling SDK includes an `IncomingCallListener`. An `IncomingCallListener` is set on the CallAgent instance. This listener defines an `onIncomingCall(IncomingCall incomingCall)` method, which is triggered upon the arrival of an incoming call.
207206

208207
**Java**
209208
```java
@@ -251,7 +250,7 @@ incomingCall.accept(context)
251250

252251
|Class Name | Description |
253252
|-----------|----------------------|
254-
|[IncomingCallListener](java/api/com.azure.android.communication.calling.incomingcalllistener?view=communication-services-java-android) | Functional interface for incoming calls. |
253+
|[IncomingCallListener](/java/api/com.azure.android.communication.calling.incomingcalllistener?view=communication-services-java-android) | Functional interface for incoming calls. |
255254
|[IncomingCall](/java/api/com.azure.android.communication.calling.incomingcall?view=communication-services-java-android)| Describes an incoming call |
256255

257256

@@ -599,7 +598,7 @@ mediaStatsCallFeature.apply {
599598
}
600599
```
601600

602-
For more information, see the [Media quality statistics](../../concepts/voice-video-calling/media-quality-sdk?pivots=platform-android) guide.
601+
For more information, see the [Media quality statistics](../../concepts/voice-video-calling/media-quality-sdk.md?pivots=platform-android) guide.
603602

604603

605604
## Diagnostics
@@ -698,7 +697,7 @@ localUserDiagnosticsCallFeature.getMediaDiagnostics();
698697
localUserDiagnosticsCallFeature.networkDiagnostics
699698
localUserDiagnosticsCallFeature.mediaDiagnostics
700699
```
701-
To learn more about User Facing Diagnostics, see the [User Facing Diagnostics](../../concepts/voice-video-calling/user-facing-diagnostics?pivots=platform-android)
700+
To learn more about User Facing Diagnostics, see the [User Facing Diagnostics](../../concepts/voice-video-calling/user-facing-diagnostics.md?pivots=platform-android)
702701

703702

704703
## Event Listeners
@@ -771,7 +770,7 @@ Twilio has a `LocalParticipant.Listener` that allows clients to receive updates
771770
* The network quality level for the local participant changed
772771

773772
#### Azure Communication Services Calling
774-
The CallAgent receives updates regarding calls through two listeners: `CallsUpdatedListener` and the `IncomingCallListener`. These listeners will be triggered respectively for the following events:
773+
The CallAgent receives updates regarding calls through two listeners: `CallsUpdatedListener` and the `IncomingCallListener`. These listeners are triggered respectively for the following events:
775774

776775
* calls are updated, a new call is created, an existing call is disconnected
777776
* an incoming call is received
@@ -780,7 +779,7 @@ The CallAgent receives updates regarding calls through two listeners: `CallsUpda
780779
| Class Name | Description |
781780
|-----------|----------------------|
782781
|[PropertyChangedListener](/java/api/com.azure.android.communication.calling.propertychangedlistener?view=communication-services-java-android) | Informs the library that the call state has changed|
783-
|[CallsUpdatedListener](/java/api/com.azure.android.communication.calling.callsupdatedlistener?view=communication-services-java-android) | Informs the library when the calls have been updated |
782+
|[CallsUpdatedListener](/java/api/com.azure.android.communication.calling.callsupdatedlistener?view=communication-services-java-android) | Informs the library when the calls are updated |
784783
|[IncomingCallListener](/java/api/com.azure.android.communication.calling.incomingcalllistener?view=communication-services-java-android) | Informs the library about incoming call |
785784
|[VideoDevicesUpdatedListener](/java/api/com.azure.android.communication.calling.videodevicesupdatedlistener?view=communication-services-java-android) | Informs the library that new video devices were added or removed to the current library|
786785

@@ -827,24 +826,4 @@ call.hangUp(HangUpOptions().apply { isForEveryone = true }).get()
827826
|[HangUpOptions](/java/api/com.azure.android.communication.calling.hangupoptions?view=communication-services-java-android)| Property bag class for hanging up a call |
828827

829828
# Cleaning Up
830-
If you want to [clean up and remove a Communication Services subscription](../../quickstarts/create-communication-resource?tabs=windows&pivots=platform-azp#clean-up-resources), you can delete the resource or resource group.
831-
832-
# More information
833-
834-
### Add 1:1 video quickstart
835-
https://learn.microsoft.com/en-us/azure/communication-services/quickstarts/voice-video-calling/get-started-with-video-calling?pivots=platform-android
836-
837-
### Calling SDK overview
838-
https://learn.microsoft.com/en-us/azure/communication-services/concepts/voice-video-calling/calling-sdk-features
839-
840-
### Video constraints
841-
https://learn.microsoft.com/en-us/azure/communication-services/concepts/voice-video-calling/video-constraints
842-
843-
# Additional features from the ACS SDK
844-
Some features of the Azure Communication Services Calling SDK described in the list below don’t have an equivalent in the Twilio Android SDK.
845-
### Raise Hand
846-
[RaiseHand](../../how-tos/calling-sdk/raise-hand?pivots=platform-android) feature allows participants of a call to raise or lower hands.
847-
### Video Background
848-
[Adding VideoBackground](../../quickstarts/voice-video-calling/get-started-video-effects?pivots=platform-android) Allow users to blur the background in the video stream.
849-
### Video spotlights
850-
[Spotlights](../../how-tos/calling-sdk/spotlight?pivots=platform-android) Allow users to pin and unpin videos.
829+
If you want to [clean up and remove a Communication Services subscription](../../quickstarts/create-communication-resource?tabs=windows&pivots=platform-azp#clean-up-resources), you can delete the resource or resource group.

articles/communication-services/tutorials/includes/twilio-to-acs-video-ios-tutorial.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,22 @@ ms.custom: mode-other
1414
## Prerequisites
1515

1616
1. **Azure Account:** Make sure that your Azure account is active. New users can create a free account at [Microsoft Azure](https://azure.microsoft.com/free/).
17-
2. **Communication Services Resource:** Set up a [Communication Services Resource](../quickstarts/create-communication-resource.md?tabs=windows&pivots=platform-azp) via your Azure portal and note your connection string.
18-
3. **Azure CLI:** Follow the instructions at [Install Azure CLI on Windows](/cli/azure/install-azure-cli-windows?tabs=azure-cli)..
17+
2. **Communication Services Resource:** Set up a [Communication Services Resource](../../quickstarts/create-communication-resource.md?tabs=windows&pivots=platform-azp) via your Azure portal and note your connection string.
18+
3. **Azure CLI:** Follow the instructions to [Install Azure CLI on Windows](/cli/azure/install-azure-cli-windows?tabs=azure-cli)..
1919
4. **User Access Token:** Generate a user access token to instantiate the call client. You can create one using the Azure CLI as follows:
2020
```console
2121
az communication identity token issue --scope voip --connection-string "yourConnectionString"
2222
```
2323

24-
For more information, see [Use Azure CLI to Create and Manage Access Tokens](../quickstarts/identity/access-tokens.md?pivots=platform-azcli).
24+
For more information, see [Use Azure CLI to Create and Manage Access Tokens](../../quickstarts/identity/access-tokens.md?pivots=platform-azcli).
2525

2626
For Video Calling as a Teams user:
2727

28-
- You can also use Teams identity. To generate an access token for a Teams User, see [Manage teams identity](../quickstarts/manage-teams-identity.md?pivots=programming-language-javascript).
28+
- You can also use Teams identity. To generate an access token for a Teams User, see [Manage teams identity](../../quickstarts/manage-teams-identity.md?pivots=programming-language-javascript).
2929
- Obtain the Teams thread ID for call operations using the [Graph Explorer](https://developer.microsoft.com/graph/graph-explorer). For information about creating a thread ID, see [Create chat - Microsoft Graph v1.0 > Example2: Create a group chat](/graph/api/chat-post?preserve-view=true&tabs=javascript&view=graph-rest-1.0#example-2-create-a-group-chat).
3030

3131
## Installation
32-
To start the migration from Twilio iOS Video SDK, the first step is to install the Azure Communication Services calling iOS SDK to your project. You can configure this in `Cocoapods`.
32+
To start the migration from Twilio iOS Video SDK, the first step is to install the Azure Communication Services calling iOS SDK to your project. You can configure these parameters using`Cocoapods`.
3333

3434
1. To create a Podfile for your application, open the terminal and navigate to the project folder and run:
3535

@@ -58,7 +58,7 @@ To be able to use the Azure Communication Services calling SDK, you need to auth
5858

5959
### Twilio
6060

61-
From witin the Twilio Video framework, the access token is used to connect to a room. By passing it to ConnectOptions and then using the connect option to create or connect a room.
61+
From witin the Twilio Video framework, the access token is used to connect to a room. By passing the token to ConnectOptions you can create the option to create or connect a room.
6262

6363
```swift
6464
let connectOptions = ConnectOptions(token: accessToken) {
@@ -248,7 +248,7 @@ localVideoTrack = LocalVideoTrack(source: camera!, enabled: true, name: "Camera"
248248

249249
**At connect time**
250250

251-
When a call connects you can add the local video track to the call can be achieved by passing the local video track to the localVideo track list that can be set with ConnectOptions.
251+
When a call connects, you can add the local video track to the call can be achieved by passing the local video track to the localVideo track list that can be set with ConnectOptions.
252252

253253
```swift
254254
let connectOptions = ConnectOptions(token: accessToken) { builder in

articles/communication-services/tutorials/includes/twilio-to-acs-video-webjs-tutorial.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,18 @@ ms.custom: mode-other
1515

1616
1. **Azure Account:** Make sure that your Azure account is active. New users can create a free account at [Microsoft Azure](https://azure.microsoft.com/free/).
1717
2. **Node.js 18:** Ensure Node.js 18 is installed on your system. Download from [Node.js](https://nodejs.org/en).
18-
3. **Communication Services Resource:** Set up a [Communication Services Resource](../quickstarts/create-communication-resource.md?tabs=windows&pivots=platform-azp) via your Azure portal and note your connection string.
19-
4. **Azure CLI:** Follow the instructions at [Install Azure CLI on Windows](/cli/azure/install-azure-cli-windows?tabs=azure-cli)..
18+
3. **Communication Services Resource:** Set up a [Communication Services Resource](../../quickstarts/create-communication-resource.md?tabs=windows&pivots=platform-azp) via your Azure portal and note your connection string.
19+
4. **Azure CLI:** Follow the instructions to [Install Azure CLI on Windows](/cli/azure/install-azure-cli-windows?tabs=azure-cli)..
2020
5. **User Access Token:** Generate a user access token to instantiate the call client. You can create one using the Azure CLI as follows:
2121
```console
2222
az communication identity token issue --scope voip --connection-string "yourConnectionString"
2323
```
2424

25-
For more information, see [Use Azure CLI to Create and Manage Access Tokens](../quickstarts/identity/access-tokens.md?pivots=platform-azcli).
25+
For more information, see [Use Azure CLI to Create and Manage Access Tokens](../../quickstarts/identity/access-tokens.md?pivots=platform-azcli).
2626

2727
For Video Calling as a Teams user:
2828

29-
- You can also use Teams identity. To generate an access token for a Teams User, see [Manage teams identity](../quickstarts/manage-teams-identity.md?pivots=programming-language-javascript).
29+
- You can also use Teams identity. To generate an access token for a Teams User, see [Manage teams identity](../../quickstarts/manage-teams-identity.md?pivots=programming-language-javascript).
3030
- Obtain the Teams thread ID for call operations using the [Graph Explorer](https://developer.microsoft.com/graph/graph-explorer). For information about creating a thread ID, see [Create chat - Microsoft Graph v1.0 > Example2: Create a group chat](/graph/api/chat-post?preserve-view=true&tabs=javascript&view=graph-rest-1.0#example-2-create-a-group-chat).
3131

3232
## UI library
@@ -205,7 +205,7 @@ callAgent.on('incomingCall', async (call) =\>{
205205

206206
The `incomingCall` event includes an `incomingCall` instance that you can accept or reject.
207207

208-
When starting, joining, or accepting a call with *video on*, if the specified video camera device is being used by another process or if it's disabled in the system, the call starts with *video off*, and returns a `cameraStartFailed: true` call diagnostic.
208+
When starting, joining, or accepting a call with *video on*, if the specified video camera device is being used by another process or if the camera is disabled in the system, the call starts with *video off*, and returns a `cameraStartFailed: true` call diagnostic.
209209

210210
```javascript
211211
const incomingCallHandler = async (args: { incomingCall: IncomingCall }) => {
@@ -387,7 +387,7 @@ localVideoStream.switchSource(camera);
387387
388388
If the specified video device is being used by another process, or if it's disabled in the system:
389389

390-
- While in a call, if your video is off and you start video using `call.startVideo()`, this method returns a `SourceUnavailableError` and `cameraStartFailed` will be set to true.
390+
- While in a call, if your video is off and you start video using `call.startVideo()`, this method returns a `SourceUnavailableError` and `cameraStartFailed` are set to true.
391391
- A call to the `localVideoStream.switchSource()` method causes `cameraStartFailed` to be set to true. See the [Call Diagnostics guide](../../concepts/voice-video-calling/call-diagnostics.md) for more information about how to diagnose call-related issues.
392392

393393
To verify whether the local video is *on* or *off* you can use the `isLocalVideoStarted` API, which returns true or false:
@@ -601,7 +601,7 @@ if (backgroundBlurSupported) {
601601
}
602602
```
603603
604-
For background replacement with an image you need to provide the URL of the image you want as the background to this effect. Supported image formats are: PNG, JPG, JPEG, TIFF, and BMP. The supported aspect ratio is 16:9.
604+
To use a custom background replacement with an image you need to provide the URL of the image you want as the background to this effect. Supported image formats are: PNG, JPG, JPEG, TIFF, and BMP. The supported aspect ratio is 16:9.
605605
606606
```javascript
607607
const backgroundImage = 'https://linkToImageFile';
@@ -757,7 +757,7 @@ twilioRoom.on('dominantSpeakerChanged', (participant) => {
757757
758758
#### Azure Communication Services
759759
760-
Dominant speakers for a call are an extended feature of the core Call API. It enables you to obtain a list of the active speakers in the call. This is a ranked list, where the first element in the list represents the last active speaker on the call and so on.
760+
Dominant speakers for a call are an extended feature of the core Call API. It enables you to obtain a list of the active speakers in the call. Thhe list of dominant speakers is a ranked list, where the first element in the list represents the last active speaker on the call and so on.
761761
762762
In order to obtain the dominant speakers in a call, you first need to obtain the call dominant speakers feature API object:
763763
```javascript

0 commit comments

Comments
 (0)