Skip to content

Commit e7f56d5

Browse files
committed
Updated as per �Peer Review Feedback
1 parent 381a598 commit e7f56d5

File tree

7 files changed

+63
-63
lines changed

7 files changed

+63
-63
lines changed

articles/azure-monitor/profiler/profiler-bring-your-own-storage.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ ms.custom: devdivchpfy22
1616

1717
When you use Application Insights Profiler or Snapshot Debugger, artifacts generated by your application are uploaded into Azure storage accounts over the public Internet. For these artifacts and storage accounts, Microsoft controls and covers the cost for:
1818

19-
* Processing and analysis
20-
* Encryption-at-rest and lifetime management policies
19+
* Processing and analysis.
20+
* Encryption-at-rest and lifetime management policies.
2121

2222
When you configure Bring Your Own Storage (BYOS), artifacts are uploaded into a storage account that you control. That means you control and are responsible for the cost of:
2323

24-
* The encryption-at-rest policy and the Lifetime management policy
25-
* Network access
24+
* The encryption-at-rest policy and the Lifetime management policy.
25+
* Network access.
2626

2727
> [!NOTE]
2828
> BYOS is required if you are enabling Private Link or Customer-Managed Keys.
@@ -79,19 +79,19 @@ Steps:
7979
:::image type="content" source="media/profiler-bring-your-own-storage/add-role-assignment-page.png" alt-text="Screenshot showing how to add role assignment page in Azure portal.":::
8080
*Figure 1.0*
8181

82-
After you added the role, it will appear under the "Role assignments" section, like the below Figure 1.1.
82+
After you added the role, it will appear under the "**Role assignments**" section, like the below Figure 1.1.
8383
:::image type="content" source="media/profiler-bring-your-own-storage/figure-11.png" alt-text="Screenshot showing the IAM screen after Role assignments.":::
8484
*Figure 1.1*
8585

86-
If you're also using Private Link, it's required one additional configuration to allow connection to our Trusted Microsoft Service from your Virtual Network. Refer to the [Storage Network Security documentation](../../storage/common/storage-network-security.md#trusted-microsoft-services).
86+
If you're also using Private Link, it's required one additional configuration to allow connection to our Trusted Microsoft Service from your Virtual Network. or more information, see [Storage Network Security documentation](../../storage/common/storage-network-security.md#trusted-microsoft-services).
8787

8888
### Link your Storage Account with your Application Insights resource
8989

9090
To configure BYOS for code-level diagnostics (Profiler/Debugger), there are three options:
9191

92-
* Using Azure PowerShell cmdlets
93-
* Using the Azure CLI
94-
* Using Azure Resource Manager templates
92+
* Using Azure PowerShell cmdlets.
93+
* Using the Azure CLI.
94+
* Using Azure Resource Manager templates.
9595

9696
#### [PowerShell](#tab/azure-powershell)
9797

@@ -111,7 +111,7 @@ To configure BYOS for code-level diagnostics (Profiler/Debugger), there are thre
111111
Connect-AzAccount -Subscription "{subscription_id}"
112112
```
113113
114-
For more info of how to sign in, refer to the [Connect-AzAccount documentation](/powershell/module/az.accounts/connect-azaccount).
114+
For more information on how to sign in, refer to the [Connect-AzAccount documentation](/powershell/module/az.accounts/connect-azaccount).
115115
116116
1. Remove previous Storage Account linked to your Application Insights resource.
117117

articles/azure-monitor/snapshot-debugger/snapshot-debugger-app-service.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ ms.custom: devdivchpfy22
1414

1515
Snapshot Debugger currently supports ASP.NET and ASP.NET Core apps that are running on Azure App Service on Windows service plans.
1616

17-
We recommend you run your application on the Basic service tier, or higher, when using Snapshot Debugger.
17+
We recommend that you run your application on the Basic service tier, or higher, when using Snapshot Debugger.
1818

1919
For most applications, the Free and Shared service tiers don't have enough memory or disk space to save snapshots.
2020

2121
## <a id="installation"></a> Enable Snapshot Debugger
2222

23-
Snapshot Debugger is pre-installed as part of the App Services runtime, but you need to turn it on to get snapshots for your App Service app. To enable Snapshot Debugger for an app, follow the instructions below.
23+
Snapshot Debugger is pre-installed as part of the App Services runtime, but you need to turn it on to get snapshots for your App Service app. To enable Snapshot Debugger for an app, follow the instructions below:
2424

2525
> [!NOTE]
2626
> If you're using a preview version of .NET Core, or your application references Application Insights SDK (directly or indirectly via a dependent assembly), follow the instructions for [Enable Snapshot Debugger for other environments](snapshot-debugger-vm.md) to include the [`Microsoft.ApplicationInsights.SnapshotCollector`](https://www.nuget.org/packages/Microsoft.ApplicationInsights.SnapshotCollector) NuGet package with the application.
@@ -29,9 +29,9 @@ Snapshot Debugger is pre-installed as part of the App Services runtime, but you
2929
> Codeless installation of Application Insights Snapshot Debugger follows the .NET Core support policy.
3030
> For more information about supported runtimes, see [.NET Core Support Policy](https://dotnet.microsoft.com/platform/support/policy/dotnet-core).
3131
32-
Once you've deployed your .NET app:
32+
After you've deployed your .NET app:
3333

34-
1. Navigate to the Azure control panel for your App Service.
34+
1. Go to to the Azure control panel for your App Service.
3535
1. Go to the **Settings** > **Application Insights** page.
3636

3737
:::image type="content" source="./media/snapshot-debugger/application-insights-app-services.png" alt-text="Screenshot showing the Enable App Insights on App Services portal.":::
@@ -69,15 +69,15 @@ Application Insights Snapshot Debugger supports Azure AD authentication for snap
6969

7070
As of today, Snapshot Debugger only supports Azure AD authentication when you reference and configure Azure AD using the Application Insights SDK in your application.
7171

72-
To enable Azure AD for snapshot ingestion:
72+
To turn-on Azure AD for snapshot ingestion:
7373

7474
1. Create and add the managed identity you want to use to authenticate against your Application Insights resource to your App Service.
7575

76-
1. For System-Assigned Managed identity, see the following [documentation](../../app-service/overview-managed-identity.md?tabs=portal%2chttp#add-a-system-assigned-identity)
76+
1. For System-Assigned Managed identity, see the following [documentation](../../app-service/overview-managed-identity.md?tabs=portal%2chttp#add-a-system-assigned-identity).
7777

78-
1. For User-Assigned Managed identity, see the following [documentation](../../app-service/overview-managed-identity.md?tabs=portal%2chttp#add-a-user-assigned-identity)
78+
1. For User-Assigned Managed identity, see the following [documentation](../../app-service/overview-managed-identity.md?tabs=portal%2chttp#add-a-user-assigned-identity).
7979

80-
1. Configure and enable Azure AD in your Application Insights resource. For more information, see the following [documentation](../app/azure-ad-authentication.md?tabs=net#configuring-and-enabling-azure-ad-based-authentication)
80+
1. Configure and turn on Azure AD in your Application Insights resource. For more information, see the following [documentation](../app/azure-ad-authentication.md?tabs=net#configuring-and-enabling-azure-ad-based-authentication)
8181
1. Add the following application setting, used to let Snapshot Debugger agent know which managed identity to use:
8282

8383
For System-Assigned Identity:
@@ -94,7 +94,7 @@ For User-Assigned Identity:
9494

9595
## Disable Snapshot Debugger
9696

97-
To disable Snapshot Debugger, repeat the [steps for enabling](#installation), but switch the Snapshot Debugger toggles to **Off**.
97+
To disable Snapshot Debugger, repeat the [steps for enabling](#installation). However, switch the Snapshot Debugger toggles to **Off**.
9898

9999
## Azure Resource Manager template
100100

@@ -140,11 +140,11 @@ For an Azure App Service, you can set app settings within the Azure Resource Man
140140

141141
## Not Supported Scenarios
142142

143-
Below you can find scenarios where Snapshot Collector is not supported:
143+
Below you can find scenarios where Snapshot Collector isn't supported:
144144

145145
|Scenario | Side Effects | Recommendation |
146146
|------------|--------------|----------------|
147-
|You're using the Snapshot Collector SDK in your application directly (.csproj) and have enabled the advanced option "Interop".| The local Application Insights SDK (including Snapshot Collector telemetry) will be lost and no Snapshots will be available. <br/> Your application could crash at startup with `System.ArgumentException: telemetryProcessorTypedoes not implement ITelemetryProcessor.` <br/> [Learn more about the Application Insights feature "Interop".](../app/azure-web-apps-net-core.md#troubleshooting) | If you are using the advanced option "Interop", use the codeless Snapshot Collector injection (enabled through the Azure portal). |
147+
|You're using the Snapshot Collector SDK in your application directly (*.csproj*) and have enabled the advanced option "Interop".| The local Application Insights SDK (including Snapshot Collector telemetry) will be lost and no Snapshots will be available. <br/> Your application could crash at startup with `System.ArgumentException: telemetryProcessorTypedoes not implement ITelemetryProcessor.` <br/> [Learn more about the Application Insights feature "Interop".](../app/azure-web-apps-net-core.md#troubleshooting) | If you're using the advanced option "Interop", use the codeless Snapshot Collector injection (enabled through the Azure portal). |
148148

149149
## Next steps
150150

articles/azure-monitor/snapshot-debugger/snapshot-debugger-function-app.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ ms.custom: devdivchpfy22
1414

1515
Snapshot Debugger currently works for ASP.NET and ASP.NET Core apps that are running on Azure Functions on Windows Service Plans.
1616

17-
We recommend you run your application on the Basic service tier or higher when using Snapshot Debugger.
17+
We recommend that you run your application on the Basic service tier or higher when using Snapshot Debugger.
1818

1919
For most applications, the Free and Shared service tiers don't have enough memory or disk space to save snapshots.
2020

@@ -43,7 +43,7 @@ Snapshot Debugger is pre-installed as part of the Azure Functions runtime and is
4343

4444
In the simple .NET Core Function app example below, `.csproj`, `{Your}Function.cs`, and `host.json` has Snapshot Debugger enabled:
4545

46-
***Project.`csproj`***
46+
***`Project.csproj`***
4747

4848
```xml
4949
<Project Sdk="Microsoft.NET.Sdk">
@@ -160,11 +160,11 @@ To disable Snapshot Debugger in your Function app, update your `host.json` file
160160
}
161161
```
162162

163-
We recommend you have Snapshot Debugger enabled on all your apps to ease diagnostics of application exceptions.
163+
We recommend that you have Snapshot Debugger enabled on all your apps to ease diagnostics of application exceptions.
164164

165165
## Next steps
166166

167167
* Generate traffic to your application that can trigger an exception. Then, wait 10 to 15 minutes for snapshots to be sent to the Application Insights instance.
168168
* [View snapshots](snapshot-debugger.md?toc=/azure/azure-monitor/toc.json#view-snapshots-in-the-portal) in the Azure portal.
169-
* Customize Snapshot Debugger configuration based on your use-case on your Function app. For more info, see [snapshot configuration in host.json](../../azure-functions/functions-host-json.md#applicationinsightssnapshotconfiguration).
169+
* Customize Snapshot Debugger configuration based on your use-case on your Function app. For more information, see [snapshot configuration in host.json](../../azure-functions/functions-host-json.md#applicationinsightssnapshotconfiguration).
170170
* For help with troubleshooting Snapshot Debugger issues, see [Snapshot Debugger troubleshooting](snapshot-debugger-troubleshoot.md?toc=/azure/azure-monitor/toc.json).

0 commit comments

Comments
 (0)