Skip to content

Commit ef03e43

Browse files
committed
acrolinx
1 parent b4c8d4d commit ef03e43

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

articles/storage/blobs/storage-blobs-static-site-github-actions.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Get started with [GitHub Actions](https://docs.github.com/en/actions) by using a
2525
An Azure subscription and GitHub account.
2626

2727
- An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/?WT.mc_id=A261C142F).
28-
- A GitHub repository with your static website code. If you don't have a GitHub account, [sign up for free](https://github.com/join).
28+
- A GitHub repository with your static website code. If you do not have a GitHub account, [sign up for free](https://github.com/join).
2929
- A working static website hosted in Azure Storage. Learn how to [host a static website in Azure Storage](storage-blob-static-website-how-to.md). To follow this example, you should also deploy [Azure CDN](static-website-content-delivery-network.md).
3030

3131
> [!NOTE]
@@ -44,7 +44,7 @@ Replace the placeholder `myStaticSite` with the name of your site hosted in Azur
4444
az ad sp create-for-rbac --name {myStaticSite} --role contributor --scopes /subscriptions/{subscription-id}/resourceGroups/{resource-group} --sdk-auth
4545
```
4646

47-
In the example above, replace the placeholders with your subscription ID and resource group name. The output is a JSON object with the role assignment credentials that provide access to your storage account similar to below. Copy this JSON object for later.
47+
In the example, replace the placeholders with your subscription ID and resource group name. The output is a JSON object with the role assignment credentials that provide access to your storage account. Copy this JSON object for later.
4848

4949
```output
5050
{
@@ -63,15 +63,15 @@ In the example above, replace the placeholders with your subscription ID and res
6363

6464
OpenID Connect is an authentication method that uses short-lived tokens. Setting up [OpenID Connect with GitHub Actions](https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect) is more complex process that offers hardened security.
6565

66-
1. If you do not have an existing application, register a [new Active Directory application and service principal that can access resources](../active-directory/develop/howto-create-service-principal-portal.md). Create the Active Directory application.
66+
1. If you do not have an existing application, register a [new Active Directory application and service principal that can access resources](../../active-directory/develop/howto-create-service-principal-portal.md). Create the Active Directory application.
6767

6868
```azurecli-interactive
6969
az ad app create --display-name myApp
7070
```
7171
7272
This command will output JSON with an `appId` that is your `client-id`. Save the value to use as the `AZURE_CLIENT_ID` GitHub secret later.
7373
74-
You'll use the `objectId` value when creating federated credentials with Graph API and reference it as the `APPLICATION-OBJECT-ID`.
74+
You will use the `objectId` value when creating federated credentials with Graph API and reference it as the `APPLICATION-OBJECT-ID`.
7575
7676
1. Create a service principal. Replace the `$appID` with the appId from your JSON output.
7777
@@ -126,7 +126,7 @@ To learn how to create a Create an active directory application, service princip
126126
127127
# [OpenID Connect](#tab/openid)
128128
129-
You need to provide your application's **Client ID**, **Tenant ID** and **Subscription ID** to the login action. These values can either be provided directly in the workflow or can be stored in GitHub secrets and referenced in your workflow. Saving the values as GitHub secrets is the more secure option.
129+
You need to provide your application's **Client ID**, **Tenant ID**, and **Subscription ID** to the login action. These values can either be provided directly in the workflow or can be stored in GitHub secrets and referenced in your workflow. Saving the values as GitHub secrets is the more secure option.
130130
131131
1. Open your GitHub repository and go to **Settings**.
132132
@@ -166,7 +166,7 @@ You need to provide your application's **Client ID**, **Tenant ID** and **Subscr
166166
branches: [ main ]
167167
```
168168
169-
1. Rename your workflow `Blob storage website CI` and add the checkout and login actions. These actions will checkout your site code and authenticate with Azure using the `AZURE_CREDENTIALS` GitHub secret you created earlier.
169+
1. Rename your workflow `Blob storage website CI` and add the checkout and login actions. These actions will check out your site code and authenticate with Azure using the `AZURE_CREDENTIALS` GitHub secret you created earlier.
170170
171171
```yaml
172172
name: Blob storage website CI
@@ -269,7 +269,7 @@ You need to provide your application's **Client ID**, **Tenant ID** and **Subscr
269269
contents: read
270270
```
271271
272-
1. Add checkout and login actions. These actions will checkout your site code and authenticate with Azure using the GitHub secrets you created earlier.
272+
1. Add checkout and login actions. These actions will check out your site code and authenticate with Azure using the GitHub secrets you created earlier.
273273
274274
```yaml
275275
name: CI with OpenID Connect

0 commit comments

Comments
 (0)