Skip to content

Commit ef24a44

Browse files
Merge pull request #214041 from cebundy/fix-sdk-auth
[Container Apps]: remove --sdk-auth from az ad sp create-for-rbac cmd
2 parents 0402c54 + 4dad8f7 commit ef24a44

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

articles/container-apps/github-actions-cli.md

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ The first time you attach GitHub Actions to your container app, you need to prov
4343
az ad sp create-for-rbac \
4444
--name <SERVICE_PRINCIPAL_NAME> \
4545
--role "contributor" \
46-
--scopes /subscriptions/<SUBSCRIPTION_ID>/resourceGroups/<RESOURCE_GROUP_NAME> \
47-
--sdk-auth
46+
--scopes /subscriptions/<SUBSCRIPTION_ID>/resourceGroups/<RESOURCE_GROUP_NAME>
4847
```
4948

5049
# [PowerShell](#tab/powershell)
@@ -53,15 +52,14 @@ az ad sp create-for-rbac \
5352
az ad sp create-for-rbac `
5453
--name <SERVICE_PRINCIPAL_NAME> `
5554
--role "contributor" `
56-
--scopes /subscriptions/<SUBSCRIPTION_ID>/resourceGroups/<RESOURCE_GROUP_NAME> `
57-
--sdk-auth
55+
--scopes /subscriptions/<SUBSCRIPTION_ID>/resourceGroups/<RESOURCE_GROUP_NAME>
5856
```
5957

6058
---
6159

6260
As you interact with this example, replace the placeholders surrounded by `<>` with your values.
6361

64-
The return value from this command is a JSON payload, which includes the service principal's `tenantId`, `clientId`, and `clientSecret`.
62+
The return values from this command includes the service principal's `appId`, `password` and `tenant`. You need to pass these values to the `az containerapp github-action add` command.
6563

6664
The following example shows you how to add an integration while using a personal access token.
6765

@@ -77,9 +75,9 @@ az containerapp github-action add \
7775
--registry-url <URL_TO_CONTAINER_REGISTRY> \
7876
--registry-username <REGISTRY_USER_NAME> \
7977
--registry-password <REGISTRY_PASSWORD> \
80-
--service-principal-client-id <CLIENT_ID> \
81-
--service-principal-client-secret <CLIENT_SECRET> \
82-
--service-principal-tenant-id <TENANT_ID> \
78+
--service-principal-client-id <appId> \
79+
--service-principal-client-secret <password> \
80+
--service-principal-tenant-id <tenant> \
8381
--token <YOUR_GITHUB_PERSONAL_ACCESS_TOKEN>
8482
```
8583

@@ -95,9 +93,9 @@ az containerapp github-action add `
9593
--registry-url <URL_TO_CONTAINER_REGISTRY> `
9694
--registry-username <REGISTRY_USER_NAME> `
9795
--registry-password <REGISTRY_PASSWORD> `
98-
--service-principal-client-id <CLIENT_ID> `
99-
--service-principal-client-secret <CLIENT_SECRET> `
100-
--service-principal-tenant-id <TENANT_ID> `
96+
--service-principal-client-id <appId> `
97+
--service-principal-client-secret <password> `
98+
--service-principal-tenant-id <tenant> `
10199
--token <YOUR_GITHUB_PERSONAL_ACCESS_TOKEN>
102100
```
103101

0 commit comments

Comments
 (0)