Merge pull request #279432 from dknappettmsft/charleskorb-patch-1

AVD update app attach PowerShell after parameters removed

Author: prmerger-automator[bot]

articles/virtual-desktop/app-attach-setup.md

@@ -207,13 +207,13 @@ Here's how to add an MSIX or Appx image as an app attach package using the [Az.D
    $app = Import-AzWvdAppAttachPackageInfo @parameters
    ```
 
-4. Check you only have one object in the application properties by running the following command:
+4. Check you only have one object in the application properties by running the following commands:
 
    ```azurepowershell
    $app | FL *
    ```
 
-   *Optional*: if you have more than one object in the output, for example an x64 and an x86 version of the same application, you can use the parameter `PackageFullName` to specify which application you want to add by running the following command:
+   *Optional*: if you have more than one object in the output, for example an x64 and an x86 version of the same application, you can use the parameter `PackageFullName` to specify which application you want to add by running the following commands:
 
    ```azurepowershell
    # Specify the package full name
@@ -247,7 +247,7 @@ Here's how to add an MSIX or Appx image as an app attach package using the [Az.D
 
    There's no output when the package is added successfully.
 
-6. You can verify the package is added by running the following command:
+6. You can verify the package is added by running the following commands:
 
    ```azurepowershell
    $parameters = @{
@@ -313,7 +313,7 @@ Here's how to assign an application package to host pools as well as groups and
 > [!IMPORTANT]
 > The host pool IDs you specify each time will overwrite any existing assignments. If you want to add or remove a host pool to or from an existing list of host pools, you need to specify all the host pools you want to assign the application to.
 
-1. In the same PowerShell session, get the resource IDs of the host pool(s) you want to assign the application to and add them to an array to by running the following command:
+1. In the same PowerShell session, get the resource IDs of the host pool(s) you want to assign the application to and add them to an array to by running the following commands:
 
    ```azurepowershell
    # Add a comma-separated list of host pools names
@@ -326,7 +326,7 @@ Here's how to assign an application package to host pools as well as groups and
    }
    ```
 
-1. Once you have the resource IDs of the host pool(s), you can assign the application package to them by running the following command:
+1. Once you have the resource IDs of the host pool(s), you can assign the application package to them by running the following commands:
 
    ```azurepowershell
    $parameters = @{
@@ -339,7 +339,7 @@ Here's how to assign an application package to host pools as well as groups and
    Update-AzWvdAppAttachPackage @parameters
    ```
 
-1. To unassign the application package from all host pools, you can pass an empty array of host pools by running the following command:
+1. To unassign the application package from all host pools, you can pass an empty array of host pools by running the following commands:
 
    ```azurepowershell
    $parameters = @{
@@ -358,7 +358,7 @@ Here's how to assign an application to groups and users using the [Az.DesktopVir
 
 1. Get the object ID of the groups or users you want to add to or remove from the application and add them to an array to by using one of the following examples. We recommend you assign applications to groups.
 
-   1. Get the object ID of the group or groups and add them to an array to by running the following command. This example uses the group display name:
+   1. Get the object ID of the group or groups and add them to an array to by running the following commands. This example uses the group display name:
 
       ```azurepowershell
       # Add a comma-separated list of group names
@@ -375,7 +375,7 @@ Here's how to assign an application to groups and users using the [Az.DesktopVir
       }
       ```
 
-   1. Get the object ID of the user(s) and add them to an array to by running the following command. This example uses the user principal name (UPN):
+   1. Get the object ID of the user(s) and add them to an array to by running the following commands. This example uses the user principal name (UPN):
 
       ```azurepowershell
       # Add a comma-separated list of user principal names
@@ -385,39 +385,43 @@ Here's how to assign an application to groups and users using the [Az.DesktopVir
       Connect-MgGraph -Scopes 'User.Read.All'
 
       # Create an array and add the ID for each user
-      $Ids = @()
+      $userIds = @()
 
       foreach ($user in $users) {
-          $Ids += (Get-MgUser | ? UserPrincipalName -eq $user).Id
+          $userIds += (Get-MgUser | ? UserPrincipalName -eq $user).Id
       }
       ```
 
-1. Once you have the object IDs of the users or groups, you can add them to or remove them from the application by using one of the following examples, which assigns the [Desktop Virtualization User](rbac.md#desktop-virtualization-user) RBAC role. You can also assign the Desktop Virtualization User RBAC role to your groups or users using the [New-AzRoleAssignment](../role-based-access-control/role-assignments-powershell.md) cmdlet.
+1. Once you have the object IDs of the users or groups, you can add them to or remove them from the application by using one of the following examples, which assigns the [Desktop Virtualization User](rbac.md#desktop-virtualization-user) RBAC role.
 
-   1. To add the groups or users to the application, run the following command:
+   1. To add the groups or users to the application, run the following commands:
       
       ```azurepowershell
       $parameters = @{
-          Name = '<AppName>'
-          ResourceGroupName = '<ResourceGroupName>'
-          Location = '<AzureRegion>'
-          PermissionsToAdd = $Ids
+         Name = '<AppName>'
+         ResourceGroupName = '<ResourceGroupName>'
+      }
+
+      $appAttachPackage = Get-AzWvdAppAttachPackage @parameters
+
+      foreach ($userId in $userIds) {
+         New-AzRoleAssignment -ObjectId $userId -RoleDefinitionName "Desktop Virtualization User" -Scope $appAttachPackage.Id
       }
-      
-      Update-AzWvdAppAttachPackage @parameters
       ```
 
-   1. To remove the groups or users to the application, run the following command:
+   1. To remove the groups or users to the application, run the following commands:
 
       ```azurepowershell
       $parameters = @{
-          Name = '<AppName>'
-          ResourceGroupName = '<ResourceGroupName>'
-          Location = '<AzureRegion>'
-          PermissionsToRemove = $objectIds
+         Name = '<AppName>'
+         ResourceGroupName = '<ResourceGroupName>'
+      }
+
+      $appAttachPackage = Get-AzWvdAppAttachPackage @parameters
+
+      foreach ($userId in $userIds) {
+         Remove-AzRoleAssignment -ObjectId $userId -RoleDefinitionName "Desktop Virtualization User" -Scope $appAttachPackage.Id
       }
-      
-      Update-AzWvdAppAttachPackage @parameters
       ```
 
 ---
@@ -451,8 +455,7 @@ Here's how to change a package's registration type and state using the [Az.Deskt
 
       ```azurepowershell
       $parameters = @{
-          FullName = '<FullName>'
-          HostPoolName = '<HostPoolName>'
+          Name = '<Name>'
           ResourceGroupName = '<ResourceGroupName>'
           Location = '<AzureRegion>'
           IsRegularRegistration = $true
@@ -466,7 +469,6 @@ Here's how to change a package's registration type and state using the [Az.Deskt
       ```azurepowershell
       $parameters = @{
           Name = '<Name>'
-          HostPoolName = '<HostPoolName>'
           ResourceGroupName = '<ResourceGroupName>'
           Location = '<AzureRegion>'
           IsActive = $true
@@ -516,7 +518,7 @@ Here's how to add an application from the package you added in this article to a
 
 Here's how to add an application from the package you added in this article to a RemoteApp application group using the [Az.DesktopVirtualization](/powershell/module/az.desktopvirtualization/) PowerShell module.
 
-1. In the same PowerShell session, if there are multiple applications in the package, you need to get the application ID of the application you want to add from the package by running the following command:
+1. In the same PowerShell session, if there are multiple applications in the package, you need to get the application ID of the application you want to add from the package by running the following commands:
 
    ```azurepowershell
    Write-Host "These are the application IDs available in the package. Many packages only contain one application." -ForegroundColor Yellow
@@ -539,7 +541,7 @@ Here's how to add an application from the package you added in this article to a
    New-AzWvdApplication @parameters
    ```
 
-1. Verify the list of applications in the application group by running the following command:
+1. Verify the list of applications in the application group by running the following commands:
 
    ```azurepowershell
    $parameters = @{
@@ -584,7 +586,7 @@ Here's how to update an existing package using the Azure portal:
 
 Here's how to update an existing package using the [Az.DesktopVirtualization](/powershell/module/az.desktopvirtualization/) PowerShell module.
 
-1. In the same PowerShell session, get the properties of the updated application and store them in a variable by running the following command:
+1. In the same PowerShell session, get the properties of the updated application and store them in a variable by running the following commands:
 
    ```azurepowershell
    # Get the properties of the application
@@ -597,13 +599,13 @@ Here's how to update an existing package using the [Az.DesktopVirtualization](/p
    $app = Import-AzWvdAppAttachPackageInfo @parameters
    ```
 
-1. Check you only have one object in the application properties by running the following command:
+1. Check you only have one object in the application properties by running the following commands:
 
    ```azurepowershell
    $app | FL *
    ```
 
-   If you have more than one object in the output, for example an x64 and an x86 version of the same application, you can use the parameter `PackageFullName` to specify which one you want to add by running the following command:
+   If you have more than one object in the output, for example an x64 and an x86 version of the same application, you can use the parameter `PackageFullName` to specify which one you want to add by running the following commands:
 
    ```azurepowershell
    # Specify the package full name
@@ -707,7 +709,7 @@ Here's how to add an MSIX package using the [Az.DesktopVirtualization](/powershe
 
 [!INCLUDE [include-cloud-shell-local-powershell](includes/include-cloud-shell-local-powershell.md)]
 
-2. Get the properties of the application in the MSIX image you want to add and store them in a variable by running the following command:
+2. Get the properties of the application in the MSIX image you want to add and store them in a variable by running the following commands:
 
    ```azurepowershell
    # Get the properties of the MSIX image
@@ -728,13 +730,13 @@ Here's how to add an MSIX package using the [Az.DesktopVirtualization](/powershe
    hp01/expandmsiximage
    ```
 
-3. Check you only have one object in the application properties by running the following command:
+3. Check you only have one object in the application properties by running the following commands:
 
    ```azurepowershell
    $app | FL *
    ```
 
-   If you have more than one object in the output, for example an x64 and an x86 version of the same application, you can use the parameter `PackageFullName` to specify which one you want to add by running the following command:
+   If you have more than one object in the output, for example an x64 and an x86 version of the same application, you can use the parameter `PackageFullName` to specify which one you want to add by running the following commands:
 
    ```azurepowershell
    # Specify the package full name
@@ -767,7 +769,7 @@ Here's how to add an MSIX package using the [Az.DesktopVirtualization](/powershe
 
    There's no output when the MSIX package is added successfully.
 
-5. You can verify the MSIX package is added by running the following command:
+5. You can verify the MSIX package is added by running the following commands:
 
    ```azurepowershell
    $parameters = @{
@@ -827,7 +829,7 @@ Here's how to change a package's registration type and state using the Azure por
 
 Here's how to change a package's registration type and state using the [Az.DesktopVirtualization](/powershell/module/az.desktopvirtualization/) PowerShell module.
 
-1. In the same PowerShell session, get a list of MSIX packages on a host pool and their current registration type and state by running the following command:
+1. In the same PowerShell session, get a list of MSIX packages on a host pool and their current registration type and state by running the following commands:
 
    ```azurepowershell
    $parameters = @{
@@ -945,7 +947,7 @@ Here's how to add MSIX applications to an application group using the [Az.Deskto
       New-AzWvdApplication @parameters
       ```
 
-   1. To add an MSIX application to a RemoteApp application group, if there are multiple applications in the package, you need to get the application ID of the application you want to add from the package by running the following command:
+   1. To add an MSIX application to a RemoteApp application group, if there are multiple applications in the package, you need to get the application ID of the application you want to add from the package by running the following commands:
 
       ```azurepowershell
       Write-Host "These are the application IDs available in the package. Many packages only contain one application." -ForegroundColor Yellow
@@ -968,7 +970,7 @@ Here's how to add MSIX applications to an application group using the [Az.Deskto
       New-AzWvdApplication @parameters
       ```
 
-      Verify the list of applications in the application group by running the following command:
+      Verify the list of applications in the application group by running the following commands:
 
       ```azurepowershell
       $parameters = @{
@@ -1002,7 +1004,7 @@ Here's how to remove an MSIX package from your host pool using the Azure portal:
 
 Here's how to remove applications using the [Az.DesktopVirtualization](/powershell/module/az.desktopvirtualization/) PowerShell module.
 
-1. In the same PowerShell session, get a list of MSIX packages on a host pool by running the following command:
+1. In the same PowerShell session, get a list of MSIX packages on a host pool by running the following commands:
 
    ```azurepowershell
    $parameters = @{
@@ -1021,7 +1023,7 @@ Here's how to remove applications using the [Az.DesktopVirtualization](/powershe
    My App      \\fileshare\Apps\MyApp\MyApp.cim hp01/MyApp_1.0.0.0_neutral__abcdef123ghij 1.0.0.0
    ```
 
-1. Find the package you want to remove and use the value for the `Name` parameter, but remove the **host pool name** and `/` from the start. For example, `hp01/MyApp_1.0.0.0_neutral__abcdef123ghij` becomes `MyApp_1.0.0.0_neutral__abcdef123ghij`. Then remove the package by running the following command:
+1. Find the package you want to remove and use the value for the `Name` parameter, but remove the **host pool name** and `/` from the start. For example, `hp01/MyApp_1.0.0.0_neutral__abcdef123ghij` becomes `MyApp_1.0.0.0_neutral__abcdef123ghij`. Then remove the package by running the following commands:
 
    ```azurepowershell
    $parameters = @{