Skip to content

Commit f4bbf10

Browse files
committed
remove unnecessary warning info and apply Craig's review suggestions
1 parent 0804cb0 commit f4bbf10

File tree

6 files changed

+5
-18
lines changed

6 files changed

+5
-18
lines changed

articles/container-apps/background-processing.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ az containerapp env create \
4242

4343
A Log Analytics workspace is required for the Container Apps environment. The following commands create a Log Analytics workspace and save the workspace ID and primary shared key to environment variables.
4444

45-
Note that the `Get-AzOperationalInsightsWorkspaceSharedKey` command may result in a warning message, however the command will still succeed.
4645

4746
```azurepowershell
4847
$WorkspaceArgs = @{
@@ -81,13 +80,13 @@ Begin by defining a name for the storage account. Storage account names must be
8180
# [Bash](#tab/bash)
8281

8382
```bash
84-
STORAGE_ACCOUNT_NAME="<storage account name>"
83+
STORAGE_ACCOUNT_NAME="<STORAGE_ACCOUNT_NAME>"
8584
```
8685

8786
# [Azure PowerShell](#tab/azure-powershell)
8887

8988
```azurepowershell
90-
$StorageAcctName = "<storage account name>"
89+
$StorageAcctName = "<StorageAccountName>"
9190
```
9291

9392
---

articles/container-apps/get-started-existing-container-image.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ az containerapp env create \
4444

4545
A Log Analytics workspace is required for the Container Apps environment. The following commands create a Log Analytics workspace and save the workspace ID and primary shared key to environment variables.
4646

47-
Note that the `Get-AzOperationalInsightsWorkspaceSharedKey` will result in a warning, but the command will still succeed.
48-
4947
```azurepowershell
5048
$WorkspaceArgs = @{
5149
Name = 'myworkspace'

articles/container-apps/microservices-dapr.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ az containerapp env create \
5757

5858
A Log Analytics workspace is required for the Container Apps environment. The following commands create a Log Analytics workspace and save the workspace ID and primary shared key to environment variables.
5959

60-
Note that the `Get-AzOperationalInsightsWorkspaceSharedKey` may result in a warning, but the command will still succeed.
6160

6261
```azurepowershell
6362
$WorkspaceArgs = @{
@@ -260,7 +259,7 @@ New-AzContainerAppManagedEnvDapr @DaprArgs
260259

261260
---
262261

263-
Your state store is configured using the Dapr component type state.azure.blobstorage. The component is scoped to a container app named `nodeapp` and isn't available to other container apps.
262+
Your state store is configured using the Dapr component type of `state.azure.blobstorage`. The component is scoped to a container app named `nodeapp` and isn't available to other container apps.
264263

265264
## Deploy the service application (HTTP web server)
266265

@@ -285,8 +284,8 @@ az containerapp create \
285284

286285
This command deploys:
287286

288-
* the service (Node) app server on `--target-port 3000` (the app port)
289-
* its accompanying Dapr sidecar configured with `--dapr-app-id nodeapp` and `--dapr-app-port 3000'` for service discovery and invocation
287+
* The service (Node) app server on `--target-port 3000` (the app port)
288+
* Its accompanying Dapr sidecar configured with `--dapr-app-id nodeapp` and `--dapr-app-port 3000'` for service discovery and invocation
290289

291290

292291
# [Azure PowerShell](#tab/azure-powershell)

articles/container-apps/vnet-custom-internal.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,6 @@ az network vnet subnet create \
9797

9898
# [Azure PowerShell](#tab/azure-powershell)
9999

100-
The `New-AzVirtualNetworkSubnetConfig` command may result in a warning, but the command will still be successful.
101-
102100
```azurepowershell
103101
$SubnetArgs = @{
104102
Name = 'infrastructure-subnet'

articles/container-apps/vnet-custom.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@ az network vnet subnet create \
100100

101101
# [Azure PowerShell](#tab/azure-powershell)
102102

103-
The `New-AzVirtualNetworkSubnetConfig` command may result in a warning, but the command will still be successful.
104-
105103
```azurepowershell
106104
$SubnetArgs = @{
107105
Name = 'infrastructure-subnet'
@@ -165,8 +163,6 @@ The following table describes the parameters used in `containerapp env create`.
165163

166164
A Log Analytics workspace is required for the Container Apps environment. The following commands create a Log Analytics workspace and save the workspace ID and primary shared key to environment variables.
167165

168-
Note that the `Get-AzOperationalInsightsWorkspaceSharedKey` command will result in a warning message. The command will still succeed.
169-
170166
```azurepowershell
171167
$WorkspaceArgs = @{
172168
Name = 'myworkspace'

includes/container-apps-create-cli-steps.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ Connect-AzAccount
2424

2525
---
2626

27-
28-
2927
# [Bash](#tab/bash)
3028

3129
Next, install the Azure Container Apps extension for the CLI.
@@ -69,7 +67,6 @@ Register-AzResourceProvider -ProviderNamespace Microsoft.App
6967

7068
---
7169

72-
7370
Register the `Microsoft.OperationalInsights` provider for the Azure Monitor Log Analytics workspace if you have not used it before.
7471

7572
# [Bash](#tab/bash)

0 commit comments

Comments
 (0)