review comments

Author: mrm9084

articles/azure-app-configuration/TOC.yml

@@ -158,15 +158,14 @@
         href: howto-targetingfilter.md
       - name: ASP.NET Core
         href: howto-targetingfilter-aspnet-core.md
-      - name: Python
-        href: use-variant-feature-flags-python.md
-    - name: Run experiments with variant feature flags
     - name: Use variant feature flags
       items:
       - name: Overview
         href: use-variant-feature-flags.md
       - name: ASP.NET Core
         href: use-variant-feature-flags-aspnet-core.md
+      - name: Python
+        href: use-variant-feature-flags-python.md
   - name: Enable Azure monitoring
     items:
     - name: Monitor App Configuration

articles/azure-app-configuration/index.yml

@@ -162,12 +162,10 @@ landingContent:
           url: howto-timewindow-filter.md
         - text: Roll out features to targeted audience
           url: howto-targetingfilter.md
-        - text: Use variant feature flags in Python
-          url: use-variant-feature-flags-python.md
-        - text: Run experiments with variant feature flags
-          url: run-experiments-aspnet-core.md
         - text: Use variant feature flags
           url: use-variant-feature-flags.md
+        - text: Use variant feature flags in Python
+          url: use-variant-feature-flags-python.md
       - linkListType: reference
         links:
         - text: .NET feature management

articles/azure-app-configuration/use-variant-feature-flags-python.md

@@ -1,17 +1,17 @@
 ---
-title: 'Tutorial: Use variant feature flags from Azure App Configuration in a Python application (preview)'
+title: 'Use variant feature flags application'
 titleSuffix: Azure App configuration
 description: In this tutorial, you learn how to use variant feature flags in an Python application
 #customerintent: As a user of Azure App Configuration, I want to learn how I can use variants and variant feature flags in my python application.
 author: mrm9084
 ms.author: mametcal
 ms.service: azure-app-configuration
 ms.devlang: python
-ms.topic: tutorial
+ms.topic: how-to
 ms.date: 12/02/2024
 ---
 
-# Tutorial: Use variant feature flags in Azure App Configuration (preview)
+# Tutorial: Use variant feature flags in Azure App Configuration
 
 In this tutorial, you use a variant feature flag to manage experiences for different user segments in an example application, *Quote of the Day*. You utilize the variant feature flag created in [Use variant feature flags](./use-variant-feature-flags.md). Before proceeding, ensure you create the variant feature flag named *Greeting* in your App Configuration store.
 
@@ -36,25 +36,19 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     .\venv\Scripts\Activate
     ```
 
-1. Install the required packages. The latest preview versions of `azure-appconfiguration-provider`, and `featuremanagement` are required for variant feature flags (preview).
+1. Install the required packages. The latest preview versions of `azure-appconfiguration-provider`, and `featuremanagement` are required for variant feature flags.
 
     ```bash
     pip install flask azure-appconfiguration-provider==2.0.0b3 azure-identity featuremanagement[AzureMonitor]==2.0.0b3 flask-login flask_sqlalchemy flask_bcrypt
     ```
 
-1. Create a new file named *app.py* in the *QuoteOfTheDay* folder.
-
-    ### [Microsoft Entra ID (recommended)](#tab/entra-id)
-    You use the `DefaultAzureCredential` to authenticate to your App Configuration store. Follow the [instructions](./concept-enable-rbac.md#authentication-with-token-credentials) to assign your credential the **App Configuration Data Reader** role. Be sure to allow sufficient time for the permission to propagate before running your application.
+1. Create a new file named *app.py* in the *QuoteOfTheDay* folder. You use the `DefaultAzureCredential` to authenticate to your App Configuration store. Follow the [instructions](./concept-enable-rbac.md#authentication-with-token-credentials) to assign your credential the **App Configuration Data Reader** role. Be sure to allow sufficient time for the permission to propagate before running your application.
 
     ```python
     import os
     from azure.appconfiguration.provider import load
     from featuremanagement import FeatureManager
-    from featuremanagement.azuremonitor import publish_telemetry
     from azure.identity import DefaultAzureCredential
-    from opentelemetry import trace
-    from opentelemetry.trace import get_tracer_provider
     from flask_bcrypt import Bcrypt
     
     from flask_sqlalchemy import SQLAlchemy
@@ -65,8 +59,6 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     app = Flask(__name__, template_folder="../templates", static_folder="../static")
     bcrypt = Bcrypt(app)
     
-    tracer = trace.get_tracer(__name__, tracer_provider=get_tracer_provider())
-    
     ENDPOINT = os.getenv("AzureAppConfigurationEndpoint")
     
     def callback():
@@ -81,15 +73,14 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
         feature_flag_refresh_enabled=True,
     )
     app.config.update(azure_app_config)
-    feature_manager = FeatureManager(azure_app_config, on_feature_evaluated=publish_telemetry)
+    feature_manager = FeatureManager(azure_app_config)
     
     db = SQLAlchemy()
     db.init_app(app)
     
     login_manager = LoginManager()
     login_manager.init_app(app)
     
-    
     from .model import Users
     
     @login_manager.user_loader
@@ -105,77 +96,19 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     from . import routes
     app.register_blueprint(routes.bp)
     ```
-    ### [Connection string](#tab/connection-string)
-    ```python
-    import os
-    from azure.appconfiguration.provider import load
-    from featuremanagement import FeatureManager
-    from featuremanagement.azuremonitor import publish_telemetry
-    from opentelemetry import trace
-    from opentelemetry.trace import get_tracer_provider
-    from flask_bcrypt import Bcrypt
-    
-    from flask_sqlalchemy import SQLAlchemy
-    from flask_login import LoginManager
-    
-    from flask import Flask
-    
-    app = Flask(__name__, template_folder="../templates", static_folder="../static")
-    bcrypt = Bcrypt(app)
-    
-    tracer = trace.get_tracer(__name__, tracer_provider=get_tracer_provider())
-    
-    def callback():
-        app.config.update(azure_app_config)
-    
-    global azure_app_config
-    azure_app_config = load(
-        connection_string=os.getenv("AzureAppConfigurationConnectionString"),
-        on_refresh_success=callback,
-        feature_flag_enabled=True,
-        feature_flag_refresh_enabled=True,
-    )
-    app.config.update(azure_app_config)
-    feature_manager = FeatureManager(azure_app_config, on_feature_evaluated=publish_telemetry)
-    
-    db = SQLAlchemy()
-    db.init_app(app)
-    
-    login_manager = LoginManager()
-    login_manager.init_app(app)
-    
-    
-    from .model import Users
-    
-    @login_manager.user_loader
-    def loader_user(user_id):
-        return Users.query.get(user_id)
-    
-    with app.app_context():
-        db.create_all()
-    
-    if __name__ == "__main__":
-        app.run(debug=True)
-    
-    from . import routes
-    app.register_blueprint(routes.bp)
-    ```
-    ---
+
 1. Create a new file called *model.py* in the *QuoteOfTheDay* folder.
 
     ```python
     from dataclasses import dataclass
     from flask_login import UserMixin
     from . import db
-    
-    
-    
+
     @dataclass
     class Quote:
         message: str
         author: str
     
-    
     # Create user model
     class Users(UserMixin, db.Model):
     
@@ -234,18 +167,6 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     
         return render_template("index.html", **context)
     
-    @bp.route("/privacy", methods=["GET"])
-    def privacy():
-        context = {}
-        user = ""
-        if current_user.is_authenticated:
-            user = current_user.username
-            context["user"] = user
-        else:
-            context["user"] = "Guest"
-        context["isAuthenticated"] = current_user.is_authenticated
-        return render_template("privacy.html", **context)
-    
     @bp.route("/register", methods=["GET", "POST"])
     def register():
         if request.method == "POST":
@@ -274,7 +195,6 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
                 return redirect(url_for("pages.index"))
         return render_template("login.html")
     
-    
     @bp.route("/logout")
     def logout():
         logout_user()
@@ -358,9 +278,6 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
                             <li class="nav-item">
                                 <a class="nav-link text-dark" href="/">Home</a>
                             </li>
-                            <li class="nav-item">
-                                <a class="nav-link text-dark" href="/privacy">Privacy</a>
-                            </li>
                         </ul>
                         {% block login_partial %}
                         <ul class="navbar-nav">
@@ -395,7 +312,7 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     
     <footer class="border-top footer text-muted">
         <div class="container">
-            &copy; 2024 - QuoteOfTheDay - <a href="/privacy">Privacy</a>
+            &copy; 2024 - QuoteOfTheDay
         </div>
     </footer>
     
@@ -443,21 +360,11 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     {% endblock %}
     ```
 
-1. Create a new file named *privacy.html* in the *templates* folder.
-
-    ```html
-    {% extends 'base.html' %}
-    
-    {% block content %}
-    <p>Use this page to detail your site's privacy policy.</p>
-    {% endblock %}
-    ```
-
 1. Create a new folder named *static* in the *QuoteOfTheDay* folder.
 
 1. Create a new folder named *css* in the *static* folder.
 
-1. Create a new file named *site.css* in the *static* folder.
+1. Create a new file named *site.css* in the *css* folder.
 
     ```css
     html {
@@ -549,12 +456,9 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     }
     ```
 
-### Build and run the app (preview)
-
-1. Set an environment variable.
+### Build and run the app
 
-    ### [Microsoft Entra ID (recommended)](#tab/entra-id)
-    Set the environment variable named **Endpoint** to the endpoint of your App Configuration store found under the *Overview* of your store in the Azure portal.
+1. Set an environment variable. Set the environment variable named **Endpoint** to the endpoint of your App Configuration store found under the *Overview* of your store in the Azure portal.
 
     If you use the Windows command prompt, run the following command and restart the command prompt to allow the change to take effect:
 
@@ -574,28 +478,6 @@ In this tutorial, you use a variant feature flag to manage experiences for diffe
     export AzureAppConfigurationEndpoint='endpoint-of-your-app-configuration-store'
     ```
 
-    ### [Connection string](#tab/connection-string)
-    Set the environment variable named **ConnectionString** to the read-only connection string of your App Configuration store found under *Access keys* of your store in the Azure portal.
-
-    If you use the Windows command prompt, run the following command and restart the command prompt to allow the change to take effect:
-
-    ```cmd
-    setx AzureAppConfigurationConnectionString "connection-string-of-your-app-configuration-store"
-    ```
-
-   If you use PowerShell, run the following command:
-
-    ```powershell
-    $Env:AzureAppConfigurationConnectionString = "connection-string-of-your-app-configuration-store"
-    ```
-
-    If you use macOS or Linux, run the following command:
-
-    ```bash
-    export AzureAppConfigurationConnectionString='connection-string-of-your-app-configuration-store'
-    ```
-    ---
-
 1. In the command prompt, in the *QuoteOfTheDay* folder, run: `flask run`.
 1. Wait for the app to start, and then open a browser and navigate to `http://localhost:5000/`.
 1. Once viewing the running application, select **Register** at the top right to register a new user.