Skip to content

Commit f955fa1

Browse files
committed
Address reviewer feedback
1 parent 63a8f82 commit f955fa1

19 files changed

+198
-186
lines changed

articles/cloud-shell/TOC.yml

Lines changed: 58 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,61 @@
1-
- name: Overview
2-
href: overview.md
3-
- name: Quickstart
4-
items:
5-
- name: Bash - Quickstart
6-
href: quickstart.md
7-
- name: PowerShell - Quickstart
8-
href: quickstart-powershell.md
9-
- name: Features & tools
10-
href: features.md
11-
- name: Tutorials
12-
items:
13-
- name: Ansible
1+
items:
2+
- name: Overview
3+
href: overview.md
4+
- name: Quickstart
145
items:
15-
- name: Run Ansible playbook
16-
href: /azure/developer/ansible/getting-started-cloud-shell?bc=%2Fazure%2Fbread%2Ftoc.json&toc=%2Fazure%2Fcloud-shell%2Ftoc.json&tabs=azure-powershell
17-
- name: Manage your Azure dynamic inventories
18-
href: /azure/developer/ansible/dynamic-inventory-configure?bc=%2Fazure%2Fbread%2Ftoc.json&toc=%2Fazure%2Fcloud-shell%2Ftoc.json&tabs=azure-powershell
19-
- name: Terraform
6+
- name: Bash - Quickstart
7+
href: quickstart.md
8+
- name: PowerShell - Quickstart
9+
href: quickstart-powershell.md
10+
- name: Features & tools
11+
href: features.md
12+
- name: Tutorials
2013
items:
21-
- name: Install and configure Terraform
22-
href: /azure/developer/terraform/quickstart-configure?bc=%2fazure%2fbread%2ftoc.json&toc=%2fazure%2fcloud-shell%2ftoc.json
23-
- name: Concepts
24-
items:
25-
- name: Security
14+
- name: Ansible
15+
items:
16+
- name: Run Ansible playbook
17+
href: /azure/developer/ansible/getting-started-cloud-shell?bc=%2Fazure%2Fbread%2Ftoc.json&toc=%2Fazure%2Fcloud-shell%2Ftoc.json&tabs=azure-powershell
18+
- name: Manage your Azure dynamic inventories
19+
href: /azure/developer/ansible/dynamic-inventory-configure?bc=%2Fazure%2Fbread%2Ftoc.json&toc=%2Fazure%2Fcloud-shell%2Ftoc.json&tabs=azure-powershell
20+
- name: Terraform
21+
items:
22+
- name: Install and configure Terraform
23+
href: /azure/developer/terraform/quickstart-configure?bc=%2fazure%2fbread%2ftoc.json&toc=%2fazure%2fcloud-shell%2ftoc.json
24+
- name: Concepts
2625
items:
27-
- name: Security baseline
28-
href: /security/benchmark/azure/baselines/cloud-shell-security-baseline?bc=%2fazure%2fbread%2ftoc.json&toc=%2fazure%2fcloud-shell%2ftoc.json
29-
- name: How-to guides
30-
items:
31-
- name: Persist files in storage
32-
href: persisting-shell-storage.md
33-
- name: Use the window
34-
href: using-the-shell-window.md
35-
- name: Use MSI in Cloud Shell
36-
href: msi-authorization.md
37-
- name: Embed Cloud Shell
38-
href: embed-cloud-shell.md
39-
- name: Cloud Shell in Azure Virtual Network
40-
href: private-vnet.md
41-
- name: Use the Cloud Shell editor
42-
href: using-cloud-shell-editor.md
43-
- name: Troubleshooting & limitations
44-
href: troubleshooting.md
45-
- name: Reference
46-
items:
47-
- name: Azure CLI
48-
href: /cli/azure/
49-
- name: Azure PowerShell
50-
href: /powershell/azure/
51-
- name: Resources
52-
items:
53-
- name: Azure Roadmap
54-
href: https://azure.microsoft.com/roadmap/?category=monitoring-management
55-
- name: Pricing calculator
56-
href: https://azure.microsoft.com/pricing/calculator/
26+
- name: Security
27+
items:
28+
- name: Security baseline
29+
href: /security/benchmark/azure/baselines/cloud-shell-security-baseline?bc=%2fazure%2fbread%2ftoc.json&toc=%2fazure%2fcloud-shell%2ftoc.json
30+
- name: How-to guides
31+
items:
32+
- name: Persist files in storage
33+
href: persisting-shell-storage.md
34+
- name: Use the window
35+
href: using-the-shell-window.md
36+
- name: Use MSI in Cloud Shell
37+
href: msi-authorization.md
38+
- name: Embed Cloud Shell
39+
href: embed-cloud-shell.md
40+
- name: Cloud Shell in an Azure virtual network
41+
href: private-vnet.md
42+
- name: Use the Cloud Shell editor
43+
href: using-cloud-shell-editor.md
44+
- name: Troubleshooting
45+
href: troubleshooting.md
46+
- name: Limitations
47+
href: limitations.md
48+
- name: Pricing
49+
href: pricing.md
50+
- name: Reference
51+
items:
52+
- name: Azure CLI
53+
href: /cli/azure/
54+
- name: Azure PowerShell
55+
href: /powershell/azure/
56+
- name: Resources
57+
items:
58+
- name: Azure Roadmap
59+
href: https://azure.microsoft.com/roadmap/?category=monitoring-management
60+
- name: Pricing calculator
61+
href: https://azure.microsoft.com/pricing/calculator/

articles/cloud-shell/embed-cloud-shell.md

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,34 @@ title: Embed Azure Cloud Shell
1616
# Embed Azure Cloud Shell
1717

1818
Embedding Cloud Shell enables developers and content writers to directly open Cloud Shell from a
19-
dedicated URL, `shell.azure.com`. This immediately brings the full power of Cloud Shell's
20-
authentication, tooling, and up-to-date Azure CLI and Azure PowerShell tools to your users.
19+
dedicated URL, `shell.azure.com`. This link brings the full power of Cloud Shell's authentication,
20+
tooling, and up-to-date Azure CLI and Azure PowerShell tools to your users.
2121

22-
[![Regular launch](media/embed-cloud-shell/LaunchCloudShell.png "Launch Azure Cloud Shell")][01]
22+
You can use the following images in your own webpages and app as buttons to start a Cloud Shell
23+
session.
24+
25+
Regular sized button
26+
27+
![Regular launch](media/embed-cloud-shell/launch-cloud-shell-1.png "Launch Azure Cloud Shell")
2328

2429
Large sized button
2530

26-
[![Large launch](media/embed-cloud-shell/LaunchCloudShell2x.png "Launch Azure Cloud Shell")][01]
31+
![Large launch](media/embed-cloud-shell/launch-cloud-shell-2.png "Launch Azure Cloud Shell")
2732

2833
## How-to
2934

30-
Integrate Cloud Shell's launch button into markdown files by copying the following:
35+
To integrate Cloud Shell's launch button into markdown files by copying the following code:
3136

3237
Regular sized button
3338

3439
```markdown
35-
[![Launch Cloud Shell](https://learn.microsoft.com/azure/cloud-shell/media/embed-cloudshell/launchcloudshell.png](https://shell.azure.com)
40+
[![Launch Cloud Shell](https://learn.microsoft.com/azure/cloud-shell/media/embed-cloud-shell/launch-cloud-shell-1.png](https://shell.azure.com)
3641
```
3742

3843
Large sized button
3944

4045
```markdown
41-
[![Launch Cloud Shell](https://learn.microsoft.com/azure/cloud-shell/media/embed-cloudshelllaunchcloudshell@2x.png](https://shell.azure.com)
46+
[![Launch Cloud Shell](https://learn.microsoft.com/azure/cloud-shell/media/embed-cloud-shell/launch-cloud-shell-2.png](https://shell.azure.com)
4247
```
4348

4449
The location of these image files is subject to change. We recommend that you download the files for
@@ -48,11 +53,11 @@ use in your applications.
4853

4954
Set a specific shell experience by augmenting your URL.
5055

51-
| Experience | URL |
52-
| ------------------------ | ---------------------------- |
53-
| Most recently used shell | `shell.azure.com` |
54-
| Bash | `shell.azure.com/bash` |
55-
| PowerShell | `shell.azure.com/powershell` |
56+
| Experience | URL |
57+
| ------------------------ | ------------------------------------ |
58+
| Most recently used shell | `https://shell.azure.com` |
59+
| Bash | `https://shell.azure.com/bash` |
60+
| PowerShell | `https://shell.azure.com/powershell` |
5661

5762
## Next steps
5863

articles/cloud-shell/features.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Azure Cloud Shell is a browser-based shell experience to manage and develop Azur
2020
Cloud Shell offers a browser-accessible, pre-configured shell experience for managing Azure
2121
resources without the overhead of installing, versioning, and maintaining a machine yourself.
2222

23-
Cloud Shell provisions machines on a per-request basis and as a result machine state does not
23+
Cloud Shell allocates machines on a per-request basis and as a result machine state doesn't
2424
persist across sessions. Since Cloud Shell is built for interactive sessions, shells automatically
2525
terminate after 20 minutes of shell inactivity.
2626

@@ -35,8 +35,8 @@ distribution for cloud-infrastructure-edge products and services.
3535
Microsoft internally compiles all the packages included in the **CBL-Mariner** repository to help
3636
guard against supply chain attacks. Tooling has been updated to reflect the new base image
3737
CBL-Mariner. You can get a full list of installed package versions using the following command:
38-
`tdnf list installed`. If these changes affected your Cloud Shell environment, please contact
39-
Azuresupport or create an issue in the [Cloud Shell repository][12].
38+
`tdnf list installed`. If these changes affected your Cloud Shell environment, contact Azure Support
39+
or create an issue in the [Cloud Shell repository][12].
4040

4141
## Features
4242

@@ -51,8 +51,8 @@ To persist files across sessions, Cloud Shell walks you through attaching an Azu
5151
first launch. Once completed, Cloud Shell will automatically attach your storage (mounted as
5252
`$HOME\clouddrive`) for all future sessions. Additionally, your `$HOME` directory is persisted as an
5353
.img in your Azure File share. Files outside of `$HOME` and machine state aren't persisted across
54-
sessions. Use best practices when storing secrets such as SSH keys. Services like
55-
[Azure Key Vault have tutorials for setup][02].
54+
sessions. Use best practices when storing secrets such as SSH keys. Services, like
55+
Azure Key Vault, have [tutorials for setup][02].
5656

5757
[Learn more about persisting files in Cloud Shell.][29]
5858

articles/cloud-shell/limitations.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Chrome, Mozilla Firefox, and Apple Safari. Safari in private mode isn't supporte
4646
- Windows: <kbd>Ctrl</kbd>-<kbd>C</kbd> to copy is supported but use
4747
<kbd>Shift</kbd>-<kbd>Insert</kbd> to paste.
4848
- FireFox/IE may not support clipboard permissions properly.
49-
- Mac OS: <kbd>Cmd</kbd>-<kbd>C</kbd> to copy and <kbd>Cmd</kbd>-<kbd>V</kbd> to paste.
49+
- macOS: <kbd>Cmd</kbd>-<kbd>C</kbd> to copy and <kbd>Cmd</kbd>-<kbd>V</kbd> to paste.
5050

5151
### Only one shell can be active for a given user
5252

@@ -83,19 +83,18 @@ functionality.
8383
The `SqlServer` module included in Cloud Shell has only prerelease support for PowerShell Core. In
8484
particular, `Invoke-SqlCmd` isn't available yet.
8585

86-
### Default file location when created from Azure drive:
86+
### Default file location when created from Azure drive
8787

88-
Using PowerShell cmdlets, users can not create files under the Azure: drive. When users create new
89-
files using other tools, such as vim or nano, the files are saved to the `$HOME` by default.
88+
You can't create files under the `Azure:` drive. When users create new files using other tools, such
89+
as vim or nano, the files are saved to the `$HOME` by default.
9090

9191
### GUI applications aren't supported
9292

93-
If the user runs a command that would create a Windows dialog box, one sees an error message such
93+
If the user runs a command that would create a dialog box, one sees an error message such
9494
as:
9595

96-
```
97-
Unable to load DLL 'IEFRAME.dll': The specified module couldn't be found. (Exception from HRESULT: 0x8007007E)
98-
```
96+
> Unable to load DLL 'IEFRAME.dll': The specified module couldn't be found.
97+
9998

10099
### Large Gap after displaying progress bar
101100

articles/cloud-shell/media/embed-cloud-shell/LaunchCloudShell.png renamed to articles/cloud-shell/media/embed-cloud-shell/launch-cloud-shell-1.png

File renamed without changes.

articles/cloud-shell/media/embed-cloud-shell/LaunchCloudShell2x.png renamed to articles/cloud-shell/media/embed-cloud-shell/launch-cloud-shell-2.png

File renamed without changes.

articles/cloud-shell/media/features-powershell/azure-drive.PNG renamed to articles/cloud-shell/media/features-powershell/azure-drive.png

File renamed without changes.

articles/cloud-shell/media/persisting-shell-storage-powershell/Dismount-Clouddrive.PNG renamed to articles/cloud-shell/media/persisting-shell-storage-powershell/dismount-clouddrive.png

File renamed without changes.

articles/cloud-shell/media/persisting-shell-storage-powershell/Get-Clouddrive.PNG renamed to articles/cloud-shell/media/persisting-shell-storage-powershell/get-clouddrive.png

File renamed without changes.

articles/cloud-shell/msi-authorization.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,14 @@ curl https://management.azure.com/subscriptions/{subscriptionId}/providers/Micro
5656

5757
## Handling token expiration
5858

59-
The local authentication endpoint caches tokens. You can call it as often as you like, and an
60-
authentication call to Azure Active Directory only occurs if there's no token stored in the cache,
61-
or the token has expired.
59+
The local authentication endpoint caches tokens. You can call it as often as you like. Cloud Shell
60+
only calls Azure Active Directory only occurs when there's no token stored in the cache or the token
61+
has expired.
6262

6363
## Limitations
6464

65-
- There's an allowlist of resources that Cloud Shell tokens can be provided for. You may see a
66-
message similar to the following:
65+
- There's an allowlist of resources that Cloud Shell tokens can be provided for. When you try to use
66+
a token with a service that is not listed, you may see the following error message:
6767

6868
```
6969
"error":{"code":"AudienceNotSupported","message":"Audience https://newservice.azure.com/
@@ -72,7 +72,7 @@ or the token has expired.
7272

7373
You can open an issue on [GitHub][02] to request for the service to be added to the allowlist.
7474

75-
- If you log in explicitly using the `az login` command, any Conditional Access rules your company
75+
- If you sign in explicitly using the `az login` command, any Conditional Access rules your company
7676
may have in place are evaluated based on the Cloud Shell container rather than the machine where
7777
your browser runs. The Cloud Shell container doesn't count as a managed device for these policies
7878
so rights may be limited by the policy.

0 commit comments

Comments
 (0)