Merge pull request #1 from mbender-ms/welasco-mbender-review

Acrolinx fixes

Author: Welasco

articles/load-balancer/upgrade-basic-standard-vmss.md

@@ -16,30 +16,30 @@ This article introduces a PowerShell module that creates a Standard Load Balance
 
 ## Upgrade Overview
 
-An Azure PowerShell module is available to upgrade from Basic load balancer to a Standard load balancer along with moving the associated Virtual Machine Scale set (VMSS). The PowerShell module performs the following functions:
+An Azure PowerShell module is available to upgrade from Basic load balancer to a Standard load balancer along with moving the associated virtual machine scale set. The PowerShell module performs the following functions:
 
 - Verifies that the provided Basic load balancer scenario is supported for upgrade.
-- Backs up the Basic load balancer and Virtual Machine Scale set (VMSS) configuration, enabling retry on failure or if errors are encountered.
+- Backs up the Basic load balancer and virtual machine scale set  configuration, enabling retry on failure or if errors are encountered.
 - For public load balancers, updates the front end public IP address(es) to Standard SKU and static assignment as required.
 - Upgrade the Basic load balancer configuration to a new Standard load balancer, ensuring configuration and feature parity.
-- Upgrade VMSS backend pool members from the Basic load balancer to the standard load balancer.
-- Creates and associates a NSG with the VMSS to ensure load balanced traffic reaches backend pool members, following Standard load balancer's move to a default-deny network policy.
+- Upgrade virtual machine scale set backend pool members from the Basic load balancer to the standard load balancer.
+- Creates and associates a network security group with the virtual machine scale set to ensure load balanced traffic reaches backend pool members, following Standard load balancer's move to a default-deny network policy.
 - Logs the upgrade operation for easy audit and failure recovery.
 
 ### Unsupported Scenarios
 
-- Basic load balancers with a VMSS backend pool member which is also a member of a backend pool on a different load balancer
-- Basic load balancers with backend pool members which are not a VMSS
+- Basic load balancers with a virtual machine scale set backend pool member that is also a member of a backend pool on a different load balancer
+- Basic load balancers with backend pool members that aren't a virtual machine scale set
 - Basic load balancers with only empty backend pools
 - Basic load balancers with IPV6 frontend IP configurations
-- Basic load balancers with a VMSS backend pool member configured with 'Flexible' orchestration mode
-- Basic load balancers with a VMSS backend pool member where one or more VMSS instances have ProtectFromScaleSetActions Instance Protection policies enabled
+- Basic load balancers with a virtual machine scale set backend pool member configured with 'Flexible' orchestration mode
+- Basic load balancers with a virtual machine scale set backend pool member where one or more virtual machine scale set instances have ProtectFromScaleSetActions Instance Protection policies enabled
 - Migrating a Basic load balancer to an existing Standard load balancer
 
 ### Prerequisites
 
-- Install the latest version of [PowerShell Desktop or Core ](/powershell/scripting/install/installing-powershell)
-- Determine whether you have the latest Az module installed (8.2.0)
+- Install the latest version of [PowerShell](/powershell/scripting/install/installing-powershell)
+- Determine whether you have the latest Az PowerShell module installed (8.2.0)
   - Install the latest Az PowerShell module](/powershell/azure/install-az-ps)
 
 ## Install the 'AzureBasicLoadBalancerUpgrade' module
@@ -65,7 +65,7 @@ PS C:\> Install-Module -Name AzureBasicLoadBalancerUpgrade -Scope CurrentUser -R
     - *ResourceGroupName [string] Required* - This parameter is the name of the resource group containing the Basic load balancer
     - *RecoveryBackupPath [string] Optional* - This parameter allows you to specify an alternative path in which to store the Basic load balancer ARM template backup file (defaults to the current working directory)
     - *FailedMigrationRetryFilePathLB [string] Optional* - This parameter allows you to specify a path to a Basic load balancer backup state file when retrying a failed upgrade (defaults to current working directory)
-    - *FailedMigrationRetryFilePathVMSS [string] Optional* - This parameter allows you to specify a path to a Virtual Machine Scale set (VMSS) backup state file when retrying a failed upgrade (defaults to current working directory)
+    - *FailedMigrationRetryFilePathVMSS [string] Optional* - This parameter allows you to specify a path to a virtual machine scale set (virtual machine scale set) backup state file when retrying a failed upgrade (defaults to current working directory)
 
 4. Run the Upgrade command.
 
@@ -93,7 +93,7 @@ PS C:\> Start-AzBasicLoadBalancerUpgrade -ResourceGroupName <load balancer resou
 PS C:\> Start-AzBasicLoadBalancerUpgrade -ResourceGroupName <load balancer resource group name> -BasicLoadBalancerName <existing basic load balancer name> -StandardLoadBalancerName <new standard load balancer name> -RecoveryBackupPath C:\BasicLBRecovery
 ```
 
-### Example: retry a failed upgrade (due to error or script termination) by providing the Basic load balancer and VMSS backup state file
+### Example: retry a failed upgrade (due to error or script termination) by providing the Basic load balancer and virtual machine scale set backup state file
 
 ```powerhsell
 PS C:\> Start-AzBasicLoadBalancerUpgrade -FailedMigrationRetryFilePathLB C:\RecoveryBackups\State_mybasiclb_rg-basiclbrg_20220912T1740032148.json -FailedMigrationRetryFilePathVMSS C:\RecoveryBackups\VMSS_myVMSS_rg-basiclbrg_20220912T1740032148.json
@@ -103,11 +103,15 @@ PS C:\> Start-AzBasicLoadBalancerUpgrade -FailedMigrationRetryFilePathLB C:\Reco
 
 ### Will the module migrate my frontend IP address to the new Standard load balancer?
 
-Yes, for both public and internal load balancers, the module ensures that front end IP addresses are maintained. For public IPs, the IP is converted to a static IP prior to migration (if necessary). For internal front ends, the module will attempt to reassign the same IP address freed up when the Basic load balancer was deleted; if the private IP is not available the script will fail. In this scenario, remove the virtual network connected device which has claimed the intended front end IP and rerun the module with the `-FailedMigrationRetryFilePathLB <BasicLoadBalancerbackupFilePath> -FailedMigrationRetryFilePathVMSS <VMSSBackupFile>` parameters specified.
+Yes, for both public and internal load balancers, the module ensures that front end IP addresses are maintained. For public IPs, the IP is converted to a static IP prior to migration (if necessary). For internal front ends, the module will attempt to reassign the same IP address freed up when the Basic load balancer was deleted; if the private IP isn't available the script will fail. In this scenario, remove the virtual network connected device that has claimed the intended front end IP and rerun the module with the `-FailedMigrationRetryFilePathLB <BasicLoadBalancerbackupFilePath> -FailedMigrationRetryFilePathVMSS <VMSSBackupFile>` parameters specified.
 
 ### How long does the Upgrade take?
 
-It usually takes a few minutes for the script to finish and it could take longer depending on the complexity of your load balancer configuration, number of backend pool members, and instance count of associated Virtual Machine Scale Sets. Keep the downtime in mind and plan for failover if necessary.
+The upgrade normally takes a few minutes for the script to finish. The following factors may lead to longer upgrade times:
+- Complexity of your load balancer configuration
+- Number of backend pool members
+- Instance count of associated Virtual Machine Scale Sets. 
+Keep the downtime in mind and plan for failover if necessary.
 
 ### Does the script migrate my backend pool members from my basic load balancer to the newly created standard load balancer?
 
@@ -130,13 +134,13 @@ The script migrates the following from the Basic load balancer to the Standard l
 - Inbound NAT Rules:
   - All NAT rules will be migrated to the new Standard load balancer
 - Outbound Rules:
-  - Basic load balancers do not support configured outbound rules. The script will create an outbound rule in the Standard load balancer to preserve the outbound behavior of the Basic load balancer. For more information about Outbound connectivity, see [Outbound-only load balancer configuration](/azure/load-balancer/egress-only).
-- Network Security Group
-  - Basic load balancer doesn't required a Network Security Group to allow outbound connectivity. In case there is no Network Security Group associated with the VMSS, a new NSG will be created to preserve the same functionality. This new NSG will be associated to the VMSS backend pool member network interfaces and allow the same load balancing rules ports and protocols and preserve the outbound connectivity.
+  - Basic load balancers don't support configured outbound rules. The script will create an outbound rule in the Standard load balancer to preserve the outbound behavior of the Basic load balancer. For more information about Outbound connectivity, see [Outbound-only load balancer configuration](/azure/load-balancer/egress-only).
+- Network security group
+  - Basic load balancer doesn't require a network security group to allow outbound connectivity. In case there's no network security group associated with the virtual machine scale set, a new network security group will be created to preserve the same functionality. This new network security group will be associated to the virtual machine scale set backend pool member network interfaces. It will allow the same load balancing rules ports and protocols and preserve the outbound connectivity.
 - Backend pools:
   - All backend pools will be migrated to the new Standard load balancer
-  - All VMSS network interfaces and IP configurations will be migrated to the new Standard load balancer
-  - In case of VMSS using Rolling Upgrade policy, the script will update the VMSS upgrade policy to "Manual" during the migration process and revert it back to "Rolling" after the migration is completed.
+  - All virtual machine scale set network interfaces and IP configurations will be migrated to the new Standard load balancer
+  - If a virtual machine scale set is using Rolling Upgrade policy, the script will update the virtual machine scale set upgrade policy to "Manual" during the migration process and revert it back to "Rolling" after the migration is completed.
 
 **Private Load Balancer:**
 
@@ -151,15 +155,15 @@ The script migrates the following from the Basic load balancer to the Standard l
   - All NAT rules will be migrated to the new Standard load balancer
 - Backend pools:
   - All backend pools will be migrated to the new Standard load balancer
-  - All VMSS network interfaces and IP configurations will be migrated to the new Standard load balancer
-  - In case of VMSS using Rolling Upgrade policy, the script will update the VMSS upgrade policy to "Manual" during the migration process and revert it back to "Rolling" after the migration is completed.
+  - All virtual machine scale set network interfaces and IP configurations will be migrated to the new Standard load balancer
+  - If there's a virtual machine scale set using Rolling Upgrade policy, the script will update the virtual machine scale set upgrade policy to "Manual" during the migration process and revert it back to "Rolling" after the migration is completed.
 
 ### What happens if my upgrade fails mid-migration?
 
-The module is designed to accommodate failures, either due to unhandled errors or unexpected script termination. The failure design is a 'fail forward' approach, where instead of attempting to move back to the Basic load balancer, you should correct the issue causing the failure (see the error output or log file), and retry the migration again, specifying the `-FailedMigrationRetryFilePathLB <BasicLoadBalancerbackupFilePath> -FailedMigrationRetryFilePathVMSS <VMSSBackupFile>` parameters. For public load balancers, because the Public IP Address SKU has been updated to Standard, moving the same IP back to a Basic load balancer will not be possible. The basic failure recovery procedure is:
+The module is designed to accommodate failures, either due to unhandled errors or unexpected script termination. The failure design is a 'fail forward' approach, where instead of attempting to move back to the Basic load balancer, you should correct the issue causing the failure (see the error output or log file), and retry the migration again, specifying the `-FailedMigrationRetryFilePathLB <BasicLoadBalancerbackupFilePath> -FailedMigrationRetryFilePathVMSS <VMSSBackupFile>` parameters. For public load balancers, because the Public IP Address SKU has been updated to Standard, moving the same IP back to a Basic load balancer won't be possible. The basic failure recovery procedure is:
 
   1. Address the cause of the migration failure. Check the log file `Start-AzBasicLoadBalancerUpgrade.log` for details
-  1. [Remove the new Standard load balancer](/azure/load-balancer/update-load-balancer-with-vm-scale-set) (if created). Depending on which stage of the migration failed, you may have to remove the Standard load balancer reference from the VMSS network interfaces (IP configurations) and health probes in order to remove the Standard load balancer and try again.
+  1. [Remove the new Standard load balancer](/azure/load-balancer/update-load-balancer-with-vm-scale-set) (if created). Depending on which stage of the migration failed, you may have to remove the Standard load balancer reference from the virtual machine scale set network interfaces (IP configurations) and health probes in order to remove the Standard load balancer and try again.
   1. Locate the basic load balancer state backup file. This will either be in the directory where the script was executed, or at the path specified with the `-RecoveryBackupPath` parameter during the failed execution. The file will be named: `State_<basicLBName>_<basicLBRGName>_<timestamp>.json`
   1. Rerun the migration script, specifying the `-FailedMigrationRetryFilePathLB <BasicLoadBalancerbackupFilePath> -FailedMigrationRetryFilePathVMSS <VMSSBackupFile>` parameters instead of -BasicLoadBalancerName or passing the Basic load balancer over the pipeline