Merge pull request #182568 from craftyhouse/micraft-sfmc-quickfixes

Court72 · web-flow · commit fcbafacb9c05 · 2021-12-14T15:43:24.000-07:00
Update how-to-managed-cluster-modify-node-type.md
diff --git a/articles/service-fabric/how-to-managed-cluster-autoscale.md b/articles/service-fabric/how-to-managed-cluster-autoscale.md
@@ -213,7 +213,7 @@ Some things to consider:
    Suppose you set a rule to scale out when average CPU is greater than 50% over five minutes, and to scale in when average CPU is less than 50%. This setting would cause a "flapping" problem when CPU usage is close to the threshold, with scale actions constantly increasing and decreasing the size of the set. Because of this setting, the autoscale service tries to prevent "flapping", which can manifest as not scaling. Therefore, be sure your scale-out and scale-in thresholds are sufficiently different to allow some space in between scaling.
 
 * Can you scale in or out a node type?
-   Adjust the count of nodes at the node type level and make sure it completes successfully. [How to scale a node type on a managed cluster](./how-to-managed-cluster-modify-node-type.md#scale-a-node-type-manually-with-a-template)
+   Adjust the count of nodes at the node type level and make sure it completes successfully. [How to scale a node type on a managed cluster](how-to-managed-cluster-modify-node-type.md#scale-a-node-type)
 
 * Check your Microsoft.ServiceFabric/managedclusters/nodetypes, and Microsoft.Insights resources in the Azure Resource Explorer
 
diff --git a/articles/service-fabric/how-to-managed-cluster-configuration.md b/articles/service-fabric/how-to-managed-cluster-configuration.md
@@ -15,10 +15,10 @@ In addition to selecting the [Service Fabric managed cluster SKU](overview-manag
 * Configuring [managed identity](how-to-managed-identity-managed-cluster-virtual-machine-scale-sets.md) on cluster node types
 * Enabling [OS and data disk encryption](how-to-managed-cluster-enable-disk-encryption.md) on cluster nodes
 * Configure [autoscaling](how-to-managed-cluster-autoscale.md) on a secondary node type
-* [Manually scale a node type](how-to-managed-cluster-modify-node-type.md#scale-a-node-type-manually-with-portal)
+* [Scale a node type](how-to-managed-cluster-modify-node-type.md#scale-a-node-type)
 * Enable [automatic OS image upgrades](how-to-managed-cluster-modify-node-type.md#enable-automatic-os-image-upgrades) on cluster node types
-* Modify the [OS image](how-to-managed-cluster-modify-node-type.md#modify-the-os-image-for-a-node-type-with-portal) used for a node type
-* Configure [placement properties](how-to-managed-cluster-modify-node-type.md#configure-placement-properties-for-a-node-type-with-portal) for a node type
+* Modify the [OS image](how-to-managed-cluster-modify-node-type.md#modify-the-os-sku-for-a-node-type) used for a node type
+* Configure [placement properties](how-to-managed-cluster-modify-node-type.md#configure-placement-properties-for-a-node-type) for a node type
 * Selecting the cluster [managed disk type](how-to-managed-cluster-managed-disk.md) SKU
 * Configuring cluster [upgrade options](how-to-managed-cluster-upgrades.md) for the runtime updates
 
diff --git a/articles/service-fabric/how-to-managed-cluster-modify-node-type.md b/articles/service-fabric/how-to-managed-cluster-modify-node-type.md
@@ -2,7 +2,7 @@
 title: Configure or modify a Service Fabric managed cluster node type
 description: This article walks through how to modify a managed cluster node type
 ms.topic: how-to
-ms.date: 10/25/2021 
+ms.date: 12/10/2021 
 ---
 
 # Service Fabric managed cluster node types
@@ -15,11 +15,13 @@ The rest of this document will cover how to adjust various settings from creatin
 > You will not be able to modify the node type while a change is in progress. It is recommended to let any requested change complete before doing another.
 
 
-## Add or remove a node type with portal
+## Add a node type
+You can add a node type to a Service Fabric managed cluster through Portal, an Azure Resource Manager template, or PowerShell. 
 
-In this walkthrough, you will learn how to add or remove a node type using portal.
+### Add with portal
+> [!NOTE]
+> You can only add secondary node types using Portal
 
-**To add a node type:**
 1) Log in to [Azure portal](https://portal.azure.com/)
 
 2) Navigate to your cluster resource Overview page. 
@@ -30,29 +32,14 @@ In this walkthrough, you will learn how to add or remove a node type using porta
 
 4) Click `Add` at the top, fill in the required information, then click Add at the bottom, that's it!
 
+5) Wait for the new node type addition to be completed
 
-**To remove a node type:**
-1) Log in to [Azure portal](https://portal.azure.com/)
-
-2) Navigate to your cluster resource Overview page. 
-![Sample Overview page][overview]
-
-3) Select `Node types` under the `Settings` section 
-![Node Types view][addremove]
-
-4) Select the `Node Type` you want to remove and click `Delete` at the top.
-
-> [!NOTE]
-> It is not possible to remove a primary node type if it is the only primary node type in the cluster.
-
-
-## Add a node type with a template
-
-**To add a node type using an ARM Template**
+### Add with an ARM template
 
 Add another resource type `Microsoft.ServiceFabric/managedclusters/nodetypes` with the required values and do a cluster deployment for the setting to take effect.
 
 * The Service Fabric managed cluster resource apiVersion should be **2021-05-01** or later.
+* Make sure to set `isPrimary` to `true` if you are intending to replace an existing primary node type.
 
 ```json
           {
@@ -77,8 +64,70 @@ Add another resource type `Microsoft.ServiceFabric/managedclusters/nodetypes` wi
 ```
 For an example two node type configuration, see our [sample two node type ARM Template](https://github.com/Azure-Samples/service-fabric-cluster-templates/blob/master/SF-Managed-Standard-SKU-2-NT)
 
+### Add with PowerShell
+
+To create a new node type, you'll need to define these properties:
+* **Resource Group**: Resource group the cluster is in
+* **Cluster Name**: Name of the managed cluster
+* **Node Type Name**: Name that is unique from any existing node types in the cluster.
+* **Instance Count**: Initial number of nodes of the new node type.
+* **VM Size**: VM SKU for the nodes. If not specified, the default value *Standard_D2* is used.
+
+> [!NOTE]
+> If adding a primary node type, the `-Primary` property must be used.
+
+```powershell
+$resourceGroup = "myResourceGroup"
+$clusterName = "mysfcluster"
+$nodeTypeName = "nt2"
+$vmSize = "Standard_D2_v2"
+
+New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroup -ClusterName $clusterName -Name $nodeTypeName -InstanceCount 3 -vmSize $vmSize
+```
+
+
+## Remove a node type
+You can remove a Service Fabric managed cluster node type using Portal or PowerShell.
+
+> [!NOTE]
+> To remove a primary node type from a Service Fabric managed cluster, you must use PowerShell and there must be more then one primary node type available.
+
+### Remove with portal
+1) Log in to [Azure portal](https://portal.azure.com/)
+
+2) Navigate to your cluster resource Overview page. 
+![Sample Overview page][overview]
+
+3) Select `Node types` under the `Settings` section 
+![Node Types view][addremove]
+
+4) Select the `Node Type` you want to remove and click `Delete` at the top.
+
+### Remove with PowerShell
+> [!NOTE]
+> If removing a primary node type for scenarios such as upgrading the SKU it will take multiple hours and progress can be monitored by using SFX. Seed nodes will migrate one node per upgrade domain(UD) walk at a time.
 
-## Scale a node type manually with portal
+To remove a node type, you'll need to define these properties:
+* **Resource Group**: Resource group the cluster is in
+* **Cluster Name**: Name of the managed cluster
+* **Node Type Name**: Name that is unique from any existing node types in the cluster.
+
+```powershell
+$resourceGroup = "myResourceGroup"
+$clusterName = "myCluster"
+$nodeTypeName = "nt2"
+
+Remove-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroup -ClusterName $clusterName  -Name $nodeTypeName
+```
+
+
+## Scale a node type 
+You can scale a Service Fabric managed cluster node type with portal, ARM template, or PowerShell. You can also [configure autoscale for a secondary node type](how-to-managed-cluster-autoscale.md) if you want a fully automated solution.
+
+> [!NOTE]
+> For the Primary node type, you will not be able to go below 3 nodes for a Basic SKU cluster, and 5 nodes for a Standard SKU cluster.
+
+### Scale using portal
 
 In this walkthrough, you will learn how to modify the node count for a node type using portal.
 
@@ -98,9 +147,9 @@ In this walkthrough, you will learn how to modify the node count for a node type
 ![Sample showing a node type updating][node-type-updating]
 
 
-## Scale a node type manually with a template
+### Scale a node type with a template
 
-To adjust the node count for a node type using an ARM Template, adjust the `vmInstanceCount` property with the new value and do a cluster deployment for the setting to take effect.
+To adjust the node count for a node type using an ARM Template, adjust the `vmInstanceCount` property with the new value and do a cluster deployment for the setting to take effect. The cluster will begin upgrading automatically you will see the additional nodes when complete.
 
 * The Service Fabric managed cluster resource apiVersion should be **2021-05-01** or later.
 
@@ -122,6 +171,21 @@ To adjust the node count for a node type using an ARM Template, adjust the `vmIn
 }
 ```
 
+### Scale a node type with PowerShell
+Change the instance count to increase or decrease the number of nodes on the node type that you would like to scale. You can find node type names in the Azure Resource Manager template (ARM template) from your cluster deployment, or in the Service Fabric Explorer.  
+
+```powershell
+$resourceGroup = "myResourceGroup"
+$clusterName = "mysfcluster"
+$nodeTypeName = "FE"
+$instanceCount = "7"
+
+Set-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroup -ClusterName $clusterName -name $nodeTypeName -InstanceCount $instanceCount -Verbose
+```
+
+The cluster will begin upgrading automatically you will see the additional nodes when complete.
+
+
 ## Enable automatic OS image upgrades
 
 You can choose to enable automatic OS image upgrades to the virtual machines running your managed cluster nodes. Although the virtual machine scale set resources are managed on your behalf with Service Fabric managed clusters, it's your choice to enable automatic OS image upgrades for your cluster nodes. As with [classic Service Fabric](service-fabric-best-practices-infrastructure-as-code.md#virtual-machine-os-automatic-upgrade-configuration) clusters, managed cluster nodes are not upgraded by default, in order to prevent unintended disruptions to your cluster.
@@ -164,7 +228,10 @@ If an upgrade fails, Service Fabric will retry after 24 hours, for a maximum of
 
 For more on image upgrades, see [Automatic OS image upgrades with Azure virtual machine scale sets](../virtual-machine-scale-sets/virtual-machine-scale-sets-automatic-upgrade.md).
 
-## Modify the OS image for a node type with portal
+## Modify the OS SKU for a node type
+Service Fabric managed clusters enables you to modify the OS SKU for a node type in place. This is helpful for scenarios such as migrating from Windows 2019 to Windows 2022 or if you want to switch to a Server (Core) SKU vs Server with Desktop Experience SKU.
+
+### Modify OS SKU with portal
 
 In this walkthrough, you will learn how to modify the OS image for a node type using portal.
 
@@ -184,7 +251,7 @@ In this walkthrough, you will learn how to modify the OS image for a node type u
 ![Sample showing a node type updating][node-type-updating]
 
 
-## Modify the OS image for a node type with a template
+### Modify OS SKU with a template
 
 To modify the OS image used for a node type using an ARM Template, adjust the `vmImageSku` property with the new value and do a cluster deployment for the setting to take effect. The managed cluster provider will reimage each instance by upgrade domain.
 
@@ -208,7 +275,10 @@ To modify the OS image used for a node type using an ARM Template, adjust the `v
 }
 ```
 
-## Configure placement properties for a node type with portal
+## Configure placement properties for a node type
+[Placement properties](service-fabric-cluster-resource-manager-cluster-description.md#node-properties-and-placement-constraints) are used to ensure that certain workloads run only on certain node types in the cluster. Service Fabric managed clusters support configuring these properties via portal, ARM template, or PowerShell.
+
+### Configure placement properties with portal
 
 In this walkthrough, you will learn how to modify a placement property for a node type using portal.
 
@@ -227,9 +297,8 @@ In this walkthrough, you will learn how to modify a placement property for a nod
 6) The `Provisioning state` will now show a status of `Updating` until complete. When complete, it will show `Succeeded` again.
 ![Sample showing a node type updating][node-type-updating]
 
-You can now use that [placement property to ensure that certain workloads run only on certain types of nodes in the cluster](./service-fabric-cluster-resource-manager-cluster-description.md#node-properties-and-placement-constraints). 
 
-## Configure placement properties for a node type with a template
+### Configure placement properties with a template
 
 To adjust the placement properties for a node type using an ARM Template, adjust the `placementProperties` property with the new value(s) and do a cluster deployment for the setting to take effect. The below sample shows three values being set for a node type.
 
@@ -250,15 +319,24 @@ To adjust the placement properties for a node type using an ARM Template, adjust
         }
 }
 ```
-You can now use that [placement property to ensure that certain workloads run only on certain types of nodes in the cluster](./service-fabric-cluster-resource-manager-cluster-description.md#node-properties-and-placement-constraints). 
+
+### Configure placement properties with PowerShell
+
+The following example will update and overwrite any existing placement properties for a given node type.
+
+```PowerShell
+$rgName = "testRG"
+$clusterName = "testCluster"
+$NodeTypeName = "nt1"
+Set-AzServiceFabricManagedNodeType -ResourceGroupName $rgName -ClusterName $clusterName -name $NodeTypeName -PlacementProperty @{NodeColor="Red";SomeProperty="6";} -Verbose
+```
 
 ## Modify the VM SKU for a node type
 
 Service Fabric managed cluster does not support in-place modification of the VM SKU, but is simpler then classic. In order to accomplish this you'll need to do the following:
-* [Create a new node type](how-to-managed-cluster-modify-node-type.md#add-or-remove-a-node-type-with-portal) with the required VM SKU.
+* [Create a new node type via portal, ARM template, or PowerShell](how-to-managed-cluster-modify-node-type.md#add-a-node-type) with the required VM SKU. You'll need to use a template or PowerShell for adding a primary or stateless node type.
 * Migrate your workload over. One way is to use a [placement property to ensure that certain workloads run only on certain types of nodes in the cluster](./service-fabric-cluster-resource-manager-cluster-description.md#node-properties-and-placement-constraints). 
-* [Delete old node type](how-to-managed-cluster-modify-node-type.md#add-or-remove-a-node-type-with-portal)
-
+* [Delete old node type via portal or PowerShell](how-to-managed-cluster-modify-node-type.md#remove-a-node-type). To remove a primary node type you will have to use PowerShell.
 
 
 ## Configure multiple managed disks (preview)
