Skip to content

Commit fd9b039

Browse files
committed
incorporating feedback
1 parent f053707 commit fd9b039

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

articles/digital-twins/tutorial-facilities-analyze.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ After you deploy your Azure Digital Twins instance, provision your spaces, and i
1616

1717
In [the first tutorial](tutorial-facilities-setup.md), you configured the spatial graph of an imaginary building, with a room that contains sensors for motion, carbon dioxide, and temperature. In [the second tutorial](tutorial-facilities-udf.md), you provisioned your graph and a user-defined function. The function monitors these sensor values and triggers notifications for the right conditions. That is, the room is empty, and the temperature and carbon dioxide levels are normal.
1818

19-
This tutorial shows you how you can integrate the notifications and data coming from your Azure Digital Twins setup with Azure Time Series Insights. You can then visualize your sensor values over time. You can look for trends such as which room is getting the most use and which is the busiest times of the day. You can also detect anomalies such as which rooms feel stuffier and hotter, or whether an area in your building is sending consistently high temperature values, indicating faulty air conditioning.
19+
This tutorial shows you how you can integrate the notifications and data coming from your Azure Digital Twins setup with Azure Time Series Insights. You can then visualize your sensor values over time. You can look for trends such as which room is getting the most use and which are the busiest times of the day. You can also detect anomalies such as which rooms feel stuffier and hotter, or whether an area in your building is sending consistently high temperature values, indicating faulty air conditioning.
2020

2121
In this tutorial, you learn how to:
2222

articles/digital-twins/tutorial-facilities-setup.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ These tutorials use and modify the same samples that the [quickstart to find ava
3737

3838
- An Azure subscription. If you don’t have an Azure account, create a [free account](https://azure.microsoft.com/free/?WT.mc_id=A261C142F).
3939

40-
- The right SDK. The Azure Digital Twins samples used in these tutorials are written in C#. Make sure to install [.NET Core SDK version 2.1.403 or later](https://www.microsoft.com/net/download) on your development machine to build and run the sample. Check that the right version is installed on your machine by running `dotnet --version` in a command window.
40+
- The .NET Core SDK. The Azure Digital Twins samples used in these tutorials are written in C#. Make sure to install [.NET Core SDK version 2.1.403 or later](https://www.microsoft.com/net/download) on your development machine to build and run the sample. Check that the right version is installed on your machine by running `dotnet --version` in a command window.
4141

4242
- [Visual Studio Code](https://code.visualstudio.com/) to explore the sample code.
4343

@@ -56,7 +56,7 @@ Use the steps in this section to create a new instance of the Azure Digital Twin
5656

5757
Digital Twins uses [Azure Active Directory](../active-directory/fundamentals/active-directory-whatis.md) (Azure AD) to control [read/write access](../active-directory/develop/v1-permissions-and-consent.md) to the service. Any application that needs to connect with your Digital Twins instance must be registered with Azure AD. The steps in this section show how to register your sample app.
5858

59-
If you already have an app registration, you can reuse it for your sample. But browse through this section to make sure your app registration is configured correctly.
59+
If you already have an app registration, you can reuse it for your sample. However, browse through this section to make sure your app registration is configured correctly.
6060

6161
[!INCLUDE [digital-twins-permissions](../../includes/digital-twins-permissions.md)]
6262

articles/digital-twins/tutorial-facilities-udf.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,40 +123,40 @@ Also note the section named **roleassignments**. It assigns the Space Administra
123123
f. Remove the following *if-else* code block after the comment `// Modify this code block for your sensor`:
124124

125125
```JavaScript
126-
// If carbonDioxide is less than the threshold and no presence is in the room => log, notify, and set the parent space computed value
126+
// If carbonDioxide less than threshold and no presence in the room => log, notify and set parent space computed value
127127
if(carbonDioxideValue < carbonDioxideThreshold && !presence) {
128128
log(`${availableFresh}. Carbon Dioxide: ${carbonDioxideValue}. Presence: ${presence}.`);
129129
setSpaceValue(parentSpace.Id, spaceAvailFresh, availableFresh);
130130

131-
// Set up a custom notification for air quality
131+
// Set up custom notification for air quality
132132
parentSpace.Notify(JSON.stringify(availableFresh));
133133
}
134134
else {
135135
log(`${noAvailableOrFresh}. Carbon Dioxide: ${carbonDioxideValue}. Presence: ${presence}.`);
136136
setSpaceValue(parentSpace.Id, spaceAvailFresh, noAvailableOrFresh);
137137

138-
// Set up a custom notification for air quality
138+
// Set up custom notification for air quality
139139
parentSpace.Notify(JSON.stringify(noAvailableOrFresh));
140140
}
141141
```
142142

143143
And replace it with the following *if-else* block:
144144

145145
```JavaScript
146-
// If sensor values are within range and the room is available
146+
// If sensor values are within range and room is available
147147
if(carbonDioxideValue < carbonDioxideThreshold && temperatureValue < temperatureThreshold && !presence) {
148148
log(`${alert}. Carbon Dioxide: ${carbonDioxideValue}. Temperature: ${temperatureValue}. Presence: ${presence}.`);
149149

150-
// Log, notify, and set the parent space computed value
150+
// log, notify and set parent space computed value
151151
setSpaceValue(parentSpace.Id, spaceAvailFresh, alert);
152152

153-
// Set up notifications for this alert
153+
// Set up notification for this alert
154154
parentSpace.Notify(JSON.stringify(alert));
155155
}
156156
else {
157157
log(`${noAlert}. Carbon Dioxide: ${carbonDioxideValue}. Temperature: ${temperatureValue}. Presence: ${presence}.`);
158158

159-
// Log, notify, and set the parent space computed value
159+
// log, notify and set parent space computed value
160160
setSpaceValue(parentSpace.Id, spaceAvailFresh, noAlert);
161161
}
162162
```

0 commit comments

Comments
 (0)