Remove more retention policy

Author: aamini7

scenarios/AksOpenAiTerraform/README.md

@@ -13,6 +13,23 @@ ms.custom: innovation-engine, linux-related-content
 Run commands below to set up AKS extensions for Azure.
 
 ```bash
-# ./terraform/register-preview-features.sh
-echo "HI"
-```
+./terraform/register-preview-features.sh
+```
+
+## Set up service principal
+
+A Service Principal is an application within Azure Active Directory with the authentication tokens Terraform needs to perform actions on your behalf.
+
+```bash
+export SUBSCRIPTION_ID="0c8875c7-e423-4caa-827a-1f0350bd8dd3"
+az ad sp create-for-rbac --role="Contributor" --scopes="/subscriptions/$SUBSCRIPTION_ID"
+```
+
+## Set up environment
+
+```bash
+export ARM_CLIENT_ID=""
+export ARM_CLIENT_SECRET=""
+export ARM_SUBSCRIPTION_ID=""
+export ARM_TENANT_ID=""
+```

scenarios/AksOpenAiTerraform/terraform/modules/aks/main.tf

@@ -116,73 +116,33 @@ resource "azurerm_monitor_diagnostic_setting" "settings" {
 
   enabled_log {
     category = "kube-apiserver"
-
-    retention_policy {
-      enabled = true  
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "kube-audit"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "kube-audit-admin"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "kube-controller-manager"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "kube-scheduler"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "cluster-autoscaler"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "guard"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   metric {
     category = "AllMetrics"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 }

scenarios/AksOpenAiTerraform/terraform/modules/diagnostic_setting/main.tf

@@ -15,11 +15,6 @@ resource "azurerm_monitor_diagnostic_setting" "settings" {
     content {
       category = each.key
       enabled  = true
-
-      retention_policy {
-        enabled = var.retention_policy_enabled
-        days    = var.retention_policy_days
-      }
     }
   }
 
@@ -28,11 +23,6 @@ resource "azurerm_monitor_diagnostic_setting" "settings" {
     content {
       category = each.key
       enabled  = true
-
-      retention_policy {
-        enabled = var.retention_policy_enabled
-        days    = var.retention_policy_days
-      }
     }
   }
 }

scenarios/AksOpenAiTerraform/terraform/modules/firewall/main.tf

@@ -232,38 +232,18 @@ resource "azurerm_monitor_diagnostic_setting" "settings" {
 
   enabled_log {
     category = "AzureFirewallApplicationRule"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "AzureFirewallNetworkRule"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "AzureFirewallDnsProxy"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   metric {
     category = "AllMetrics"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 }
 
@@ -274,37 +254,17 @@ resource "azurerm_monitor_diagnostic_setting" "pip_settings" {
 
   enabled_log {
     category = "DDoSProtectionNotifications"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "DDoSMitigationFlowLogs"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   enabled_log {
     category = "DDoSMitigationReports"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
   metric {
     category = "AllMetrics"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 }

scenarios/AksOpenAiTerraform/terraform/modules/network_security_group/main.tf

@@ -39,20 +39,10 @@ resource "azurerm_monitor_diagnostic_setting" "settings" {
 
   enabled_log {
     category = "NetworkSecurityGroupEvent"
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 
  enabled_log {
     category = "NetworkSecurityGroupRuleCounter"
     enabled  = true
-
-    retention_policy {
-      enabled = true
-      days    = var.log_analytics_retention_days
-    }
   }
 }

scenarios/AksOpenAiTerraform/terraform/modules/virtual_network/variables.tf

@@ -37,10 +37,4 @@ variable "tags" {
 variable "log_analytics_workspace_id" {
   description = "Specifies the log analytics workspace id"
   type        = string
-}
-
-variable "log_analytics_retention_days" {
-  description = "Specifies the number of days of the retention policy"
-  type        = number
-  default     = 7
 }