-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add get-csaiagents #13219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get-csaiagents #13219
Conversation
|
Learn Build status updates of commit 1263d95:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md | View (teams-ps) | Details | |
| teams/teams-ps/MicrosoftTeams/Get-CsAiAgents.md | ✅Succeeded | View (teams-ps) |
teams/teams-ps/MicrosoftTeams/MicrosoftTeams.md
- Line 0, Column 0: [Warning: PSMD2Yaml_InconsistentCmdletsInModule]
Inconsistent cmdlets found in module: MicrosoftTeams. 1 cmdlets in the module folder but not listed in the module file: Get-CsAiAgents.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
|
Learn Build status updates of commit 3eb4e8a: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 285833d: ✅ Validation status: passed
For more details, please refer to the build report. |
nomorephones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The synopsis doesn't articulate the purpose of ProviderID. Suggest amendind with "...in the tenant that match with the ProviderID.
-
In the spec, ProviderID is an array allowing for a return of Agents across multiple ProviderIDs. If that's supported in this version, suggest including an example.
-
In the past, I've seen the output of cmdlets as a complex object type. For example, with CsTagsTemplate the output is a "Microsoft.Rtc.Management.Hosted.CallQueue.Models.CallQueue". While the example is definitely appreciated, I'm curious if this still follows the convention.
-
If the GUIDs here are from a real environment, suggest bit-shifting a character by a value or two to obfuscate it.
|
Learn Build status updates of commit 8c384b3: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit dc85378: ✅ Validation status: passed
For more details, please refer to the build report. |
Thanks, updated.
Thanks, added another example
We're a bit uncertain of what the namespace will be for this one. I'll keep this as is for now and make an update once I verify it
Thanks, already randomized some of the fields, I randomized more of them now |
|
Learn Build status updates of commit b5200f9: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 8235aca: ✅ Validation status: passed
For more details, please refer to the build report. |
sdwheeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggested changes and fix the parameter metadata.
|
|
||
| ### Example 1 - Get AI agents from a provider | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` | |
| ```powershell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, updated
|
|
||
| This example gets the AI Agents from ProviderId "9d8f559b-5de4-46a4-902a-ad4271e83efa" that are compatible with Teams Interactive Voice Response (IVR). The output of the Get-CsAiAgents cmdlet is a list of AI Agents, with parameters such as `BotHandle`, `MsaAppId`, `MsaAppTenantId` and more. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` | |
| ```Output | |
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, updated
| Get-CsAiAgents -IsTeamsIvrEnabled -ProviderId "9d8f559b-5de4-46a4-902a-ad4271e83efa" | ||
| ``` | ||
|
|
||
| This example gets the AI Agents from ProviderId "9d8f559b-5de4-46a4-902a-ad4271e83efa" that are compatible with Teams Interactive Voice Response (IVR). The output of the Get-CsAiAgents cmdlet is a list of AI Agents, with parameters such as `BotHandle`, `MsaAppId`, `MsaAppTenantId` and more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph needs to be moved before or after the code blocks. It can't be between them.
|
|
||
| ## DESCRIPTION | ||
|
|
||
| > [!CAUTION] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a NOTE unless it can cause damage.
| > [!CAUTION] | |
| > [!NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK; updated
|
|
||
| ### Example 2 - Get AI agents from mulitple providers | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` | |
| ```powershell |
| Type: System.String | ||
| DefaultValue: '' | ||
| SupportsWildcards: false | ||
| Aliases: [] | ||
| ParameterSets: | ||
| - Name: (All) | ||
| Position: Named | ||
| IsRequired: true | ||
| ValueFromPipeline: false | ||
| ValueFromPipelineByPropertyName: false | ||
| ValueFromRemainingArguments: false | ||
| DontShow: false | ||
| AcceptedValues: [] | ||
| HelpMessage: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the format of the new metadata. You didn't use the old platyPS to create this.
|
Learn Build status updates of commit c17a710: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 300193f: ✅ Validation status: passed
For more details, please refer to the build report. |
sdwheeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks good now.
|
Learn Build status updates of commit 2fa1333: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 432242a: ✅ Validation status: passed
For more details, please refer to the build report. |
Add get-csaiagents