Merge pull request #33696 from MicrosoftDocs/rothja-patch-7

rothja · web-flow · commit 6fb511c2930c · 2025-04-02T12:42:52.000-04:00
Updating workflow to allow triage permissions to sign off as well
diff --git a/.github/workflows/signoff-review.yml b/.github/workflows/signoff-review.yml
@@ -565,7 +565,7 @@ jobs:
                         Write-Host "User $PullRequestOpener permission level: $UserPermission."
 
                         # If user has write or above, allow check to pass. If not, provide a welcome message
-                        If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin"))
+                        If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin")  -or ($UserPermission -eq "triage"))
                         {
                             Write-Host "Approving as pull request creator $PullRequestOpener has permission."
 
@@ -679,7 +679,7 @@ jobs:
                             Write-Host "User $CommentUser permission level: $UserPermission."
 
                             # If user has write or above, allow check to pass. If not, add content team review label.
-                            If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin")) 
+                            If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin")  -or ($UserPermission -eq "triage")) 
                             {
                                 Write-Host "User $CommentUser has the permission level: $UserPermission. Pass check."
 

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ jobs:`
`565`	`565`	`Write-Host "User $PullRequestOpener permission level: $UserPermission."`
`566`	`566`
`567`	`567`	`# If user has write or above, allow check to pass. If not, provide a welcome message`
`568`		`- If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin"))`
	`568`	`+ If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin") -or ($UserPermission -eq "triage"))`
`569`	`569`	`{`
`570`	`570`	`Write-Host "Approving as pull request creator $PullRequestOpener has permission."`
`571`	`571`
`@@ -679,7 +679,7 @@ jobs:`
`679`	`679`	`Write-Host "User $CommentUser permission level: $UserPermission."`
`680`	`680`
`681`	`681`	`# If user has write or above, allow check to pass. If not, add content team review label.`
`682`		`- If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin"))`
	`682`	`+ If (($UserPermission -like "write*") -or ($UserPermission -eq "maintain") -or ($UserPermission -eq "admin") -or ($UserPermission -eq "triage"))`
`683`	`683`	`{`
`684`	`684`	`Write-Host "User $CommentUser has the permission level: $UserPermission. Pass check."`
`685`	`685`