Skip to content

Commit 8bd22f2

Browse files
committed
[object-diff] Escape type and field names
Otherwise templates won't display correctly.
1 parent 4081521 commit 8bd22f2

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

extensions/object-diff/index.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
<title>Object Diff</title>
1212
<script type="text/javascript" src="/jsdbg/loader.js"></script>
1313
<script type="text/javascript">
14+
function htmlEscape(str) {
15+
return str.replace(/</g, "&lt;").replace(/>/g, "&gt;");
16+
}
1417
function init() {
1518
var defaultType = null;
1619
var address1 = null;
@@ -91,7 +94,7 @@
9194
.then(function (results) {
9295
return Promise.map(results, function (fieldName) {
9396
var field1 = object1.f(fieldName);
94-
return Promise.all([field1.then(function (x) { return x.type.name() }), fieldName, field1.desc(), object2.f(fieldName).desc()]);
97+
return Promise.all([field1.then(function (x) { return x.type.htmlName() }), htmlEscape(fieldName), field1.desc(), object2.f(fieldName).desc()]);
9598
})
9699
.then(function (differentObjects) {
97100
var table = document.createElement("table");

0 commit comments

Comments
 (0)