Skip to content

Commit 990db10

Browse files
committed
PR Feedback.
1 parent 96aeb45 commit 990db10

File tree

4 files changed

+112
-20
lines changed

4 files changed

+112
-20
lines changed

diagnostics/WebView2.wprp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<WindowsPerformanceRecorder Version="1.0" Comments="" Company="Microsoft Corporation" Copyright="Microsoft Corporation">
33
<Profiles>
4-
<SystemProvider Id="SystemProvider_Light" Base="SystemProvider_Base">
4+
<SystemProvider Id="SystemProvider_Light">
55
<Keywords>
66
<!-- CPU -->
77
<Keyword Value="ProcessThread"/>
88
<Keyword Value="Loader"/>
99
<Keyword Value="Power"/>
1010
<Keyword Value="CSwitch"/>
1111
<Keyword Value="ReadyThread"/>
12-
<Keyword Value="SampledProfile"/>
1312
<Keyword Value="DPC"/>
1413
<Keyword Value="Interrupt"/>
1514
<Keyword Value="IdleStates"/>
@@ -26,7 +25,6 @@
2625
<Stacks>
2726
<Stack Value="CSwitch"/>
2827
<Stack Value="ReadyThread"/>
29-
<Stack Value="SampledProfile"/>
3028
</Stacks>
3129
</SystemProvider>
3230

diagnostics/WebView2_CPU.wprp

Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<WindowsPerformanceRecorder Version="1.0" Comments="" Company="Microsoft Corporation" Copyright="Microsoft Corporation">
3+
<Profiles>
4+
<SystemProvider Id="SystemProvider_Light">
5+
<Keywords>
6+
<!-- CPU -->
7+
<Keyword Value="ProcessThread"/>
8+
<Keyword Value="Loader"/>
9+
<Keyword Value="Power"/>
10+
<Keyword Value="CSwitch"/>
11+
<Keyword Value="ReadyThread"/>
12+
<Keyword Value="SampledProfile"/>
13+
<Keyword Value="DPC"/>
14+
<Keyword Value="Interrupt"/>
15+
<Keyword Value="IdleStates"/>
16+
17+
<!-- Disk -->
18+
<Keyword Value="DiskIO"/>
19+
<Keyword Value="FileIO"/>
20+
<Keyword Value="HardFaults"/>
21+
22+
<!-- Memory -->
23+
<Keyword Value="MemoryInfo"/>
24+
<Keyword Value="MemoryInfoWS"/>
25+
</Keywords>
26+
<Stacks>
27+
<Stack Value="CSwitch"/>
28+
<Stack Value="ReadyThread"/>
29+
<Stack Value="SampledProfile"/>
30+
</Stacks>
31+
</SystemProvider>
32+
33+
<!-- Crash reporting events -->
34+
<EventProvider Id="EventProvider-Microsoft-Windows-WindowsErrorReporting" Name="cc79cf77-70d9-4082-9b52-23f3a3e92fe4"/>
35+
<EventProvider Id="EventProvider-Microsoft.Windows.FaultReportingTracingGuid" Name="1377561D-9312-452C-AD13-C4A1C9C906E0"/>
36+
37+
<!-- Process, thread, and image load events -->
38+
<EventProvider Id="EventProvider_Microsoft-Windows-Kernel-Process_16_0_68_1_0_0" Name="22fb2cd6-0e7b-422b-a0c7-2fad1fd0e716" NonPagedMemory="true" Stack="true" Level="0" EventKey="true">
39+
<Keywords>
40+
<Keyword Value="0x190" />
41+
</Keywords>
42+
</EventProvider>
43+
44+
<!-- WV2 events. Edge providers are included to support tracing when using pre-release runtimes. -->
45+
<EventProvider Id="Edge" Name="3A5F2396-5C8F-4F1F-9B67-6CCA6C990E61" Level="5">
46+
<Keywords>
47+
<Keyword Value="0x10000000202F"/>
48+
</Keywords>
49+
</EventProvider>
50+
<EventProvider Id="Edge_Canary" Name="C56B8664-45C5-4E65-B3C7-A8D6BD3F2E67" Level="5">
51+
<Keywords>
52+
<Keyword Value="0x3F0000054404"/>
53+
</Keywords>
54+
</EventProvider>
55+
<EventProvider Id="Edge_Dev" Name="D30B5C9F-B58F-4DC9-AFAF-134405D72107" Level="5">
56+
<Keywords>
57+
<Keyword Value="0x3F0000054404"/>
58+
</Keywords>
59+
</EventProvider>
60+
<EventProvider Id="Edge_Beta" Name="BD089BAA-4E52-4794-A887-9E96868570D2" Level="5">
61+
<Keywords>
62+
<Keyword Value="0x3F0000054404"/>
63+
</Keywords>
64+
</EventProvider>
65+
<EventProvider Id="Edge_WebView" Name="E16EC3D2-BB0F-4E8F-BDB8-DE0BEA82DC3D" Level="5">
66+
<Keywords>
67+
<Keyword Value="0x3F0000054404"/>
68+
</Keywords>
69+
</EventProvider>
70+
<EventProvider Id="Provider_V8js" Name="57277741-3638-4A4B-BDBA-0AC6E45DA56C" Level="5" Stack="true"></EventProvider>
71+
72+
<Profile Id="Edge.WebView2.General.Verbose.File" Name="Edge.WebView2.General" LoggingMode="File" DetailLevel="Verbose" Description="Edge.WebView2.General" Default="true">
73+
<Collectors Operation="Add">
74+
<SystemCollectorId Value="SystemCollector_WPRSystemCollectorInFile">
75+
<BufferSize Value="1024"/>
76+
<Buffers Value="100"/>
77+
<SystemProviderId Value="SystemProvider_Light" />
78+
</SystemCollectorId>
79+
<EventCollectorId Value="EventCollector_WPREventCollectorInFile">
80+
<BufferSize Value="1024" />
81+
<Buffers Value="3" PercentageOfTotalMemory="true"/>
82+
<EventProviders Operation="Add">
83+
<EventProviderId Value="EventProvider-Microsoft-Windows-WindowsErrorReporting"/>
84+
<EventProviderId Value="EventProvider-Microsoft.Windows.FaultReportingTracingGuid"/>
85+
<EventProviderId Value="EventProvider_Microsoft-Windows-Kernel-Process_16_0_68_1_0_0" />
86+
<EventProviderId Value="Edge" />
87+
<EventProviderId Value="Edge_Canary" />
88+
<EventProviderId Value="Edge_Dev" />
89+
<EventProviderId Value="Edge_Beta" />
90+
<EventProviderId Value="Edge_WebView" />
91+
<EventProviderId Value="Provider_V8js"></EventProviderId>
92+
</EventProviders>
93+
</EventCollectorId>
94+
</Collectors>
95+
</Profile>
96+
</Profiles>
97+
</WindowsPerformanceRecorder>

diagnostics/gpu.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ On the device that is hitting the issue:
99
1. Share the `dxdiag.txt` file
1010

1111
## GPU Logs
12-
1. Navigate your WV2 to `edge://gpu`
12+
1. Navigate your WV2 to `edge://gpu`. This needs to be done programmatically inside the application, and can't be done via DevTools console or similar means.
1313
1. Wait for the page to load content under the "Log Messages" header towards the bottom.
1414
1. Hit "Copy Report to Clipboard" at the top
1515
1. Paste it into a text file, and share it.

diagnostics/install.md

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,23 @@
11
# Installer / Setup Logs
22
Installer logs include information about any errors that WV2's installer/updater hit when trying to install or update the WV2 runtime. There are a few different logs that we need to best look in to any issues.
33

4-
## Registry Key
5-
This registry contains important update information like when the last update occurred, recent error codes, and updater version information.
6-
1. Open `regedit.exe`
7-
2. Find `HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\EdgeUpdate`
8-
3. Select it, click "File" and choose "Export..."
9-
4. Name it `registryoutput.txt`, change "Save as Type" to .txt, and ensure "Selected branch" is the path from step #2.
10-
5. Click Save.
4+
## Installer History & File List
5+
There are some registry keys that contain important update information like when the last update occurred, recent error codes, and updater version information. The list of installed files that actually exist the device is also helpful in case there are errors or other processes removing them.
6+
7+
1. Open a command prompt.
8+
2. Run `reg export HKCU\SOFTWARE\Microsoft\EdgeUpdate\ClientState EdgeRegistryUser.txt`
9+
3. Run `reg export HKLM\SOFTWARE\Microsoft\EdgeUpdate\ClientState EdgeRegistryMachine.txt /reg:32`
10+
4. Run `dir "c:\Program Files (x86)\Microsoft\EdgeWebView" /s > EdgeFiles.txt`
11+
5. Run `dir "c:\Program Files (x86)\Microsoft\EdgeCore" /s >> EdgeFiles.txt`
12+
13+
You should now have three files: `EdgeRegistryUser.txt`, `EdgeRegistryMachine.txt`, and `EdgeFiles.txt`.
1114

1215
## Installer Logs
13-
There are three places where WV2's updater will write potentially important logs:
16+
There are four places where WV2's updater will write important details about any install or update issues. If you don't have all of these that's not a problem, include what exists:
1417

1518
1. `C:\ProgramData\Microsoft\EdgeUpdate\Log\MicrosoftEdgeUpdate.log`
1619
2. `%localappdata%\Temp\MicrosoftEdgeUpdate.log`
1720
3. `C:\Windows\Temp\msedge_installer.log`
21+
3. `%systemroot%\Temp\msedge_installer.log`
1822

19-
If you don't have all three of these, that's not a problem.
20-
21-
## List of Installed WV2 Files
22-
Finally, including a list of all the files installed by WV2 will let us understand if there is something missing in your installation causing the issue.
23-
1. Open a command prompt.
24-
2. Run `dir /s /b "c:\Program Files (x86)\Microsoft\EdgeWebView\" > edgefiles.txt` this creates `edgefiles.txt` with the list of files.
25-
26-
Once you have all five of these files: `registryoutput.txt`, `msedge_installer.log`, `edgefiles.txt`, and the two `MicrosoftEdgeUpdate.log`s, share them with the WV2 developer who is helping you.
23+
Once you have these files, share them with the WV2 developer who is helping you.

0 commit comments

Comments
 (0)