Skip to content

Commit f184b12

Browse files
authored
Merge pull request #134 from MicrosoftEdge/update-wincomp-sample-app
Update sample app to use Windows SDK 10.0.2XXX and fix header missing issue
2 parents 223e199 + 9731d18 commit f184b12

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

SampleApps/WebView2SampleWinComp/CompositionHost.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
#include "pch.h"
66

7+
#include <winrt/Windows.Foundation.Collections.h>
78
#include "CheckFailure.h"
89
#include "CompositionHost.h"
910
#include <d2d1_1.h>

SampleApps/WebView2SampleWinComp/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ To learn more specifics about events and API Handlers in WebView2, you can refer
1717
- [Microsoft Edge (Chromium)](https://www.microsoftedgeinsider.com/download/) installed on a supported OS. Currently we recommend the latest version of the Edge Canary channel.
1818
- [Visual Studio](https://visualstudio.microsoft.com/vs/) with C++ support installed.
1919
- Latest pre-release version of our [WebView2 SDK](https://aka.ms/webviewnuget), which is included in this project.
20+
- By default this sample app will use the latest Window 10 SDK version. However, there is an issue with Windows 10 SDK, version 2004 (10.0.19041.0) that will stop this sample app from building. When running into this issue, either install the later version (Windows 10 SDK version 2104 (10.0.20348.0)) or retarget the project to an older version of Windows SDK (Windows 10 SDK, version 1903 (10.0.18362.1)). Windows 10 SDK version 2104 (10.0.20348.0) and Windows 10 SDK, version 1903 (10.0.18362.1) can be downloaded [here](https://developer.microsoft.com/en-us/windows/downloads/sdk-archive/)).
2021

2122
## Build the WebView2 Sample WinComp
2223

SampleApps/WebView2SampleWinComp/WebView2SampleWinComp.vcxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<Keyword>Win32Proj</Keyword>
2424
<ProjectGuid>{abac8d87-c87b-455c-8340-0a9b0cd9a206}</ProjectGuid>
2525
<RootNamespace>WebView2SampleWinComp</RootNamespace>
26-
<WindowsTargetPlatformVersion>10.0.18362.0</WindowsTargetPlatformVersion>
26+
<WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
2727
</PropertyGroup>
2828
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2929
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">

0 commit comments

Comments
 (0)