refactor: PR feedback

Author: yt-ms

src/structurizr/model/model.py

@@ -29,6 +29,9 @@
 from .container_instance import ContainerInstance
 from .element import Element
 from .enterprise import Enterprise, EnterpriseIO
+from .implied_relationship_strategies import (
+    ignore_implied_relationship_strategy as ignore_implied,
+)
 from .person import Person, PersonIO
 from .relationship import Relationship
 from .sequential_integer_id_generator import SequentialIntegerIDGenerator
@@ -96,7 +99,7 @@ def __init__(
         people: Optional[Iterable[Person]] = (),
         software_systems: Iterable[SoftwareSystem] = (),
         deployment_nodes: Iterable[DeploymentNode] = (),
-        implied_relationship_strategy: Optional[Callable[[Relationship], None]] = None,
+        implied_relationship_strategy: Callable[[Relationship], None] = ignore_implied,
         **kwargs,
     ) -> None:
         """
@@ -397,10 +400,7 @@ def _add_relationship(
         )
         self._add_relationship_to_internal_structures(relationship)
 
-        if (
-            create_implied_relationships
-            and self.implied_relationship_strategy is not None
-        ):
+        if create_implied_relationships:
             self.implied_relationship_strategy(relationship)
         return True
 

tests/integration/test_implied_relationship_strategies.py

@@ -26,22 +26,10 @@
 )
 
 
-def test_by_default_model_doesnt_create_implied_relationships():
+def test_by_default_model_ignores_implied_relationships():
     """Check if not set on Model, no implied relationships are added."""
     model = Model()
-    assert model.implied_relationship_strategy is None
-
-    system1 = model.add_software_system(name="system1")
-    container1 = system1.add_container(name="container1", description="test")
-    system2 = model.add_software_system(name="system2")
-    container2 = system2.add_container(name="container2", description="test")
-
-    rel = container1.uses(container2, "Uses")
-
-    assert len(list(container1.get_relationships())) == 1
-    assert len(list(system1.get_relationships())) == 0
-    assert set(container1.get_relationships()) == {rel}
-    assert set(system1.get_relationships()) == set()
+    assert model.implied_relationship_strategy is ignore
 
 
 def test_ignore_implied_relationship_strategy():