fix(DeploymentNode): interaction style is tag-based so does not replicate onto deployment node relationships

Author: yt-ms

src/structurizr/model/relationship.py

@@ -94,7 +94,6 @@ def __init__(
         self._destination_id = destination_id
         self.description = description
         self.technology = technology
-        self.interaction_style = interaction_style
         self.linked_relationship_id = linked_relationship_id
 
         self.tags.add(Tags.RELATIONSHIP)
@@ -124,9 +123,9 @@ def destination_id(self) -> str:
     def interaction_style(self) -> str:
         """Return the interaction style of the relationship based on its tags."""
         return (
-            InteractionStyle.Synchronous
-            if Tags.SYNCHRONOUS in self.tags
-            else InteractionStyle.Asynchronous
+            InteractionStyle.Asynchronous
+            if Tags.ASYNCHRONOUS in self.tags
+            else InteractionStyle.Synchronous
         )
 
     @classmethod

tests/integration/test_relationship_replication.py

@@ -72,13 +72,13 @@ def test_replication_adds_relationships_in_the_same_environment(empty_model: Mod
     live_deployment_node.add_container(container3)
     live_deployment_node.add_software_system(system4)
 
+    # Note that because the tags are cleared the interaction style won't be replicated
     assert len(container_instance1.relationships) == 1
     relationship = next(iter(container_instance1.relationships))
     assert relationship.source is container_instance1
     assert relationship.destination is container_instance2
     assert relationship.description == "Uses 1"
     assert relationship.technology == "Technology 1"
-    assert relationship.interaction_style == InteractionStyle.Synchronous
     assert relationship.tags == set()
 
     assert len(container_instance2.relationships) == 1
@@ -87,7 +87,6 @@ def test_replication_adds_relationships_in_the_same_environment(empty_model: Mod
     assert relationship.destination is container_instance3
     assert relationship.description == "Uses 2"
     assert relationship.technology == "Technology 2"
-    assert relationship.interaction_style == InteractionStyle.Asynchronous
     assert relationship.tags == set()
 
     assert len(container_instance3.relationships) == 1
@@ -96,7 +95,6 @@ def test_replication_adds_relationships_in_the_same_environment(empty_model: Mod
     assert relationship.destination is system_instance
     assert relationship.description == "Uses"
     assert relationship.technology == ""
-    assert relationship.interaction_style == InteractionStyle.Synchronous
     assert relationship.tags == set()
 
 

tests/unit/model/test_relationship.py

@@ -15,10 +15,11 @@
 
 """Ensure the expected behaviour of relationships."""
 
-
 import pytest
 
+from structurizr.model.interaction_style import InteractionStyle
 from structurizr.model.relationship import Relationship
+from structurizr.model.tags import Tags
 
 
 @pytest.mark.parametrize(
@@ -30,3 +31,16 @@ def test_relationship_init(attributes):
     relationship = Relationship(**attributes)
     for attr, expected in attributes.items():
         assert getattr(relationship, attr) == expected
+
+
+def test_relationship_interaction_style():
+    """Test that interaction style is consistent with tags."""
+    relationship = Relationship(interaction_style=InteractionStyle.Synchronous)
+    assert Tags.SYNCHRONOUS in relationship.tags
+    assert Tags.ASYNCHRONOUS not in relationship.tags
+    assert relationship.interaction_style == InteractionStyle.Synchronous
+
+    relationship = Relationship(interaction_style=InteractionStyle.Asynchronous)
+    assert Tags.SYNCHRONOUS not in relationship.tags
+    assert Tags.ASYNCHRONOUS in relationship.tags
+    assert relationship.interaction_style == InteractionStyle.Asynchronous