Skip to content

Commit da5b553

Browse files
yt-msMidnighter
authored andcommitted
refactor: remove redundant Model.add_container_instance()
1 parent 91d05d5 commit da5b553

File tree

1 file changed

+2
-32
lines changed

1 file changed

+2
-32
lines changed

src/structurizr/model/model.py

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323

2424
from ..abstract_base import AbstractBase
2525
from ..base_model import BaseModel
26-
from .container import Container
27-
from .container_instance import ContainerInstance
2826
from .deployment_node import DeploymentNode, DeploymentNodeIO
2927
from .element import Element
3028
from .enterprise import Enterprise, EnterpriseIO
@@ -188,7 +186,7 @@ def add_person(self, person=None, **kwargs) -> Person:
188186
self += person
189187
return person
190188

191-
def add_software_system(self, **kwargs) -> SoftwareSystem:
189+
def add_software_system(self, name: str, **kwargs) -> SoftwareSystem:
192190
"""
193191
Add a new software system to the model.
194192
@@ -206,7 +204,7 @@ def add_software_system(self, **kwargs) -> SoftwareSystem:
206204
SoftwareSystem
207205
208206
"""
209-
software_system = SoftwareSystem(**kwargs)
207+
software_system = SoftwareSystem(name=name, **kwargs)
210208
self += software_system
211209
return software_system
212210

@@ -243,34 +241,6 @@ def __iadd__(self, element: Element) -> "Model":
243241
self._add_element(element)
244242
return self
245243

246-
def add_container_instance(
247-
self,
248-
deployment_node: DeploymentNode,
249-
container: Container,
250-
replicate_container_relationships: bool,
251-
) -> ContainerInstance:
252-
"""
253-
Add a new container instance to the model.
254-
255-
Args:
256-
deployment_node (DeploymentNode, optional): `DeploymentNode` instance
257-
container (Container, optional): `Container` instance
258-
259-
Returns:
260-
ContainerInstance: A container instance.
261-
262-
Raises:
263-
ValueError: When a container with the same name already exists.
264-
265-
See Also:
266-
ContainerInstance
267-
268-
"""
269-
if container is None:
270-
raise ValueError("A container must be specified.")
271-
# TODO: implement
272-
# instance_number =
273-
274244
def add_deployment_node(
275245
self,
276246
name: str,

0 commit comments

Comments
 (0)