Skip to content

Commit 993d825

Browse files
authored
Merge pull request #166 from MightyCreak/show-build-tools-versions
Show build tools version in GitHub actions
2 parents c843e81 + 4422db5 commit 993d825

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,14 @@ jobs:
2525
pip install -r requirements.dev.txt
2626
2727
- name: Flake8
28-
run: flake8 src/ po/
28+
run: |
29+
flake8 --version
30+
flake8 src/ po/
2931
3032
- name: MyPy
31-
run: mypy src/ po/
33+
run: |
34+
mypy --version
35+
mypy src/ po/
3236
3337
meson-build-test:
3438
runs-on: ubuntu-latest

docs/developers/developers-setup.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Requirements
44

55
Diffuse depends on these projects:
6+
67
* Python 3.8+
78
* PyPi
89
* Cairo and GObject Introspection development headers
@@ -28,7 +29,7 @@ _Note: Tested on Debian 11 (Buster) and Ubuntu 20.04 (Focal)_
2829
<summary>Fedora</summary>
2930

3031
```sh
31-
sudo dnf install python-pip python3-cairo-devel python3-gobject-devel meson flatpak flatpak-builder
32+
sudo dnf install python-pip cairo-devel cairo-gobject-devel meson flatpak flatpak-builder
3233
```
3334

3435
_Note: Tested on Fedora 34_

src/diffuse/resources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ def getOption(self, option: str) -> str:
318318

319319
def getOptionAsBool(self, option: str) -> bool:
320320
'''Get the option value, casted as a boolean.'''
321-
return util.strtobool(self.getOption(option))
321+
return bool(util.strtobool(self.getOption(option)))
322322

323323
# string resources
324324
def getString(self, symbol: str) -> str:

0 commit comments

Comments
 (0)