fix #3703

asiekierka · asiekierka · commit 0d3fdfe6655d · 2025-01-05T13:29:10.000+01:00
diff --git a/src/main/scala/li/cil/oc/common/PacketHandler.scala b/src/main/scala/li/cil/oc/common/PacketHandler.scala
@@ -38,6 +38,10 @@ abstract class PacketHandler {
       if (stream != null) {
         stream.close()
       }
+      // #3703 - neither 1.7.10 nor 1.12.2 release the packet ByteBuf by themselves
+      if (data != null && data.refCnt() > 0) {
+        data.release();
+      }
     }
 
     // Avoid AFK kicks by marking players as non-idle when they send packets.

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,10 @@ abstract class PacketHandler {`
`38`	`38`	`if (stream != null) {`
`39`	`39`	`stream.close()`
`40`	`40`	`}`
	`41`	`+ // #3703 - neither 1.7.10 nor 1.12.2 release the packet ByteBuf by themselves`
	`42`	`+ if (data != null && data.refCnt() > 0) {`
	`43`	`+ data.release();`
	`44`	`+ }`
`41`	`45`	`}`
`42`	`46`
`43`	`47`	`// Avoid AFK kicks by marking players as non-idle when they send packets.`