Skip to content

Commit 490ef6a

Browse files
authored
feat: add use_browser and change args action to store_true (#72)
* feat: add use_browser and change args action to store_true * feat: change description
1 parent 3346d9d commit 490ef6a

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

.github/workflows/IntegrationTest.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ jobs:
3737
- name: Integration Test(local plaintext)
3838
run: |
3939
python -m dingo.run.cli --input_path test/data/test_local_plaintext.txt --dataset local -e default --data_format plaintext
40+
python -m dingo.run.cli --input_path test/data/test_local_plaintext.txt --dataset local -e default --data_format plaintext --save_data
4041
- name: Integration Test(local json)
4142
run: |
4243
python -m dingo.run.cli --input_path test/data/test_local_json.json --dataset local -e default --data_format json --column_content prediction

dingo/io/input/InputArgs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ class InputArgs(BaseModel):
4545
custom_config: Optional[str | dict] = None
4646

4747
log_level: str = 'WARNING'
48+
use_browser: bool = False
4849

4950
class Config:
5051
extra = 'forbid' # Forbid extra parameters

dingo/run/cli.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ def parse_args():
2020
default=None, help="Input file or directory path")
2121
parser.add_argument("--output_path", type=str,
2222
default=None, help="Output file or directory path")
23-
parser.add_argument("--save_data", type=bool,
24-
default=None, help="Save data in output path")
25-
parser.add_argument("--save_correct", type=bool,
26-
default=None, help="Save correct data in output path")
27-
parser.add_argument("--save_raw", type=bool,
28-
default=None, help="Save raw data in output path")
23+
parser.add_argument("--save_data", action="store_true",
24+
default=False, help="Save data in output path")
25+
parser.add_argument("--save_correct", action="store_true",
26+
default=False, help="Save correct data in output path")
27+
parser.add_argument("--save_raw", action="store_true",
28+
default=False, help="Save raw data in output path")
2929
parser.add_argument("--start_index", type=int,
3030
default=None, help="The number of data start to check.")
3131
parser.add_argument("--end_index", type=int,
@@ -59,6 +59,8 @@ def parse_args():
5959
parser.add_argument("--log_level", type=str,
6060
default="WARNING", choices=["DEBUG", "INFO", "WARNING", "ERROR"],
6161
help="Choose the logging level in [\"DEBUG\", \"INFO\", " + "\"WARNING\", \"ERROR\"], default is 'WARNING'")
62+
parser.add_argument("--use_browser", action="store_true",
63+
default=False, help="Open browser to display result after evaluation.")
6264
return parser.parse_args()
6365

6466

@@ -134,11 +136,13 @@ def parse_args():
134136
input_data['custom_config'] = args.custom_config
135137
if args.log_level:
136138
input_data['log_level'] = args.log_level
139+
if args.use_browser:
140+
input_data['use_browser'] = args.use_browser
137141

138142
input_args = InputArgs(**input_data)
139143
executor = Executor.exec_map['local'](input_args)
140144
result = executor.execute()
141145
print(result)
142146

143-
if input_args.save_data:
147+
if input_args.use_browser and input_args.save_data:
144148
os.system("python -m dingo.run.vsl --input " + result.output_path)

0 commit comments

Comments
 (0)