Skip to content

Commit 4c09803

Browse files
committed
feat: fix bug miss first reason
1 parent b641ffd commit 4c09803

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

dingo/model/rule/rule_common.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ def eval(cls, input_data: Data) -> EvalDetail:
3333
res.status = True
3434
# res.merge(tmp_res)
3535
res.label = [f"{cls.metric_type}.{cls.__name__}"]
36-
res.reason = [] if res.reason is None else res.reason.extend(tmp_res.reason)
36+
if res.reason is None:
37+
res.reason = []
38+
res.reason.extend(tmp_res.reason)
3739
# Set QUALITY_GOOD when all checks pass
3840
if not res.status:
3941
res.label = [QualityLabel.QUALITY_GOOD]
@@ -63,7 +65,9 @@ def eval(cls, input_data: Data) -> EvalDetail:
6365
res.status = True
6466
# res.merge(tmp_res)
6567
res.label = [f"{cls.metric_type}.{cls.__name__}"]
66-
res.reason = [] if res.reason is None else res.reason.extend(tmp_res.reason)
68+
if res.reason is None:
69+
res.reason = []
70+
res.reason.extend(tmp_res.reason)
6771
# Set QUALITY_GOOD when all checks pass
6872
if not res.status:
6973
res.label = [QualityLabel.QUALITY_GOOD]
@@ -647,7 +651,9 @@ def eval(cls, input_data: Data) -> EvalDetail:
647651
res.status = True
648652
# res.merge(tmp_res)
649653
res.label = [f"{cls.metric_type}.{cls.__name__}"]
650-
res.reason = [] if res.reason is None else res.reason.extend(tmp_res.reason)
654+
if res.reason is None:
655+
res.reason = []
656+
res.reason.extend(tmp_res.reason)
651657
# Set QUALITY_GOOD when all checks pass
652658
if not res.status:
653659
res.label = [QualityLabel.QUALITY_GOOD]

0 commit comments

Comments
 (0)