Skip to content

Commit 90ef09d

Browse files
MihaiCristianCondreaMihaiCristianCondrea
committed
Refactor lesson item and ad views
- Updated lesson item icon to use ShapeableImageView with Material3 styling. - Removed MaterialCardView from the ad layout for a flatter design. - Adjusted padding and margins for better visual consistency.
1 parent c8b87b5 commit 90ef09d

File tree

2 files changed

+51
-56
lines changed

2 files changed

+51
-56
lines changed

‎app/src/main/res/layout/ad_bottom_app_bar.xml‎

Lines changed: 42 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,74 +1,65 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<com.google.android.gms.ads.nativead.NativeAdView xmlns:android="http://schemas.android.com/apk/res/android"
3-
xmlns:app="http://schemas.android.com/apk/res-auto"
43
android:layout_width="match_parent"
54
android:layout_height="wrap_content">
65

7-
<com.google.android.material.card.MaterialCardView
8-
android:id="@+id/ad_card"
9-
style="@style/Widget.Material3.CardView.Outlined"
6+
<LinearLayout
7+
android:id="@+id/ad_host"
108
android:layout_width="match_parent"
119
android:layout_height="wrap_content"
12-
app:cardUseCompatPadding="false"
13-
app:cardPreventCornerOverlap="true">
10+
android:orientation="vertical"
11+
android:background="?attr/colorSurfaceContainer"
12+
android:paddingHorizontal="16dp">
13+
14+
<include
15+
android:layout_width="wrap_content"
16+
android:layout_height="wrap_content"
17+
android:layout_marginTop="4dp"
18+
layout="@layout/ad_attribution" />
1419

1520
<LinearLayout
16-
android:id="@+id/ad_host"
1721
android:layout_width="match_parent"
1822
android:layout_height="wrap_content"
19-
android:orientation="vertical"
20-
android:background="?attr/colorSurfaceContainer"
21-
android:paddingStart="16dp"
22-
android:paddingEnd="16dp"
23-
android:paddingTop="12dp"
24-
android:paddingBottom="12dp">
23+
android:gravity="center_vertical"
24+
android:orientation="horizontal">
2525

26-
<include layout="@layout/ad_attribution" />
26+
<androidx.appcompat.widget.AppCompatImageView
27+
android:id="@+id/ad_app_icon"
28+
android:layout_width="32dp"
29+
android:layout_height="32dp"
30+
android:layout_marginEnd="12dp" />
2731

2832
<LinearLayout
29-
android:layout_width="match_parent"
33+
android:layout_width="0dp"
3034
android:layout_height="wrap_content"
31-
android:gravity="center_vertical"
32-
android:orientation="horizontal">
35+
android:layout_weight="1"
36+
android:orientation="vertical">
3337

34-
<ImageView
35-
android:id="@+id/ad_app_icon"
36-
android:layout_width="32dp"
37-
android:layout_height="32dp"
38-
android:layout_marginEnd="12dp" />
39-
40-
<LinearLayout
41-
android:layout_width="0dp"
38+
<TextView
39+
android:id="@+id/ad_headline"
40+
android:layout_width="wrap_content"
4241
android:layout_height="wrap_content"
43-
android:layout_weight="1"
44-
android:orientation="vertical">
42+
android:ellipsize="end"
43+
android:maxLines="1"
44+
android:textAppearance="@style/TextAppearance.Material3.BodyMedium" />
4545

46-
<TextView
47-
android:id="@+id/ad_headline"
48-
android:layout_width="wrap_content"
49-
android:layout_height="wrap_content"
50-
android:ellipsize="end"
51-
android:maxLines="1"
52-
android:textAppearance="@style/TextAppearance.Material3.BodyMedium" />
53-
54-
<TextView
55-
android:id="@+id/ad_body"
56-
android:layout_width="wrap_content"
57-
android:layout_height="wrap_content"
58-
android:ellipsize="end"
59-
android:maxLines="1"
60-
android:textAppearance="@style/TextAppearance.Material3.BodySmall" />
61-
</LinearLayout>
62-
63-
<com.google.android.material.button.MaterialButton
64-
android:id="@+id/ad_call_to_action"
65-
style="@style/Widget.Material3.Button.TextButton"
46+
<TextView
47+
android:id="@+id/ad_body"
6648
android:layout_width="wrap_content"
6749
android:layout_height="wrap_content"
68-
android:minWidth="88dp"
69-
android:minHeight="40dp"
70-
android:layout_marginStart="8dp" />
50+
android:ellipsize="end"
51+
android:maxLines="1"
52+
android:textAppearance="@style/TextAppearance.Material3.BodySmall" />
7153
</LinearLayout>
54+
55+
<com.google.android.material.button.MaterialButton
56+
android:id="@+id/ad_call_to_action"
57+
style="@style/Widget.Material3.Button.TextButton"
58+
android:layout_width="wrap_content"
59+
android:layout_height="wrap_content"
60+
android:minWidth="88dp"
61+
android:minHeight="40dp"
62+
android:layout_marginStart="8dp" />
7263
</LinearLayout>
73-
</com.google.android.material.card.MaterialCardView>
64+
</LinearLayout>
7465
</com.google.android.gms.ads.nativead.NativeAdView>

‎app/src/main/res/layout/item_android_studio_lesson.xml‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,20 @@
1111
<LinearLayout
1212
android:layout_width="match_parent"
1313
android:layout_height="wrap_content"
14-
android:orientation="horizontal"
1514
android:gravity="center_vertical"
15+
android:orientation="horizontal"
1616
android:padding="12dp">
1717

18-
<ImageView
18+
<com.google.android.material.imageview.ShapeableImageView
1919
android:id="@+id/lesson_icon"
20-
android:layout_width="40dp"
21-
android:layout_height="40dp"
20+
android:layout_width="32dp"
21+
android:layout_height="32dp"
22+
app:contentPadding="4dp"
2223
android:layout_marginEnd="16dp"
23-
android:contentDescription="@null" />
24+
android:background="?attr/colorPrimaryContainer"
25+
android:contentDescription="@null"
26+
android:scaleType="centerCrop"
27+
app:shapeAppearanceOverlay="@style/ShapeAppearance.Material3.Corner.Full" />
2428

2529
<LinearLayout
2630
android:layout_width="0dp"

0 commit comments

Comments
 (0)