Skip to content

Commit c6f2989

Browse files
test: remove static time mocking
1 parent 52ba9f4 commit c6f2989

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

app/src/test/java/com/d4rk/androidtutorials/java/data/source/DefaultHomeLocalDataSourceTest.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import static org.junit.Assert.assertEquals;
44
import static org.mockito.Mockito.mock;
5-
import static org.mockito.Mockito.mockStatic;
65
import static org.mockito.Mockito.when;
76

87
import android.content.Context;
@@ -11,7 +10,6 @@
1110
import com.d4rk.androidtutorials.java.R;
1211

1312
import org.junit.Test;
14-
import org.mockito.MockedStatic;
1513

1614
public class DefaultHomeLocalDataSourceTest {
1715

@@ -25,16 +23,13 @@ public void playStoreUrlsFormattedCorrectly() {
2523

2624
@Test
2725
public void dailyTipUsesEpochDayIndex() {
28-
Context context = mockContextWithTips(new String[]{"tip1", "tip2", "tip3"});
26+
String[] tips = {"tip1", "tip2", "tip3"};
27+
Context context = mockContextWithTips(tips);
2928
DefaultHomeLocalDataSource dataSource = new DefaultHomeLocalDataSource(context);
3029

31-
long days = 5L; // 5 days since epoch -> index = 2
32-
long millis = days * 24L * 60L * 60L * 1000L;
33-
34-
try (MockedStatic<System> mocked = mockStatic(System.class)) {
35-
mocked.when(System::currentTimeMillis).thenReturn(millis);
36-
assertEquals("tip3", dataSource.getDailyTip());
37-
}
30+
long daysSinceEpoch = System.currentTimeMillis() / (24L * 60L * 60L * 1000L);
31+
int expectedIndex = (int) (daysSinceEpoch % tips.length);
32+
assertEquals(tips[expectedIndex], dataSource.getDailyTip());
3833
}
3934

4035
private static Context mockContextWithTips(String[] tips) {

0 commit comments

Comments
 (0)