Skip to content

[feat] 유저 로그인 과정 리펙토링 #591

@sohyundoh

Description

@sohyundoh

📌 Feature Issue

📝 To-do

    private LoginSuccessResponse getTokenDto(
            final UserInfoResponse userResponse
    ) {
        try {
            if (userService.isExistingUser(userResponse.socialId(), userResponse.socialType())) {
                Long userId = userService.getBySocialId(userResponse.socialId(), userResponse.socialType()).getId();
                return getTokenByUserId(userId, userService.getJoinedRoleFromUser(userId));
            } else {
                Long id = userService.createUser(userResponse.socialId(), userResponse.socialType(), userResponse.email());
                return getTokenByUserId(id, new HashMap<>());
            }
        } catch (DataIntegrityViolationException e) {
            Long userId = userService.getBySocialId(userResponse.socialId(), userResponse.socialType()).getId();
            return getTokenByUserId(userId, userService.getJoinedRoleFromUser(userId));
        }
    }

이 부분 너무 비효율적이라 리팩토링 진행하겠습니다~

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions