Skip to content

Commit 2ab5f47

Browse files
committed
Merge branch '7.0.x' into development
2 parents aab1b9c + ae7e80e commit 2ab5f47

File tree

4 files changed

+22
-31
lines changed

4 files changed

+22
-31
lines changed

CHANGELOG.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,17 @@ All notable changes to this project will be documented in this file. See [standa
327327
* remove unused loading from f-units ([c4c38fa](https://github.com/macite/doubtfire-deploy/commit/c4c38fad4fbdfe248e383cf247f949197ad0a047))
328328
* use tailwindcss classes ([8d7e160](https://github.com/macite/doubtfire-deploy/commit/8d7e160e2d40c42284ee0c1fc85d6d9e01166cda))
329329

330-
### [7.0.22](https://github.com/macite/doubtfire-deploy/compare/v7.0.21...v7.0.22) (2024-05-31)
331330

331+
### [7.0.23](https://github.com/macite/doubtfire-deploy/compare/v7.0.22...v7.0.23) (2024-06-04)
332+
333+
334+
### Bug Fixes
335+
336+
* tidy up portfolio marking page to avoid save issues ([58d091f](https://github.com/macite/doubtfire-deploy/commit/58d091fe52e108a6063907b3b486ff14648862d1))
337+
* update entity service to correct portfolio progress load ([96cd698](https://github.com/macite/doubtfire-deploy/commit/96cd6984073b689adcc85207ce54913a07f5c5f1))
338+
339+
340+
### [7.0.22](https://github.com/macite/doubtfire-deploy/compare/v7.0.21...v7.0.22) (2024-05-31)
332341

333342
### Features
334343

package-lock.json

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
"ng-flex-layout": "^17.3.4-beta.1",
8383
"ng2-pdf-viewer": "^10.0",
8484
"ngx-bootstrap": "^6.1.0",
85-
"ngx-entity-service": "^0.0.38",
85+
"ngx-entity-service": "^0.0.39",
8686
"ngx-lottie": "^11.0.2",
8787
"nvd3": "1.8.6",
8888
"rxjs": "~7.4.0",

src/app/units/states/portfolios/portfolios.tpl.html

Lines changed: 5 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -249,31 +249,7 @@ <h4 class="panel-title">Grade for {{selectedStudent.student.name}}</h4>
249249
</div>
250250
<div class="panel-body alignment-rater">
251251
<div class="col-sm-12 rationale-wrapper">
252-
<div
253-
tooltip="Click to edit rationale"
254-
tooltip-placement="left"
255-
tooltip-append-to-body="false"
256-
tooltip-popup-delay="300"
257-
tooltip-enable="project.gradeRationale != null"
258-
ng-click="toggleEditRationale()"
259-
class="rationale"
260-
ng-class="{'no-rationale': project.gradeRationale == null}"
261-
ng-hide="editingRationale"
262-
>
263-
<label class="text-muted" ng-show="project.gradeRationale != null"> Provided Rationale </label>
264-
<div ng-bind-html="(project.gradeRationale || 'No rationale provided') | markdown | to_trusted"></div>
265-
<div class="small" ng-hide="project.gradeRationale">Click to add one</div>
266-
</div>
267-
<div ng-if="editingRationale" class="clearfix">
268-
<div
269-
contenteditable
270-
ng-model="project.gradeRationale"
271-
placeholder="Edit rationale here..."
272-
style="border-style: solid; border-width: thin; height: 200px"
273-
></div>
274-
<a ng-click="toggleEditRationale(alignment)" class="pull-right">Done Editing</a>
275-
</div>
276-
{{project.gradeRationale}}
252+
<textarea id="gradeRationale" style="height: 160px" class="form-control" ng-model="project.gradeRationale"></textarea>
277253
</div>
278254

279255
<div ng-repeat="results in gradeResults">
@@ -282,12 +258,16 @@ <h5 class="col-sm-2">{{results.name}}</h5>
282258
<label
283259
ng-repeat="resultScore in results.scores"
284260
ng-click="project.assignGrade(resultScore, project.gradeRationale)"
261+
ng-disabled="!project.gradeRationale"
285262
class="btn col-sm-2 text-center {{project.grade == resultScore ? 'btn-primary' : 'btn-default'}}"
286263
>
287264
{{resultScore}}
288265
</label>
289266
</p>
290267
</div>
268+
<div>
269+
<button class="btn btn-primary pull-right col-md-3" ng-click="project.assignGrade(project.grade, project.gradeRationale)" ng-disabled="!project.gradeRationale">Save</button>
270+
</div>
291271
</div>
292272
</div>
293273
</div>

0 commit comments

Comments
 (0)