Push block_on_async_exn to top level

Author: cjjdespres

src/app/dump_blocks/dump_blocks.ml

@@ -82,9 +82,11 @@ let output_block : type a. a -> a codec io -> unit =
 *)
 let f (type a) ?parent (outputs : a codec io list) make_breadcrumb =
   Async.Thread_safe.block_on_async_exn (fun () ->
-      let frontier = create_frontier ~epoch_ledger_backing_type:Stable_db () in
-      let root = Full_frontier.root frontier in
       let open Async_kernel.Deferred.Let_syntax in
+      let%bind frontier =
+        create_frontier ~epoch_ledger_backing_type:Stable_db ()
+      in
+      let root = Full_frontier.root frontier in
       let%map breadcrumb = make_breadcrumb root in
       List.iter outputs ~f:(fun output ->
           let module Enc = (val output.encoding) in

src/lib/mina_lmdb_storage/block.ml

@@ -182,7 +182,8 @@ let%test_module "Block storage tests" =
       Quickcheck.test (gen_breadcrumb ~verifier ()) ~trials:1
         ~f:(fun make_breadcrumb ->
           let frontier =
-            create_frontier ~epoch_ledger_backing_type:Stable_db ()
+            Async.Thread_safe.block_on_async_exn (fun () ->
+                create_frontier ~epoch_ledger_backing_type:Stable_db () )
           in
           let root = Full_frontier.root frontier in
           let reader, writer = Pipe.create () in
@@ -211,7 +212,8 @@ let%test_module "Block storage tests" =
       Quickcheck.test (gen_breadcrumb ~verifier ()) ~trials:4
         ~f:(fun make_breadcrumb ->
           let frontier =
-            create_frontier ~epoch_ledger_backing_type:Stable_db ()
+            Async.Thread_safe.block_on_async_exn (fun () ->
+                create_frontier ~epoch_ledger_backing_type:Stable_db () )
           in
           let root = Full_frontier.root frontier in
           let reader, writer = Pipe.create () in

src/lib/transition_frontier/full_frontier/full_frontier.ml

@@ -987,6 +987,7 @@ module For_tests = struct
 
   let create_frontier ~epoch_ledger_backing_type () =
     let open Core in
+    let open Async.Deferred.Let_syntax in
     let epoch_ledger_location =
       Filename.temp_dir_name ^/ "epoch_ledger"
       ^ (Uuid_unix.create () |> Uuid.to_string)
@@ -1025,8 +1026,9 @@ module For_tests = struct
         ~directory:(Filename.temp_file "snarked_ledger" "")
         ~ledger_depth
     in
-    Async.Thread_safe.block_on_async_exn (fun () ->
-        Persistent_root.reset_to_genesis_exn persistent_root ~precomputed_values ) ;
+    let%map () =
+      Persistent_root.reset_to_genesis_exn persistent_root ~precomputed_values
+    in
     let persistent_root_instance =
       Persistent_root.create_instance_exn persistent_root
     in

src/lib/transition_frontier/full_frontier/full_frontier.mli

@@ -89,7 +89,7 @@ module For_tests : sig
   val create_frontier :
        epoch_ledger_backing_type:Mina_ledger.Ledger.Root.Config.backing_type
     -> unit
-    -> t
+    -> t Async_kernel.Deferred.t
 
   val clean_up_persistent_root : frontier:t -> unit
 

src/lib/transition_frontier/tests/full_frontier_tests.ml

@@ -34,7 +34,7 @@ let%test_module "Full_frontier tests" =
       Quickcheck.test (gen_breadcrumb ~verifier ()) ~trials:4
         ~f:(fun make_breadcrumb ->
           Async.Thread_safe.block_on_async_exn (fun () ->
-              let frontier =
+              let%bind frontier =
                 create_frontier ~epoch_ledger_backing_type:Stable_db ()
               in
               let root = Full_frontier.root frontier in
@@ -58,7 +58,7 @@ let%test_module "Full_frontier tests" =
       Quickcheck.test gen_branches ~trials:4
         ~f:(fun (make_short_branch, make_long_branch) ->
           Async.Thread_safe.block_on_async_exn (fun () ->
-              let frontier =
+              let%bind frontier =
                 create_frontier ~epoch_ledger_backing_type:Stable_db ()
               in
               let test_best_tip ?message breadcrumb =
@@ -93,7 +93,7 @@ let%test_module "Full_frontier tests" =
         ~trials:4
         ~f:(fun make_seq ->
           Async.Thread_safe.block_on_async_exn (fun () ->
-              let frontier =
+              let%bind frontier =
                 create_frontier ~epoch_ledger_backing_type:Stable_db ()
               in
               let root = Full_frontier.root frontier in
@@ -123,7 +123,7 @@ let%test_module "Full_frontier tests" =
         ~trials:2
         ~f:(fun make_seq ->
           Async.Thread_safe.block_on_async_exn (fun () ->
-              let frontier =
+              let%bind frontier =
                 create_frontier ~epoch_ledger_backing_type:Stable_db ()
               in
               let root = Full_frontier.root frontier in
@@ -152,7 +152,7 @@ let%test_module "Full_frontier tests" =
       in
       Quickcheck.test gen ~trials:4 ~f:(fun make_seq ->
           Async.Thread_safe.block_on_async_exn (fun () ->
-              let frontier =
+              let%bind frontier =
                 create_frontier ~epoch_ledger_backing_type:Stable_db ()
               in
               let root = Full_frontier.root frontier in
@@ -181,7 +181,7 @@ let%test_module "Full_frontier tests" =
       Quickcheck.test gen ~trials:4
         ~f:(fun (make_ancestors, make_branch_a, make_branch_b) ->
           Async.Thread_safe.block_on_async_exn (fun () ->
-              let frontier =
+              let%bind frontier =
                 create_frontier ~epoch_ledger_backing_type:Stable_db ()
               in
               let root = Full_frontier.root frontier in