explicitly add sleep ensuring scheduler have chance to slide in an execution of upgrade script when loading precomputed archive blocks

Author: glyh

src/test/archive/archive_node_tests/live_upgrade_archive.ml

@@ -48,7 +48,7 @@ let test_case (test_data : t) =
   let%bind () =
     Daemon.archive_blocks_from_files daemon.executor
       ~archive_address:test_data.archive.config.server_port ~format:`Precomputed
-      precomputed_blocks
+      ~sleep:5 precomputed_blocks
   in
   [%log info] "Loaded all precomputed blocks" ;
   let%bind () = Ivar.read upgrade_script_finished in

src/test/mina_automation/daemon.ml

@@ -193,7 +193,6 @@ type t = { config : Config.t; executor : Executor.t }
 let archive_blocks_from_files t ~archive_address ~format ?(sleep = 5) blocks =
   Deferred.List.iter blocks ~f:(fun block ->
       let%bind _ = archive_blocks t ~archive_address ~format [ block ] () in
-      (* WARN: live upgrade test expect this sleep to be present so we can emulate a race condition *)
       after (Time.Span.of_sec (Float.of_int sleep)) )
 
 let of_config config = { config; executor = Executor.AutoDetect }