Merge branch 'master' into dkijania/remove_terraform_files

Author: dkijania

buildkite/scripts/build-artifact.sh

@@ -17,8 +17,7 @@ else
 fi
 
 
-# TODO: Stop building lib_p2p multiple times by pulling from buildkite-agent artifacts or docker or somewhere
-echo "--- Build libp2p_helper TODO: use the previously uploaded build artifact"
+echo "--- Build libp2p_helper"
 make -C src/app/libp2p_helper
 
 MAINNET_TARGETS=""

buildkite/src/Command/Libp2pHelperBuild.dhall

@@ -16,8 +16,6 @@ let JobSpec = ../Pipeline/JobSpec.dhall
 
 let Size = ./Size.dhall
 
-let Libp2p = ./Libp2pHelperBuild.dhall
-
 let DockerImage = ./DockerImage.dhall
 
 let DebianVersions = ../Constants/DebianVersions.dhall
@@ -320,20 +318,14 @@ let onlyDebianPipeline
     =     \(spec : MinaBuildSpec.Type)
       ->  pipelineBuilder
             spec
-            [ Libp2p.step spec.debVersion spec.buildFlags
-            , build_artifacts spec
-            , publish_to_debian_repo spec
-            ]
+            [ build_artifacts spec, publish_to_debian_repo spec ]
 
 let pipeline
     : MinaBuildSpec.Type -> Pipeline.Config.Type
     =     \(spec : MinaBuildSpec.Type)
       ->  pipelineBuilder
             spec
-            (   [ Libp2p.step spec.debVersion spec.buildFlags
-                , build_artifacts spec
-                , publish_to_debian_repo spec
-                ]
+            (   [ build_artifacts spec, publish_to_debian_repo spec ]
               # docker_commands spec
             )
 

buildkite/src/Command/MinaArtifact.dhall

@@ -1,5 +1,3 @@
-let B = ../../External/Buildkite.dhall
-
 let SelectFiles = ../../Lib/SelectFiles.dhall
 
 let Pipeline = ../../Pipeline/Dsl.dhall
@@ -14,8 +12,6 @@ let Command = ../../Command/Base.dhall
 
 let Size = ../../Command/Size.dhall
 
-let B/SoftFail = B.definitions/commandStep/properties/soft_fail/Type
-
 in  Pipeline.build
       Pipeline.Config::{
       , spec = JobSpec::{
@@ -39,8 +35,9 @@ in  Pipeline.build
               [ Cmd.runInDocker
                   Cmd.Docker::{
                   , image = (../../Constants/ContainerImages.dhall).xrefcheck
+                  , useBash = False
                   }
-                  (     "awesome_bot -allow-dupe "
+                  (     "awesome_bot --allow-dupe "
                     ++  "--allow-redirect "
                     ++  "--allow 403,401 "
                     ++  "--skip-save-results "
@@ -55,7 +52,6 @@ in  Pipeline.build
             , label = "Verifies references in markdown"
             , key = "xrefcheck"
             , target = Size.Multi
-            , soft_fail = Some (B/SoftFail.Boolean True)
             }
         ]
       }