Merge pull request #17803 from MinaProtocol/lyh/improve-archive-test

Improve archive node test error message

Author: glyh

src/test/archive/archive_node_tests/archive_precomputed_blocks_test.ml

@@ -80,14 +80,14 @@ let extract_perf_metrics log_file =
               if String.Map.mem entry.metadata "is_perf_metric" then
                 let time_in_ms =
                   String.Map.find entry.metadata "elapsed"
-                  |> Option.value_exn
+                  |> Option.value_exn ~here:[%here]
                        ~message:
                          ("Missing elapsed in log entry in log line: " ^ line)
                   |> Yojson.Safe.Util.to_float
                 in
                 let label =
                   String.Map.find entry.metadata "label"
-                  |> Option.value_exn
+                  |> Option.value_exn ~here:[%here]
                        ~message:
                          ("Missing label in log entry in log line: " ^ line)
                   |> Yojson.Safe.Util.to_string

src/test/archive/archive_node_tests/dune

@@ -14,8 +14,8 @@
    ;; mina libraries
    mina_automation
    mina_automation.fixture
-   mina_automation.runner
- )
+   mina_automation.runner)
+ 
  (instrumentation (backend bisect_ppx))
- (preprocess (pps ppx_version ppx_jane ppx_mina ppx_compare))
-)
+ (preprocess (pps ppx_version ppx_jane ppx_mina ppx_compare)))
+

src/test/archive/archive_node_tests/upgrade_archive.ml

@@ -4,6 +4,20 @@ open Mina_automation
 open Mina_automation_fixture.Archive
 open Common
 
+(* NOTE:
+   To run this test, several preparation is needed
+   - ensure we have this test, replayer & archive node build with devnet profile
+   - ensure we have a data base instance up
+   - Run the following:
+     ```
+     MINA_TEST_POSTGRES_URI=postgres://postgres:xxxx@localhost:5432 \
+     MINA_TEST_NETWORK_DATA=./src/test/archive/sample_db \
+     DUNE_PROFILE=devnet \
+     dune exec src/test/archive/archive_node_tests/archive_node_tests.exe -- \
+     test upgrade_archive
+     ```
+*)
+
 type t = Mina_automation_fixture.Archive.after_bootstrap
 
 let test_case (test_data : t) =

src/test/mina_automation/psql.ml

@@ -46,7 +46,11 @@ let create_credential_arg ~connection =
     match connection with
     | Conn_str conn_str ->
         let uri = conn_str |> Uri.of_string in
-        let password = uri |> Uri.password |> Option.value_exn in
+        let password =
+          uri |> Uri.password
+          |> Option.value_exn ~here:[%here]
+               ~message:"No password provided for postgres connection!"
+        in
         let user = uri |> Uri.user in
         let host = uri |> Uri.host in
         let port = uri |> Uri.port in