You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(** Converts a [Position.t] into the Rust-compatible type [Kimchi_types.wire].
@@ -110,15 +110,18 @@ module Gate_spec = struct
110
110
111
111
(* TODO: split kind/coeffs from row/wired_to *)
112
112
113
-
(** A gate/row/constraint consists of a type (kind), a row, the other cells its columns/cells are connected to (wired_to), and the selector polynomial associated with the gate. *)
113
+
(** A gate/row/constraint consists of a type (kind), a row, the other cells
114
+
its columns/cells are connected to (wired_to), and the selector polynomial
115
+
associated with the gate. *)
114
116
type('row, 'f) t =
115
117
{ kind : Kimchi_gate_type.t
116
118
;wired_to : 'rowPosition.tarray
117
119
;coeffs : 'farray
118
120
}
119
121
[@@deriving sexp_of]
120
122
121
-
(** Applies a function [f] to the [row] of [t] and all the rows of its [wired_to]. *)
123
+
(** Applies a function [f] to the [row] of [t] and all the rows of its
(** the Poseidon state is an array of states (and states are arrays of size 3). *)
167
+
(** the Poseidon state is an array of states (and states are arrays of
168
+
size 3). *)
165
169
| Poseidonof { state : 'field_vararrayarray }
166
170
| EC_add_completeof
167
171
{ p1 : 'field_var*'field_var
@@ -899,16 +903,21 @@ let finalize_runtime_lookup_tables sys =
899
903
|Compiled_runtime_tables_cfg_ ->
900
904
failwith "Runtime table configurations have already been finalized"
901
905
902
-
(* TODO: shouldn't that Make create something bounded by a signature? As we know what a back end should be? Check where this is used *)
906
+
(* TODO: shouldn't that Make create something bounded by a signature? As we know
907
+
what a back end should be? Check where this is used *)
903
908
904
-
(* TODO: glossary of terms in this file (terms, reducing, feeding) + module doc *)
909
+
(* TODO: glossary of terms in this file (terms, reducing, feeding) + module
910
+
doc *)
905
911
906
912
(* TODO: rename Fp to F or Field *)
907
913
908
914
(** ? *)
909
915
moduleMake
910
916
(Fp : Field.S)
911
-
(* We create a type for gate vector, instead of using `Gate.t list`. If we did, we would have to convert it to a `Gate.t array` to pass it across the FFI boundary, where then it gets converted to a `Vec<Gate>`; it's more efficient to just create the `Vec<Gate>` directly.
917
+
(* We create a type for gate vector, instead of using `Gate.t list`. If we
918
+
did, we would have to convert it to a `Gate.t array` to pass it across the
919
+
FFI boundary, where then it gets converted to a `Vec<Gate>`; it's more
920
+
efficient to just create the `Vec<Gate>` directly.
912
921
*)
913
922
(Gates : Gate_vector_intf with type field := Fp.t)
914
923
(Params : sig
@@ -1048,7 +1057,8 @@ end = struct
1048
1057
res
1049
1058
1050
1059
(** Compute the witness, given the constraint system `sys`
1051
-
and a function that converts the indexed secret inputs to their concrete values.
1060
+
and a function that converts the indexed secret inputs to their concrete
1061
+
values.
1052
1062
*)
1053
1063
letcompute_witness (sys: t) (external_values: int -> Fp.t) :
0 commit comments