Merge pull request #17413 from MinaProtocol/dw/rocksdb-warning-error

dannywillems · web-flow · commit fe57c275dfe8 · 2025-07-02T10:23:23.000+02:00
Rocksdb/dune: treat warnings as errors
diff --git a/src/lib/rocksdb/database.ml b/src/lib/rocksdb/database.ml
@@ -1,4 +1,5 @@
 (* rocksdb.ml -- expose RocksDB operations for Mina *)
+open Core_kernel
 
 type t = { uuid : Uuid.Stable.V1.t; db : (Rocks.t[@sexp.opaque]) }
 [@@deriving sexp]
diff --git a/src/lib/rocksdb/database.mli b/src/lib/rocksdb/database.mli
@@ -1,3 +1,5 @@
+open Core_kernel
+
 type uuid := Uuid.Stable.V1.t
 
 type key := Bigstring.t
diff --git a/src/lib/rocksdb/dune b/src/lib/rocksdb/dune
@@ -2,7 +2,7 @@
  (name rocksdb)
  (public_name rocksdb)
  (library_flags -linkall)
- (flags -open Core_kernel)
+ (flags (:standard -warn-error +a))
  (libraries
   ;; opam libraries
   async
diff --git a/src/lib/rocksdb/intf.ml b/src/lib/rocksdb/intf.ml
@@ -1,3 +1,5 @@
+open Core_kernel
+
 module Key = struct
   module type S = sig
     type 'a t
diff --git a/src/lib/rocksdb/serializable.ml b/src/lib/rocksdb/serializable.ml
@@ -1,3 +1,5 @@
+open Core_kernel
+
 module Make (Key : Binable.S) (Value : Binable.S) :
   Key_value_database.Intf.S
     with module M := Key_value_database.Monad.Ident
diff --git a/src/lib/rocksdb/serializable.mli b/src/lib/rocksdb/serializable.mli
@@ -1,3 +1,5 @@
+open Core_kernel
+
 module Make (Key : Binable.S) (Value : Binable.S) :
   Key_value_database.Intf.S
     with module M := Key_value_database.Monad.Ident

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`(* rocksdb.ml -- expose RocksDB operations for Mina *)`
	`2`	`+open Core_kernel`
`2`	`3`
`3`	`4`	`type t = { uuid : Uuid.Stable.V1.t; db : (Rocks.t[@sexp.opaque]) }`
`4`	`5`	`[@@deriving sexp]`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+open Core_kernel`
	`2`	`+`
`1`	`3`	`module Make (Key : Binable.S) (Value : Binable.S) :`
`2`	`4`	`Key_value_database.Intf.S`
`3`	`5`	`with module M := Key_value_database.Monad.Ident`