Merge pull request #17517 from MinaProtocol/lyh/batch-lmdb-remove

Lmdb: use batch remove to multiple keys

Author: glyh

src/lib/disk_cache/lmdb/disk_cache.ml

@@ -72,8 +72,7 @@ module Make (Data : Binable.S) = struct
 
     Error_checking_mutex.critical_section queue_guard ~f:(fun () ->
         if Queue.length reusable_keys >= reuse_size_limit then (
-          Queue.iter reusable_keys ~f:(fun to_remove ->
-              Rw.remove ~env db to_remove ) ;
+          Rw.batch_remove ~env db reusable_keys ;
           Queue.clear reusable_keys ) ) ;
     Rw.set ~env db idx x ;
     res

src/lib/lmdb_storage/generic.ml

@@ -237,4 +237,8 @@ module Read_write (F_func : F) = struct
 
   let remove ~env:t db key =
     with_env t ~perm:Rw ~default:() ~f:(fun env -> remove_impl ~env db key)
+
+  let batch_remove ~env:t db keys =
+    with_env t ~perm:Rw ~default:() ~f:(fun env ->
+        Queue.iter keys ~f:(remove_impl ~env db) )
 end

src/lib/lmdb_storage/generic.mli

@@ -56,6 +56,8 @@ module Read_write : functor (F_func : F) -> sig
 
   val remove : env:t -> ('k, 'v) Db.t -> 'k -> unit
 
+  val batch_remove : env:t -> ('k, 'v) Db.t -> 'k Core_kernel.Queue.t -> unit
+
   val with_txn :
        ?perm:[ `Read | `Write ] Lmdb.perm
     -> f:(Db.getter -> Db.setter -> 'r)